Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12615 Router-based HDFS federation phase 2
  3. HDFS-13289

RBF: TestConnectionManager#testCleanup() test case need correction

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.10.0, 2.9.1, 3.2.0, 3.1.1, 3.0.3
    • None
    • None

    Description

      In TestConnectionManager#testCleanup() 

       

      // Make sure the number of connections doesn't go below minSize
      ConnectionPool pool3 = new ConnectionPool(
      conf, TEST_NN_ADDRESS, TEST_USER3, 2, 10);
      addConnectionsToPool(pool3, 10, 0);
      poolMap.put(new ConnectionPoolId(TEST_USER2, TEST_NN_ADDRESS), pool3);
      connManager.cleanup(pool3);
      checkPoolConnections(TEST_USER3, 2, 0);
      

      this part need correction

      Here new ConnectionPoolId is created with TEST_USER2 but checkPoolConnections is done using TEST_USER3. 

      In checkPoolConnections method 

      if (e.getKey().getUgi() == ugi)
      

      then only it will validate numOfConns and numOfActiveConns. In this case for TEST_USER3  ' if  'condition is returning false and if you pass any value to the checkPoolConnections method, the test case will pass.

      Attachments

        1. HDFS-13289.001.patch
          2 kB
          Dibyendu Karmakar
        2. HDFS-13289.002.patch
          2 kB
          Dibyendu Karmakar
        3. HDFS-13289.003.patch
          2 kB
          Dibyendu Karmakar
        4. HDFS-13289.004.patch
          2 kB
          Dibyendu Karmakar
        5. HDFS-13289.005.patch
          3 kB
          Dibyendu Karmakar
        6. HDFS-13289.006.patch
          3 kB
          Dibyendu Karmakar

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dibyendu_hadoop Dibyendu Karmakar
            dibyendu_hadoop Dibyendu Karmakar
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment