[HDFS-13289] RBF: TestConnectionManager#testCleanup() test case need correction

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.10.0, 2.9.1, 3.2.0, 3.1.1, 3.0.3
• Target Version/s: 2.10.0, 2.9.1, 3.0.2, 3.2.0
• Hadoop Flags: Reviewed
• Assignee: Dibyendu Karmakar
• Reporter: Dibyendu Karmakar
• Created: 15/Mar/18 03:06
• Updated: 05/Apr/18 20:53
• Resolved: 31/Mar/18 16:48

Description

In TestConnectionManager#testCleanup() 

 

// Make sure the number of connections doesn't go below minSize
ConnectionPool pool3 = new ConnectionPool(
conf, TEST_NN_ADDRESS, TEST_USER3, 2, 10);
addConnectionsToPool(pool3, 10, 0);
poolMap.put(new ConnectionPoolId(TEST_USER2, TEST_NN_ADDRESS), pool3);
connManager.cleanup(pool3);
checkPoolConnections(TEST_USER3, 2, 0);

this part need correction

Here new ConnectionPoolId is created with TEST_USER2 but checkPoolConnections is done using TEST_USER3. 

In checkPoolConnections method 

if (e.getKey().getUgi() == ugi)

then only it will validate numOfConns and numOfActiveConns. In this case for TEST_USER3  ' if  'condition is returning false and if you pass any value to the checkPoolConnections method, the test case will pass.

Issue Links

• is related to: HDFS-13232 RBF: ConnectionPool should return first usable connection