[HDFS-13261] Fix incorrect null value check

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.8.3, 3.0.0
• Fix Version/s: 3.1.0, 2.10.0
• Component/s: hdfs
• Hadoop Flags: Reviewed
• Assignee: Jianfei Jiang
• Reporter: Jianfei Jiang
• Created: 12/Mar/18 14:37
• Updated: 26/Jul/19 13:01
• Resolved: 15/Mar/18 03:15

Description

 

public void setZoneName(final String name) {
  Preconditions.checkNotNull(name == null)-------error parameter for checkNotNull
  zoneName = name;
}

Like above, in 3.x, the checkNotNull function gets wrong parameter in two cases: ZoneReencryptionStatus#setZoneName and AdminHelper#HelpCommand#HelpCommand

In 2.x, the error occurs once in AdminHelper#HelpCommand#HelpCommand

 

Issue Links

• duplicates: HDFS-12309 Incorrect null check in the AdminHelper.java