[HDFS-13232] RBF: ConnectionPool should return first usable connection

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.1.0, 2.10.0, 2.9.1, 3.0.3
• Hadoop Flags: Reviewed
• Assignee: Ekanth Sethuramalingam
• Reporter: Wei Yan
• Created: 06/Mar/18 00:58
• Updated: 05/Apr/18 20:49
• Resolved: 10/Mar/18 02:29

Description

In current ConnectionPool.getConnection(), it will return the first active connection:

for (int i=0; i<size; i++) {
  int index = (threadIndex + i) % size;
  conn = tmpConnections.get(index);
  if (conn != null && !conn.isUsable()) {
    return conn;
  }
}

Here "!conn.isUsable()" should be "conn.isUsable()".

Issue Links

• is related to: HDFS-13230 RBF: ConnectionManager's cleanup task will compare each pool's own active conns with its total conns
• relates to: HDFS-13289 RBF: TestConnectionManager#testCleanup() test case need correction