Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1322

Document umask in DistributedFileSystem#mkdirs javadocs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.3-alpha
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The javadoc of DFSClient.mkdirs() says that the permissions of created dir will be set to dirPermission, which is not done currently. This should talk about umask.

      1. HDFS-1322.001.patch
        3 kB
        Colin Patrick McCabe
      2. HDFS-1322.002.patch
        3 kB
        Colin Patrick McCabe
      3. HDFS-1322.patch
        0.9 kB
        Plamen Jeliazkov

        Issue Links

          Activity

          Ravi Gummadi created issue -
          Ravi Gummadi made changes -
          Field Original Value New Value
          Description DistributedFileSystem.mkdirs(dir, dirPermission) calls DFSClient.mkdirs(dir, dirPermission) to create directory and then set permissions to (dirPermission & umask). Is this the intended behaviour ? I expect it to set permissions of dir to dirPermission instead of doing an AND with umask ---- similar to what 'chmod -m mode' does.

          The javadoc of DFSClient.mkdirs() says that the permissions of created dir will be set to dirPermission, which is not done currently. This needs to be modified based on the actual behaviour.

          This is not an issue in RawLocalFileSystem.
          DistributedFileSystem.mkdirs(dir, dirPermission) calls DFSClient.mkdirs(dir, dirPermission) to create directory and then set permissions to (dirPermission & ~umask). Is this the intended behaviour ? I expect it to set permissions of dir to dirPermission instead of doing an AND with ~umask ---- similar to what 'chmod -m mode' does.

          The javadoc of DFSClient.mkdirs() says that the permissions of created dir will be set to dirPermission, which is not done currently. This needs to be modified based on the actual behaviour.

          This is not an issue in RawLocalFileSystem.
          Todd Lipcon made changes -
          Link This issue relates to HADOOP-6897 [ HADOOP-6897 ]
          Aaron T. Myers made changes -
          Labels newbie
          Anwar Abdus-Samad made changes -
          Assignee Anwar Abdus-Samad [ jabdussa ]
          Plamen Jeliazkov made changes -
          Attachment HDFS-1322.patch [ 12488012 ]
          Colin Patrick McCabe made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Invalid [ 6 ]
          Colin Patrick McCabe made changes -
          Resolution Invalid [ 6 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Assignee Anwar Abdus-Samad [ jabdussa ] Colin Patrick McCabe [ cmccabe ]
          Colin Patrick McCabe made changes -
          Description DistributedFileSystem.mkdirs(dir, dirPermission) calls DFSClient.mkdirs(dir, dirPermission) to create directory and then set permissions to (dirPermission & ~umask). Is this the intended behaviour ? I expect it to set permissions of dir to dirPermission instead of doing an AND with ~umask ---- similar to what 'chmod -m mode' does.

          The javadoc of DFSClient.mkdirs() says that the permissions of created dir will be set to dirPermission, which is not done currently. This needs to be modified based on the actual behaviour.

          This is not an issue in RawLocalFileSystem.
          The javadoc of DFSClient.mkdirs() says that the permissions of created dir will be set to dirPermission, which is not done currently. This should talk about umask.
          Colin Patrick McCabe made changes -
          Attachment HDFS-1322.001.patch [ 12546625 ]
          Colin Patrick McCabe made changes -
          Status Reopened [ 4 ] Patch Available [ 10002 ]
          Colin Patrick McCabe made changes -
          Attachment HDFS-1322.002.patch [ 12553220 ]
          Eli Collins made changes -
          Summary DistributedFileSystem.mkdirs(dir, dirPermission) doesn't set the permissions of created dir to dirPermission Document umask in DistributedFileSystem#mkdirs javadocs
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 2.0.3-alpha [ 12323274 ]
          Resolution Fixed [ 1 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Colin Patrick McCabe
              Reporter:
              Ravi Gummadi
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development