[HDFS-13217] Audit log all EC policy names during addErasureCodingPolicies

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.2.0, 3.1.2
• Component/s: erasure-coding
• Target Version/s: 3.2.0
• Hadoop Flags: Reviewed
• Assignee: liaoyuxiangqin
• Reporter: liaoyuxiangqin
• Created: 02/Mar/18 07:40
• Updated: 20/Aug/18 22:12
• Resolved: 15/Aug/18 16:23

Description

When i read the addErasureCodingPolicies() of FSNamesystem class in namenode, i found the following code only used last ec policy name for  logAuditEvent, i think this audit log can't track whole policies for the add multiple erasure coding policies to the ErasureCodingPolicyManager. Thanks.

FSNamesystem.java

try {
      checkOperation(OperationCategory.WRITE);
      checkNameNodeSafeMode("Cannot add erasure coding policy");
      for (ErasureCodingPolicy policy : policies) {
        try {
          ErasureCodingPolicy newPolicy =
              FSDirErasureCodingOp.addErasureCodingPolicy(this, policy,
                  logRetryCache);
          addECPolicyName = newPolicy.getName();
          responses.add(new AddErasureCodingPolicyResponse(newPolicy));
        } catch (HadoopIllegalArgumentException e) {
          responses.add(new AddErasureCodingPolicyResponse(policy, e));
        }
      }
      success = true;
      return responses.toArray(new AddErasureCodingPolicyResponse[0]);
    } finally {
      writeUnlock(operationName);
      if (success) {
        getEditLog().logSync();
      }
      logAuditEvent(success, operationName,addECPolicyName, null, null);
    }

Issue Links

• is duplicated by: HDFS-13218 Log audit event only used last EC policy name when add multiple policies from file