[HDFS-13110] [SPS]: Reduce the number of APIs in NamenodeProtocol used by external satisfier

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: HDFS-10285, 3.2.0
• Assignee: Rakesh Radhakrishnan
• Reporter: Rakesh Radhakrishnan
• Created: 06/Feb/18 10:57
• Updated: 13/Aug/18 05:40
• Resolved: 16/Feb/18 11:41

Description

This task is to address the following daryn's comments. Please refer HDFS-10285 to see more detailed discussion.

Comment-10)

NamenodeProtocolTranslatorPB

Most of the api changes appear unnecessary.

IntraSPSNameNodeContext#getFileInfo swallows all IOEs, based on assumption that any and all IOEs means FNF which probably isn’t the intention during rpc exceptions.

 Comment-13)

StoragePolicySatisfier
It appears to make back-to-back calls to hasLowRedundancyBlocks and getFileInfo for every file. Haven’t fully groked the code, but if low redundancy is not the common case, then it shouldn’t be called unless/until needed. It looks like files that are under replicated are re-queued again?