Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1301

TestHDFSProxy need to use server side conf for ProxyUser stuff.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      currently TestHdfsProxy sets hadoop.proxyuser.USER.groups in local copy of configuration.
      But ProxyUsers only looks at the server side config.
      For test we can uses static method in ProxyUsers to load the config.

      1. HDFS-1301.patch
        2 kB
        Boris Shkolnik
      2. HDFS-1301-1.patch
        3 kB
        Boris Shkolnik
      3. HDFS-1301-BP20.patch
        1 kB
        Boris Shkolnik
      4. HDFS-1301-BP20-1.patch
        3 kB
        Boris Shkolnik

        Issue Links

          Activity

          Hide
          Boris Shkolnik added a comment -

          for previous version, not for commit

          Show
          Boris Shkolnik added a comment - for previous version, not for commit
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12449687/HDFS-1301.patch
          against trunk revision 964266.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/216/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/216/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/216/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/216/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449687/HDFS-1301.patch against trunk revision 964266. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/216/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/216/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/216/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/216/console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          +1. This patch along with the patch I'll upload to HDFS-1164 momentarily fixes TestHdfsProxy for me.

          Show
          Todd Lipcon added a comment - +1. This patch along with the patch I'll upload to HDFS-1164 momentarily fixes TestHdfsProxy for me.
          Hide
          Boris Shkolnik added a comment -

          same fix, but different location. I've moved the refresh code to MiniDFSCluster, so it would work for any other stuff in the future.

          Show
          Boris Shkolnik added a comment - same fix, but different location. I've moved the refresh code to MiniDFSCluster, so it would work for any other stuff in the future.
          Hide
          Devaraj Das added a comment -

          +1

          Show
          Devaraj Das added a comment - +1
          Hide
          Boris Shkolnik added a comment -

          committed to trunk.

          Show
          Boris Shkolnik added a comment - committed to trunk.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #370 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #370 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/ )

            People

            • Assignee:
              Boris Shkolnik
              Reporter:
              Boris Shkolnik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development