[HDFS-12881] Output streams closed with IOUtils suppressing write errors

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1.0, 2.10.0, 2.9.1, 3.0.1, 2.8.4, 2.7.6
• Hadoop Flags: Reviewed
• Assignee: Ajay Kumar
• Reporter: Jason Darrell Lowe
• Created: 01/Dec/17 15:52
• Updated: 15/Dec/17 21:04
• Resolved: 15/Dec/17 21:04

Description

There are a few places in HDFS code that are closing an output stream with IOUtils.cleanupWithLogger like this:

  try {
    ...write to outStream...
  } finally {
    IOUtils.cleanupWithLogger(LOG, outStream);
  }

This suppresses any IOException that occurs during the close() method which could lead to partial/corrupted output without throwing a corresponding exception. The code should either use try-with-resources or explicitly close the stream within the try block so the exception thrown during close() is properly propagated as exceptions during write operations are.

Issue Links

• is duplicated by: HDFS-12924 Port HDFS-12881 to branch-2 (Output streams closed with IOUtils suppressing write errors)
• relates to: HDFS-12903 [READ] Fix closing streams in ImageWriter