[HDFS-12832] INode.getFullPathName may throw ArrayIndexOutOfBoundsException lead to NameNode exit

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.7.4, 3.0.0-beta1
• Fix Version/s: 2.8.3, 2.7.5, 3.1.0, 2.10.0, 2.9.1, 3.0.1
• Component/s: namenode
• Target Version/s: 2.8.3, 2.7.5, 3.0.0, 3.1.0, 2.9.1
• Hadoop Flags: Reviewed
• Assignee: Konstantin Shvachko
• Reporter: DENG FEI
• Created: 17/Nov/17 11:43
• Updated: 05/Dec/17 01:05
• Resolved: 29/Nov/17 02:26

Description

INode.java

public String getFullPathName() {
    // Get the full path name of this inode.
    if (isRoot()) {
      return Path.SEPARATOR;
    }
    // compute size of needed bytes for the path
    int idx = 0;
    for (INode inode = this; inode != null; inode = inode.getParent()) {
      // add component + delimiter (if not tail component)
      idx += inode.getLocalNameBytes().length + (inode != this ? 1 : 0);
    }
    byte[] path = new byte[idx];
    for (INode inode = this; inode != null; inode = inode.getParent()) {
      if (inode != this) {
        path[--idx] = Path.SEPARATOR_CHAR;
      }
      byte[] name = inode.getLocalNameBytes();
      idx -= name.length;
      System.arraycopy(name, 0, path, idx, name.length);
    }
    return DFSUtil.bytes2String(path);
  }

We found ArrayIndexOutOfBoundsException at System.arraycopy(name, 0, path, idx, name.length) when ReplicaMonitor work ,and the NameNode will quit.

It seems the two loop is not synchronized, the path's length is changed.

Issue Links

• is broken by: HDFS-10674 Optimize creating a full path from an inode
• is related to: HDFS-12856 BlockReconstructionWork.chooseTargets() violates namesystem locking