[HDFS-12808] Add LOG.isDebugEnabled() guard for LOG.debug("...")

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.1.0
• Hadoop Flags: Reviewed
• Assignee: Bharat Viswanadham
• Reporter: Mehran Hassani
• Created: 13/Nov/17 20:54
• Updated: 09/Jan/18 18:08
• Resolved: 09/Jan/18 01:51

Description

I am conducting research on log related bugs. I tried to make a tool to fix repetitive yet simple patterns of bugs that are related to logs. In this file, there is a debug level logging statement containing multiple string concatenation without the if statement before them:

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestCachingStrategy.java, LOG.debug("got fadvise(offset=" + offset + ", len=" + len +",flags=" + flags + ")");, 82

Would you be interested in adding the if, to the logging statement?

Issue Links

• is related to: HDFS-12829 Moving logging APIs over to slf4j in hdfs