Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12761 Ozone: Merge Ozone to trunk
  3. HDFS-12758

Ozone: Correcting assertEquals argument order in test cases

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • None
    • ozone

    Description

      In few test cases, the arguments to Assert.assertEquals is swapped. Below is the list of classes and test-cases where this has to be corrected.

      hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/ksm/TestKeySpaceManager.java
       testChangeVolumeQuota - line: 187, 197 & 204
      
      hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/web/TestDistributedOzoneVolumes.java
       testCreateVolumes - line: 91
       testCreateVolumesWithQuota - line: 103
       testCreateVolumesWithInvalidQuota - line: 115
       testCreateVolumesWithInvalidUser - line: 129
       testCreateVolumesWithOutAdminRights - line: 144
       testCreateVolumesInLoop - line: 156
      
      hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/web/client/TestKeys.java
       runTestPutKey - line: 239 & 246
       runTestPutAndListKey - line: 428, 429, 451, 452, 458 & 459
      
      hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/transport/server/TestContainerServer.java
       testClientServerWithContainerDispatcher - line: 219
      
      hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/ContainerTestHelper.java
       verifyGetKey - line: 491
      
      hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerPersistence.java
       testUpdateContainer - line: 776, 778, 794, 796, 821 & 823
      
      hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/common/TestEndPoint.java
       testGetVersion - line: 122 & 124
       testRegister - line: 215
      
      hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/replication/TestContainerReplicationManager.java
       testDetectSingleContainerReplica - line: 168
      
      hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/scm/TestXceiverClientManager.java
       testCaching - line: 82, 91, 96 & 97
       testFreeByReference - line: 120, 130 & 137
       testFreeByEviction - line: 165, 170, 177 & 185
      
      hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/ozone/TestOzoneAcls.java
       testAclValues - line: 111, 112, 113, 116, 117, 118, 121, 122, 123, 126, 127, 128, 131, 132, 133, 136, 137 & 138
      
      hadoop-tools/hadoop-ozone/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileInterfaces.java
       testFileSystemInit - line: 102
       testOzFsReadWrite - line: 123
       testDirectory - line: 135, 138 & 139
      

      Attachments

        1. HDFS-12758-HDFS-7240.00.patch
          24 kB
          Bharat Viswanadham

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            bharat Bharat Viswanadham
            nanda Nandakumar
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment