[HDFS-12747] Lease monitor may infinitely loop on the same lease

• Type: Bug
• Status: Open
• Priority: Critical
• Resolution: Unresolved
• Affects Version/s: 2.8.0
• Component/s: namenode
• Target Version/s: 2.8.6
• Assignee: Daryn Sharp
• Reporter: Daryn Sharp
• Created: 30/Oct/17 22:02
• Updated: 15/Apr/19 11:46

Description

Lease recovery incorrectly handles UC files if the last block is complete but the penultimate block is committed. Incorrectly handles is the euphemism for infinitely loops for days and leaves all abandoned streams open until customers complain.

The problem may manifest when:

1. Block1 is committed but seemingly never completed
2. Block2 is allocated
3. Lease recovery is initiated for block2
4. Commit block synchronization invokes FSNamesytem#closeFileCommitBlocks, causing:
   • commitOrCompleteLastBlock to mark block2 as complete
   • finalizeINodeFileUnderConstruction/INodeFile.assertAllBlocksComplete to throw IllegalStateException because the penultimate block1 is "COMMITTED but not COMPLETE"
5. The next lease recovery results in an infinite loop.

The LeaseManager expects that FSNamesystem#internalReleaseLease will either init recovery and renew the lease, or remove the lease. In the described state it does neither. The switch case will break out if the last block is complete. (The case statement ironically contains an assert). Since nothing changed, the lease is still the “next” lease to be processed. The lease monitor loops for 25ms on the same lease, sleeps for 2s, loops on it again.

Issue Links

• is broken by: HDFS-11445 FSCK shows overall health status as corrupt even one replica is corrupt
• is caused by: HDFS-14429 Block remain in COMMITTED but not COMPLETE caused by Decommission
• is related to: HDFS-11499 Decommissioning stuck because of failing recovery