[HDFS-12714] Hadoop 3 missing fix for HDFS-5169

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1, 3.0.0-beta1, 3.0.0-alpha2, 3.0.0-alpha4, 3.0.0-alpha3
• Fix Version/s: 3.0.0, 3.1.0
• Component/s: native
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 25/Oct/17 22:55
• Updated: 13/Nov/17 23:24
• Resolved: 01/Nov/17 06:03

Description

HDFS-5169 is a fix for a null pointer dereference in translateZCRException. This line in hdfs.c:

ret = printExceptionAndFree(env, jthr, PRINT_EXC_ALL, "hadoopZeroCopyRead: ZeroCopyCursor#read failed");
should be:
ret = printExceptionAndFree(env, exc, PRINT_EXC_ALL, "hadoopZeroCopyRead: ZeroCopyCursor#read failed");
Plainly, translateZCRException should print the exception (exc) passed in to the function rather than the uninitialized local jthr.

The fix for HDFS-5169 (part of HDFS-4949) exists on hadoop 2.* branches, but it is missing on hadoop 3 branches including trunk.

Hadoop 2.8:
https://github.com/apache/hadoop/blob/branch-2.8/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c#L2514

Hadoop 3.0:
https://github.com/apache/hadoop/blob/branch-3.0/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c#L2691