Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12472

Add JUNIT timeout to TestBlockStatsMXBean

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Add Junit timeout to TestBlockStatsMXBean so that it can show up in the test failure report if timeout occurs.

      1. HDFS-12472.00.patch
        1 kB
        Bharat Viswanadham
      2. HDFS-12472.01.patch
        1 kB
        Bharat Viswanadham

        Activity

        Hide
        bharatviswa Bharat Viswanadham added a comment -

        Lei (Eddy) Xu Could you help in reviewing the changes.

        Show
        bharatviswa Bharat Viswanadham added a comment - Lei (Eddy) Xu Could you help in reviewing the changes.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Hi Bharat Viswanadham, minor suggestion. We can get rid of getGlobalTimeout. lgtm otherwise.

        Show
        arpitagarwal Arpit Agarwal added a comment - Hi Bharat Viswanadham , minor suggestion. We can get rid of getGlobalTimeout. lgtm otherwise.
        Hide
        bharatviswa Bharat Viswanadham added a comment -

        Hi Arpit Agarwal Thanks for reviewing. Updated the patch to remove getGlobalTimeout.

        Show
        bharatviswa Bharat Viswanadham added a comment - Hi Arpit Agarwal Thanks for reviewing. Updated the patch to remove getGlobalTimeout.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 pending Jenkins.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 pending Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 15m 32s trunk passed
        +1 compile 0m 59s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 findbugs 1m 51s trunk passed
        +1 javadoc 0m 45s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 52s the patch passed
        +1 compile 0m 53s the patch passed
        +1 javac 0m 53s the patch passed
        +1 checkstyle 0m 39s the patch passed
        +1 mvnsite 1m 2s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 5s the patch passed
        +1 javadoc 0m 44s the patch passed
              Other Tests
        -1 unit 114m 48s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        144m 24s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestNamenodeRetryCache
          hadoop.hdfs.server.namenode.TestReencryptionWithKMS
          hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
          hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
          hadoop.hdfs.TestLeaseRecoveryStriped
          hadoop.hdfs.TestAclsEndToEnd
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean
        Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12472
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887432/HDFS-12472.00.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fed6e77ce54e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 90894c7
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21175/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21175/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21175/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 15m 32s trunk passed +1 compile 0m 59s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 2s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 0m 45s trunk passed       Patch Compile Tests +1 mvninstall 0m 52s the patch passed +1 compile 0m 53s the patch passed +1 javac 0m 53s the patch passed +1 checkstyle 0m 39s the patch passed +1 mvnsite 1m 2s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 0m 44s the patch passed       Other Tests -1 unit 114m 48s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 144m 24s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.namenode.TestReencryptionWithKMS   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.TestLeaseRecoveryStriped   hadoop.hdfs.TestAclsEndToEnd   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12472 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887432/HDFS-12472.00.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fed6e77ce54e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 90894c7 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/21175/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21175/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21175/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 15m 16s trunk passed
        +1 compile 1m 0s trunk passed
        +1 checkstyle 0m 41s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 findbugs 1m 56s trunk passed
        +1 javadoc 0m 44s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 59s the patch passed
        +1 compile 0m 54s the patch passed
        +1 javac 0m 54s the patch passed
        +1 checkstyle 0m 37s the patch passed
        +1 mvnsite 1m 3s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 6s the patch passed
        +1 javadoc 0m 43s the patch passed
              Other Tests
        -1 unit 94m 46s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        123m 51s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.server.namenode.TestNamenodeRetryCache
          hadoop.hdfs.server.namenode.TestReencryptionWithKMS
          hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure020
          hadoop.hdfs.TestLeaseRecoveryStriped
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
        Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12472
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887435/HDFS-12472.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 18ede19b9076 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 90894c7
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21176/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21176/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21176/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 15m 16s trunk passed +1 compile 1m 0s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 3s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 0m 44s trunk passed       Patch Compile Tests +1 mvninstall 0m 59s the patch passed +1 compile 0m 54s the patch passed +1 javac 0m 54s the patch passed +1 checkstyle 0m 37s the patch passed +1 mvnsite 1m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 43s the patch passed       Other Tests -1 unit 94m 46s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 123m 51s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.namenode.TestReencryptionWithKMS   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure020   hadoop.hdfs.TestLeaseRecoveryStriped   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12472 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887435/HDFS-12472.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 18ede19b9076 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 90894c7 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/21176/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21176/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21176/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        I've committed this. Thanks Bharat Viswanadham.

        Show
        arpitagarwal Arpit Agarwal added a comment - I've committed this. Thanks Bharat Viswanadham .
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks for the patch and reviews, Bharat Viswanadham and Arpit Agarwal!

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks for the patch and reviews, Bharat Viswanadham and Arpit Agarwal !
        Hide
        bharatviswa Bharat Viswanadham added a comment -

        Thank You Arpit Agarwal for committing the patch.

        Show
        bharatviswa Bharat Viswanadham added a comment - Thank You Arpit Agarwal for committing the patch.

          People

          • Assignee:
            bharatviswa Bharat Viswanadham
            Reporter:
            eddyxu Lei (Eddy) Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development