[HDFS-12442] WebHdfsFileSystem#getFileBlockLocations will always return BlockLocation#corrupt as false

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Invalid
• Affects Version/s: 2.9.0, 3.0.0-alpha2
• Component/s: webhdfs
• Target Version/s: 2.9.0, 3.0.0, 3.1.0
• Assignee: Rushabh Shah
• Reporter: Rushabh Shah
• Created: 13/Sep/17 20:39
• Updated: 03/Oct/17 18:54
• Resolved: 03/Oct/17 18:54

Description

Was going through JsonUtilClient#toBlockLocation code.
Below is the relevant code snippet.

JsonUtilClient.java

 /** Convert a Json map to BlockLocation. **/
  static BlockLocation toBlockLocation(Map<?, ?> m)
      throws IOException{
    ...
    ...  
    boolean corrupt = Boolean.
        getBoolean(m.get("corrupt").toString());
    ...
    ...
  }

According to java docs for Boolean#getBoolean

Returns true if and only if the system property named by the argument exists and is equal to the string "true". 

I assume, the map value for key corrupt will be populated with either true or false.
On the client side, Boolean#getBoolean will look for system property for true or false.
So it will always return false unless the system property is set for true or false.

Issue Links

• is broken by: HDFS-11156 Add new op GETFILEBLOCKLOCATIONS to WebHDFS REST API