Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12318

Fix IOException condition for openInfo in DFSInputStream

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-beta1
    • Fix Version/s: 3.0.0-beta1
    • Component/s: None
    • Labels:
      None

      Description

      when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, "openInfo" successfully obtains the last blcok locations, and the function still throws IOException.

      1. HDFS-12318.001.patch
        3 kB
        legend
      2. HDFS-12318.002.patch
        4 kB
        John Zhuge
      3. HDFS-12318.003.patch
        3 kB
        legend
      4. HDFS-12318.patch
        0.8 kB
        legend

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 42s trunk passed
        +1 compile 0m 33s trunk passed
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 35s trunk passed
        +1 findbugs 1m 23s trunk passed
        +1 javadoc 0m 20s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 30s the patch passed
        +1 javac 0m 30s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 31s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 29s the patch passed
        +1 javadoc 0m 19s the patch passed
              Other Tests
        +1 unit 1m 11s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 14s The patch does not generate ASF License warnings.
        23m 18s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12318
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882545/HDFS-12318.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2e90cf91265d 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 99e558b
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20754/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20754/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 42s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 35s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 20s trunk passed       Patch Compile Tests +1 mvninstall 0m 32s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 19s the patch passed       Other Tests +1 unit 1m 11s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 23m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12318 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882545/HDFS-12318.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2e90cf91265d 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99e558b Default Java 1.8.0_144 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20754/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20754/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        vagarychen Chen Liang added a comment -

        Seems this is a fairly tricky corner case, the check becomes problematic only when either exactly the last retry succeeds, or retriesForLastBlockLength is configured to be 0. So thanks legend for the nice catch! The patch LGTM.

        Show
        vagarychen Chen Liang added a comment - Seems this is a fairly tricky corner case, the check becomes problematic only when either exactly the last retry succeeds, or retriesForLastBlockLength is configured to be 0. So thanks legend for the nice catch! The patch LGTM.
        Hide
        legend-hua legend added a comment -

        Thanks to Chen Liang for review

        Show
        legend-hua legend added a comment - Thanks to Chen Liang for review
        Hide
        legend-hua legend added a comment -

        hi John Zhuge, Yongjun Zhang
        I think the patch is useful to fix the issue.

        Show
        legend-hua legend added a comment - hi John Zhuge , Yongjun Zhang I think the patch is useful to fix the issue.
        Hide
        jzhuge John Zhuge added a comment -

        legend Great catch and thanks for the patch. I will take a look.

        BTW, could you add a unit test? I know unit test is tougher to write than the fix itself, but it will make sure nobody will break your fix in the future.

        Show
        jzhuge John Zhuge added a comment - legend Great catch and thanks for the patch. I will take a look. BTW, could you add a unit test? I know unit test is tougher to write than the fix itself, but it will make sure nobody will break your fix in the future.
        Hide
        legend-hua legend added a comment -

        Thanks John Zhuge for the advice. I will add unit test for the patch.

        Show
        legend-hua legend added a comment - Thanks John Zhuge for the advice. I will add unit test for the patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 7s Maven dependency ordering for branch
        +1 mvninstall 13m 44s trunk passed
        +1 compile 1m 27s trunk passed
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 1m 28s trunk passed
        +1 findbugs 3m 2s trunk passed
        +1 javadoc 1m 2s trunk passed
              Patch Compile Tests
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 20s the patch passed
        +1 compile 1m 27s the patch passed
        +1 javac 1m 27s the patch passed
        +1 checkstyle 0m 40s the patch passed
        +1 mvnsite 1m 25s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 14s the patch passed
        +1 javadoc 0m 57s the patch passed
              Other Tests
        +1 unit 1m 14s hadoop-hdfs-client in the patch passed.
        +1 unit 63m 51s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        97m 38s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12318
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882873/HDFS-12318.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4a637aae55f2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 267e19a
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20782/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20782/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 13m 44s trunk passed +1 compile 1m 27s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 28s trunk passed +1 findbugs 3m 2s trunk passed +1 javadoc 1m 2s trunk passed       Patch Compile Tests 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 20s the patch passed +1 compile 1m 27s the patch passed +1 javac 1m 27s the patch passed +1 checkstyle 0m 40s the patch passed +1 mvnsite 1m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 14s the patch passed +1 javadoc 0m 57s the patch passed       Other Tests +1 unit 1m 14s hadoop-hdfs-client in the patch passed. +1 unit 63m 51s hadoop-hdfs in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 97m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12318 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882873/HDFS-12318.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4a637aae55f2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 267e19a Default Java 1.8.0_144 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20782/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20782/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Thanks for the unit test!

        +1 LGTM with minor comments:

        • Rename unit test from testopenInfo to testOpenInfo, upper case "O"
        • Wait for the minicluster to become active by calling cluster.waitActive()
        • Make sure the cluster is always shut down upon exception
        • Make sure input stream fin is always closed upon exception, using try-with-resource

        Since these changes are simple, I took the liberty to upload patch 002 with the changes, hope you don't mind.

        Show
        jzhuge John Zhuge added a comment - Thanks for the unit test! +1 LGTM with minor comments: Rename unit test from testopenInfo to testOpenInfo , upper case "O" Wait for the minicluster to become active by calling cluster.waitActive() Make sure the cluster is always shut down upon exception Make sure input stream fin is always closed upon exception, using try-with-resource Since these changes are simple, I took the liberty to upload patch 002 with the changes, hope you don't mind.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 33s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 24s Maven dependency ordering for branch
        +1 mvninstall 12m 55s trunk passed
        +1 compile 1m 24s trunk passed
        +1 checkstyle 0m 36s trunk passed
        +1 mvnsite 1m 22s trunk passed
        +1 findbugs 2m 46s trunk passed
        +1 javadoc 0m 54s trunk passed
              Patch Compile Tests
        0 mvndep 0m 6s Maven dependency ordering for patch
        +1 mvninstall 1m 12s the patch passed
        +1 compile 1m 16s the patch passed
        +1 javac 1m 16s the patch passed
        +1 checkstyle 0m 33s the patch passed
        +1 mvnsite 1m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 6s the patch passed
        +1 javadoc 0m 51s the patch passed
              Other Tests
        +1 unit 1m 19s hadoop-hdfs-client in the patch passed.
        -1 unit 64m 56s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        97m 9s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.web.TestWebHdfsTimeouts
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12318
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882902/HDFS-12318.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f57a584781ff 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 267e19a
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20787/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20787/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20787/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 33s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 24s Maven dependency ordering for branch +1 mvninstall 12m 55s trunk passed +1 compile 1m 24s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 22s trunk passed +1 findbugs 2m 46s trunk passed +1 javadoc 0m 54s trunk passed       Patch Compile Tests 0 mvndep 0m 6s Maven dependency ordering for patch +1 mvninstall 1m 12s the patch passed +1 compile 1m 16s the patch passed +1 javac 1m 16s the patch passed +1 checkstyle 0m 33s the patch passed +1 mvnsite 1m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 6s the patch passed +1 javadoc 0m 51s the patch passed       Other Tests +1 unit 1m 19s hadoop-hdfs-client in the patch passed. -1 unit 64m 56s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 97m 9s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12318 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882902/HDFS-12318.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f57a584781ff 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 267e19a Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/20787/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20787/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20787/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        legend-hua legend added a comment -

        Thanks John Zhuge for review and update.
        The failed tests seemed to be caused by CI environment.
        UT TestDFSInputStream passed.

        Show
        legend-hua legend added a comment - Thanks John Zhuge for review and update. The failed tests seemed to be caused by CI environment. UT TestDFSInputStream passed.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 24s Maven dependency ordering for branch
        +1 mvninstall 13m 34s trunk passed
        +1 compile 1m 24s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 1m 24s trunk passed
        +1 findbugs 2m 58s trunk passed
        +1 javadoc 1m 0s trunk passed
              Patch Compile Tests
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 15s the patch passed
        +1 compile 1m 21s the patch passed
        +1 javac 1m 21s the patch passed
        +1 checkstyle 0m 37s the patch passed
        +1 mvnsite 1m 20s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 9s the patch passed
        +1 javadoc 0m 54s the patch passed
              Other Tests
        +1 unit 1m 13s hadoop-hdfs-client in the patch passed.
        -1 unit 74m 52s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        108m 6s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestMaintenanceState
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.server.namenode.TestReconstructStripedBlocks
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.web.TestWebHdfsTimeouts
        Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12318
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883475/HDFS-12318.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 601399de3aa5 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 652dd43
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20835/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20835/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20835/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 24s Maven dependency ordering for branch +1 mvninstall 13m 34s trunk passed +1 compile 1m 24s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 24s trunk passed +1 findbugs 2m 58s trunk passed +1 javadoc 1m 0s trunk passed       Patch Compile Tests 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 15s the patch passed +1 compile 1m 21s the patch passed +1 javac 1m 21s the patch passed +1 checkstyle 0m 37s the patch passed +1 mvnsite 1m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 9s the patch passed +1 javadoc 0m 54s the patch passed       Other Tests +1 unit 1m 13s hadoop-hdfs-client in the patch passed. -1 unit 74m 52s hadoop-hdfs in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 108m 6s Reason Tests Failed junit tests hadoop.hdfs.TestMaintenanceState   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.namenode.TestReconstructStripedBlocks   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.web.TestWebHdfsTimeouts Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12318 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883475/HDFS-12318.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 601399de3aa5 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 652dd43 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/20835/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20835/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20835/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        legend-hua legend added a comment -

        hi John Zhuge
        Update patch address your comments, and add a try-with-resource.

        • FSDataOutputStream fout is closed upon exception, using try-with-resource.

        The failed tests are not related to the patch.

        Show
        legend-hua legend added a comment - hi John Zhuge Update patch address your comments, and add a try-with-resource. FSDataOutputStream fout is closed upon exception, using try-with-resource. The failed tests are not related to the patch.
        Hide
        jzhuge John Zhuge added a comment -

        Committed to trunk.

        Thanks legend for the contribution and Chen Liang for the review!

        Show
        jzhuge John Zhuge added a comment - Committed to trunk. Thanks legend for the contribution and Chen Liang for the review!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12235 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12235/)
        HDFS-12318. Fix IOException condition for openInfo in DFSInputStream. (jzhuge: rev 3123895db0518552eb357093fddf0e8ff1a6cadf)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12235 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12235/ ) HDFS-12318 . Fix IOException condition for openInfo in DFSInputStream. (jzhuge: rev 3123895db0518552eb357093fddf0e8ff1a6cadf) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Hide
        legend-hua legend added a comment -

        Thanks John Zhuge for review

        Show
        legend-hua legend added a comment - Thanks John Zhuge for review

          People

          • Assignee:
            legend-hua legend
            Reporter:
            legend-hua legend
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development