[HDFS-12315] Use Path instead of String in the TestHdfsAdmin.verifyOpenFiles()

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Assignee: Oleg Danilov
• Reporter: Oleg Danilov
• Created: 17/Aug/17 05:28
• Updated: 18/Jun/19 06:23
• Resolved: 18/Jun/19 06:08

Description

closedFiles is a set of Path, therefor closedFiles.contains(String) doesn't make sense.

lines 252-261:

  private void verifyOpenFiles(HashSet<Path> closedFiles,
      HashMap<Path, FSDataOutputStream> openFileMap) throws IOException {
    HdfsAdmin hdfsAdmin = new HdfsAdmin(FileSystem.getDefaultUri(conf), conf);
    HashSet<Path> openFiles = new HashSet<>(openFileMap.keySet());
    RemoteIterator<OpenFileEntry> openFilesRemoteItr =
        hdfsAdmin.listOpenFiles();
    while (openFilesRemoteItr.hasNext()) {
      String filePath = openFilesRemoteItr.next().getFilePath();
      assertFalse(filePath + " should not be listed under open files!",
          closedFiles.contains(filePath));

Issue Links

• links to: GitHub Pull Request #266
• links to: GitHub Pull Request #266