[HDFS-12304] Remove unused parameter from FsDatasetImpl#addVolume

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-beta1, 3.1.0
• Hadoop Flags: Reviewed
• Assignee: Chen Liang
• Reporter: Chen Liang
• Created: 15/Aug/17 18:10
• Updated: 25/Sep/17 16:42
• Resolved: 25/Sep/17 16:27

Description

FsDatasetImpl has this method

  private void addVolume(Collection<StorageLocation> dataLocations,
      Storage.StorageDirectory sd) throws IOException

Parameter dataLocations was introduced in HDFS-6740, this variable was used to get storage type info. But HDFS-10637 has changed the way of getting storage type in this method, making dataLocations no longer being used at all here. We should probably remove dataLocations for a cleaner interface.