Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12304

Remove unused parameter from FsDatasetImpl#addVolume

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.0.0-beta1, 3.1.0
    • None
    • None
    • Reviewed

    Description

      FsDatasetImpl has this method

        private void addVolume(Collection<StorageLocation> dataLocations,
            Storage.StorageDirectory sd) throws IOException
      

      Parameter dataLocations was introduced in HDFS-6740, this variable was used to get storage type info. But HDFS-10637 has changed the way of getting storage type in this method, making dataLocations no longer being used at all here. We should probably remove dataLocations for a cleaner interface.

      Attachments

        1. HDFS-12304.001.patch
          1 kB
          Chen Liang

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            vagarychen Chen Liang
            vagarychen Chen Liang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment