Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12304

Remove unused parameter from FsDatasetImpl#addVolume

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1, 3.1.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FsDatasetImpl has this method

        private void addVolume(Collection<StorageLocation> dataLocations,
            Storage.StorageDirectory sd) throws IOException
      

      Parameter dataLocations was introduced in HDFS-6740, this variable was used to get storage type info. But HDFS-10637 has changed the way of getting storage type in this method, making dataLocations no longer being used at all here. We should probably remove dataLocations for a cleaner interface.

        Attachments

          Activity

            People

            • Assignee:
              vagarychen Chen Liang
              Reporter:
              vagarychen Chen Liang
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: