Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12258

ec -listPolicies should list all policies in system, no matter it's enabled or disabled

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1
    • Component/s: None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Hide
      <!-- markdown -->

      `hdfs ec -listPolicies` now lists enabled, disabled, and removed policies, rather than just enabled policies.
      Show
      <!-- markdown --> `hdfs ec -listPolicies` now lists enabled, disabled, and removed policies, rather than just enabled policies.

      Description

      ec -listPolicies should list all policies in system, no matter it's enabled or disabled

      1. HDFS-12258.01.patch
        38 kB
        Wei Zhou
      2. HDFS-12258.02.patch
        44 kB
        Wei Zhou
      3. HDFS-12258.03.patch
        45 kB
        Wei Zhou
      4. HDFS-12258.04.patch
        46 kB
        Wei Zhou
      5. HDFS-12258.05.patch
        46 kB
        Wei Zhou
      6. HDFS-12258.06.patch
        46 kB
        Wei Zhou
      7. HDFS-12258.07.patch
        47 kB
        Wei Zhou
      8. HDFS-12258-07.patch
        47 kB
        Rakesh R

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12272 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12272/)
          HDFS-12258. ec -listPolicies should list all policies in system, no (rakeshr: rev 200b11368d3954138a9bce128c8fa763b4a503a1)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/ECAdmin.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStripedINodeFile.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testErasureCodingConf.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsAdmin.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSErasureCoding.md
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ErasureCodingPolicy.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirErasureCodingOp.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/hdfs.proto
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedOutputStream.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicies.java
          • (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ErasureCodingPolicyState.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12272 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12272/ ) HDFS-12258 . ec -listPolicies should list all policies in system, no (rakeshr: rev 200b11368d3954138a9bce128c8fa763b4a503a1) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/ECAdmin.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStripedINodeFile.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testErasureCodingConf.xml (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsAdmin.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSErasureCoding.md (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ErasureCodingPolicy.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirErasureCodingOp.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/hdfs.proto (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedOutputStream.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicies.java (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ErasureCodingPolicyState.java
          Hide
          rakeshr Rakesh R added a comment -

          Committed to trunk!

          Corrected one minor typo in docs a/hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSErasureCoding.md, am attaching the committed patch to jira.

          Lists all (enabled, disabled and removed) the erasure coding policies
          

          to

          Lists all (enabled, disabled and removed) erasure coding policies
          
          Show
          rakeshr Rakesh R added a comment - Committed to trunk! Corrected one minor typo in docs a/hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSErasureCoding.md , am attaching the committed patch to jira. Lists all (enabled, disabled and removed) the erasure coding policies to Lists all (enabled, disabled and removed) erasure coding policies
          Hide
          rakeshr Rakesh R added a comment - - edited

          Thanks Wei Zhou for the contribution. +1 LGTM

          Test case failures are unrelated to the patch.

          Show
          rakeshr Rakesh R added a comment - - edited Thanks Wei Zhou for the contribution. +1 LGTM Test case failures are unrelated to the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 46s Maven dependency ordering for branch
          +1 mvninstall 13m 23s trunk passed
          +1 compile 1m 22s trunk passed
          +1 checkstyle 0m 36s trunk passed
          +1 mvnsite 1m 18s trunk passed
          +1 findbugs 2m 44s trunk passed
          +1 javadoc 1m 3s trunk passed
                Patch Compile Tests
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 13s the patch passed
          +1 compile 1m 14s the patch passed
          +1 cc 1m 14s the patch passed
          +1 javac 1m 14s the patch passed
          +1 checkstyle 0m 35s the patch passed
          +1 mvnsite 1m 19s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 3m 0s the patch passed
          +1 javadoc 0m 56s the patch passed
                Other Tests
          +1 unit 1m 13s hadoop-hdfs-client in the patch passed.
          -1 unit 83m 15s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 14s The patch does not generate ASF License warnings.
          117m 17s



          Reason Tests
          Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestWriteReadStripedFile
            hadoop.hdfs.TestErasureCodingPolicies
            hadoop.hdfs.TestLeaseRecoveryStriped
            hadoop.hdfs.TestClientProtocolForPipelineRecovery



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884391/HDFS-12258.07.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 02fc53188194 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8201ed8
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20917/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20917/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20917/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 1m 46s Maven dependency ordering for branch +1 mvninstall 13m 23s trunk passed +1 compile 1m 22s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 18s trunk passed +1 findbugs 2m 44s trunk passed +1 javadoc 1m 3s trunk passed       Patch Compile Tests 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 13s the patch passed +1 compile 1m 14s the patch passed +1 cc 1m 14s the patch passed +1 javac 1m 14s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 1m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 3m 0s the patch passed +1 javadoc 0m 56s the patch passed       Other Tests +1 unit 1m 13s hadoop-hdfs-client in the patch passed. -1 unit 83m 15s hadoop-hdfs in the patch failed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 117m 17s Reason Tests Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestWriteReadStripedFile   hadoop.hdfs.TestErasureCodingPolicies   hadoop.hdfs.TestLeaseRecoveryStriped   hadoop.hdfs.TestClientProtocolForPipelineRecovery Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884391/HDFS-12258.07.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 02fc53188194 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8201ed8 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/20917/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20917/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20917/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhouwei Wei Zhou added a comment -

          Thanks Rakesh R for reviewing, doc updated based on the comments, thanks!

          Show
          zhouwei Wei Zhou added a comment - Thanks Rakesh R for reviewing, doc updated based on the comments, thanks!
          Hide
          rakeshr Rakesh R added a comment -

          Thanks Wei Zhou for the good work!

          Just realized that documentation about -listPolicies has to be updated with the new behavior "Lists all(enabled, disabled and removed) erasure coding policies. Only enabled policy names are suitable for use with the setPolicy command". Sorry for not identifying this point much earlier, I will commit the patch once this is addressed.

          [-listPolicies]
          
          Lists the set of enabled erasure coding policies. These names are suitable for use with the setPolicy command.
          
          Show
          rakeshr Rakesh R added a comment - Thanks Wei Zhou for the good work! Just realized that documentation about -listPolicies has to be updated with the new behavior "Lists all(enabled, disabled and removed) erasure coding policies. Only enabled policy names are suitable for use with the setPolicy command" . Sorry for not identifying this point much earlier, I will commit the patch once this is addressed. [-listPolicies] Lists the set of enabled erasure coding policies. These names are suitable for use with the setPolicy command.
          Hide
          zhouwei Wei Zhou added a comment -

          Thanks Rakesh R for reviewing the patch! The test failures are not related to the patch and passed in my local environment. HDFS-11882 will handle some of these failures, thanks!

          Show
          zhouwei Wei Zhou added a comment - Thanks Rakesh R for reviewing the patch! The test failures are not related to the patch and passed in my local environment. HDFS-11882 will handle some of these failures, thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 32s Maven dependency ordering for branch
          +1 mvninstall 16m 43s trunk passed
          +1 compile 1m 46s trunk passed
          +1 checkstyle 0m 49s trunk passed
          +1 mvnsite 1m 46s trunk passed
          +1 findbugs 3m 43s trunk passed
          +1 javadoc 1m 7s trunk passed
                Patch Compile Tests
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 40s the patch passed
          +1 compile 1m 42s the patch passed
          +1 cc 1m 41s the patch passed
          +1 javac 1m 41s the patch passed
          +1 checkstyle 0m 45s the patch passed
          +1 mvnsite 1m 39s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 45s the patch passed
          +1 javadoc 1m 1s the patch passed
                Other Tests
          +1 unit 1m 19s hadoop-hdfs-client in the patch passed.
          -1 unit 97m 48s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          138m 34s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.TestClientProtocolForPipelineRecovery
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130
            hadoop.hdfs.TestFileAppendRestart
            hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure050
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure210
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090
            hadoop.hdfs.TestLeaseRecoveryStriped
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestFileCreation
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.TestReconstructStripedFile
          Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile
            org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884017/HDFS-12258.06.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 8e5111c89b43 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 02599bd
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20897/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20897/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20897/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 32s Maven dependency ordering for branch +1 mvninstall 16m 43s trunk passed +1 compile 1m 46s trunk passed +1 checkstyle 0m 49s trunk passed +1 mvnsite 1m 46s trunk passed +1 findbugs 3m 43s trunk passed +1 javadoc 1m 7s trunk passed       Patch Compile Tests 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 40s the patch passed +1 compile 1m 42s the patch passed +1 cc 1m 41s the patch passed +1 javac 1m 41s the patch passed +1 checkstyle 0m 45s the patch passed +1 mvnsite 1m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 45s the patch passed +1 javadoc 1m 1s the patch passed       Other Tests +1 unit 1m 19s hadoop-hdfs-client in the patch passed. -1 unit 97m 48s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 138m 34s Reason Tests Failed junit tests hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.TestClientProtocolForPipelineRecovery   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130   hadoop.hdfs.TestFileAppendRestart   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure050   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure210   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090   hadoop.hdfs.TestLeaseRecoveryStriped   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestFileCreation   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.TestReconstructStripedFile Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile   org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884017/HDFS-12258.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 8e5111c89b43 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 02599bd Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/20897/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20897/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20897/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhouwei Wei Zhou added a comment -

          Fix checkstyle issue, the test failures are not related to this patch. Thanks!

          Show
          zhouwei Wei Zhou added a comment - Fix checkstyle issue, the test failures are not related to this patch. Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 16m 0s trunk passed
          +1 compile 1m 52s trunk passed
          +1 checkstyle 0m 51s trunk passed
          +1 mvnsite 1m 57s trunk passed
          +1 findbugs 3m 37s trunk passed
          +1 javadoc 1m 6s trunk passed
                Patch Compile Tests
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 21s the patch passed
          +1 compile 1m 24s the patch passed
          +1 cc 1m 24s the patch passed
          +1 javac 1m 24s the patch passed
          -0 checkstyle 0m 39s hadoop-hdfs-project: The patch generated 1 new + 141 unchanged - 0 fixed = 142 total (was 141)
          +1 mvnsite 1m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 3m 14s the patch passed
          +1 javadoc 0m 58s the patch passed
                Other Tests
          +1 unit 1m 10s hadoop-hdfs-client in the patch passed.
          -1 unit 100m 8s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          137m 59s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure060
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            hadoop.hdfs.TestFileAppendRestart
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200
            hadoop.cli.TestCryptoAdminCLI
            hadoop.hdfs.TestLeaseRecoveryStriped
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883994/HDFS-12258.05.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 8405f7bad769 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ae7abad
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20888/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20888/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20888/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 16m 0s trunk passed +1 compile 1m 52s trunk passed +1 checkstyle 0m 51s trunk passed +1 mvnsite 1m 57s trunk passed +1 findbugs 3m 37s trunk passed +1 javadoc 1m 6s trunk passed       Patch Compile Tests 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 21s the patch passed +1 compile 1m 24s the patch passed +1 cc 1m 24s the patch passed +1 javac 1m 24s the patch passed -0 checkstyle 0m 39s hadoop-hdfs-project: The patch generated 1 new + 141 unchanged - 0 fixed = 142 total (was 141) +1 mvnsite 1m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 3m 14s the patch passed +1 javadoc 0m 58s the patch passed       Other Tests +1 unit 1m 10s hadoop-hdfs-client in the patch passed. -1 unit 100m 8s hadoop-hdfs in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 137m 59s Reason Tests Failed junit tests hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure060   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.TestFileAppendRestart   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200   hadoop.cli.TestCryptoAdminCLI   hadoop.hdfs.TestLeaseRecoveryStriped   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883994/HDFS-12258.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 8405f7bad769 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ae7abad Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20888/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20888/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20888/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhouwei Wei Zhou added a comment -

          Thanks Rakesh R for reviewing, patch updated according to comments, thanks!

          Show
          zhouwei Wei Zhou added a comment - Thanks Rakesh R for reviewing, patch updated according to comments, thanks!
          Hide
          rakeshr Rakesh R added a comment -

          Thanks Wei Zhou for the updates. Please take care below comments,

          1. Update javadoc for below apis as well.
            HdfsAdmin#addErasureCodingPolicies()
            DistributedFileSystem#addErasureCodingPolicies()
            
          2. Please fix checkstyle warnings.
          Show
          rakeshr Rakesh R added a comment - Thanks Wei Zhou for the updates. Please take care below comments, Update javadoc for below apis as well. HdfsAdmin#addErasureCodingPolicies() DistributedFileSystem#addErasureCodingPolicies() Please fix checkstyle warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 13m 53s trunk passed
          +1 compile 1m 25s trunk passed
          +1 checkstyle 0m 43s trunk passed
          +1 mvnsite 1m 28s trunk passed
          +1 findbugs 3m 5s trunk passed
          +1 javadoc 1m 3s trunk passed
                Patch Compile Tests
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 20s the patch passed
          +1 compile 1m 24s the patch passed
          +1 cc 1m 24s the patch passed
          +1 javac 1m 24s the patch passed
          -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 11 new + 151 unchanged - 0 fixed = 162 total (was 151)
          +1 mvnsite 1m 24s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 13s the patch passed
          +1 javadoc 0m 57s the patch passed
                Other Tests
          +1 unit 1m 13s hadoop-hdfs-client in the patch passed.
          -1 unit 65m 1s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          99m 4s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882513/HDFS-12258.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 84ca37baa6ec 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 99e558b
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20751/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20751/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20751/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20751/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 13m 53s trunk passed +1 compile 1m 25s trunk passed +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 28s trunk passed +1 findbugs 3m 5s trunk passed +1 javadoc 1m 3s trunk passed       Patch Compile Tests 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 20s the patch passed +1 compile 1m 24s the patch passed +1 cc 1m 24s the patch passed +1 javac 1m 24s the patch passed -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 11 new + 151 unchanged - 0 fixed = 162 total (was 151) +1 mvnsite 1m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 13s the patch passed +1 javadoc 0m 57s the patch passed       Other Tests +1 unit 1m 13s hadoop-hdfs-client in the patch passed. -1 unit 65m 1s hadoop-hdfs in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 99m 4s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882513/HDFS-12258.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 84ca37baa6ec 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99e558b Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20751/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20751/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20751/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20751/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhouwei Wei Zhou added a comment -

          Thanks Rakesh R for review the patch and suggestion! Patch rebased with doc updated, thanks!

          Show
          zhouwei Wei Zhou added a comment - Thanks Rakesh R for review the patch and suggestion! Patch rebased with doc updated, thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 28s Maven dependency ordering for branch
          +1 mvninstall 16m 22s trunk passed
          +1 compile 18m 56s trunk passed
          +1 checkstyle 2m 17s trunk passed
          +1 mvnsite 3m 35s trunk passed
          +1 findbugs 5m 15s trunk passed
          +1 javadoc 2m 26s trunk passed
                Patch Compile Tests
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 2m 34s the patch passed
          +1 compile 15m 21s the patch passed
          +1 cc 15m 21s the patch passed
          +1 javac 15m 21s the patch passed
          +1 checkstyle 2m 18s the patch passed
          +1 mvnsite 3m 47s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 findbugs 5m 56s the patch passed
          +1 javadoc 2m 27s the patch passed
                Other Tests
          -1 unit 9m 40s hadoop-common in the patch failed.
          +1 unit 1m 34s hadoop-hdfs-client in the patch passed.
          -1 unit 93m 17s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          190m 13s



          Reason Tests
          Failed junit tests hadoop.net.TestClusterTopology
            hadoop.net.TestDNS
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882086/HDFS-12258.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux ee8c95369190 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 588c190
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20718/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20718/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20718/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20718/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 1m 28s Maven dependency ordering for branch +1 mvninstall 16m 22s trunk passed +1 compile 18m 56s trunk passed +1 checkstyle 2m 17s trunk passed +1 mvnsite 3m 35s trunk passed +1 findbugs 5m 15s trunk passed +1 javadoc 2m 26s trunk passed       Patch Compile Tests 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 2m 34s the patch passed +1 compile 15m 21s the patch passed +1 cc 15m 21s the patch passed +1 javac 15m 21s the patch passed +1 checkstyle 2m 18s the patch passed +1 mvnsite 3m 47s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 findbugs 5m 56s the patch passed +1 javadoc 2m 27s the patch passed       Other Tests -1 unit 9m 40s hadoop-common in the patch failed. +1 unit 1m 34s hadoop-hdfs-client in the patch passed. -1 unit 93m 17s hadoop-hdfs in the patch failed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 190m 13s Reason Tests Failed junit tests hadoop.net.TestClusterTopology   hadoop.net.TestDNS   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestDecommission   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882086/HDFS-12258.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux ee8c95369190 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 588c190 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/20718/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20718/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20718/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20718/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rakeshr Rakesh R added a comment -

          my solution is ignore the user's input policy state and set it to DISABLED

          Apart from ENABLED or DISABLED, REMOVED state doesn't make much sense if user sets. As we know, there was no option to specify state earlier, its good to update api documentation saying that the policy state will set to DISABLED by default and any user set policy will be ignored.

          Show
          rakeshr Rakesh R added a comment - my solution is ignore the user's input policy state and set it to DISABLED Apart from ENABLED or DISABLED , REMOVED state doesn't make much sense if user sets. As we know, there was no option to specify state earlier, its good to update api documentation saying that the policy state will set to DISABLED by default and any user set policy will be ignored.
          Hide
          zhouwei Wei Zhou added a comment -

          Thanks Rakesh R for reviewing and the comments!
          For the 4th issue, my solution is ignore the user's input policy state and set it to DISABLED. What's your opinion here? Thanks!

          Show
          zhouwei Wei Zhou added a comment - Thanks Rakesh R for reviewing and the comments! For the 4th issue, my solution is ignore the user's input policy state and set it to DISABLED . What's your opinion here? Thanks!
          Hide
          rakeshr Rakesh R added a comment -

          Thanks Wei Zhou for the patch. Following are few comments, please take care.

          1. Typo: Diabled -> Disabled
            /**
            * EC policy state.
            */
            enum ErasureCodingPolicyState {
              Diabled = 1;
            
          2. Please use captial letters.
            ErasureCodingPolicyState#Disabled, #Enabled, #Removed ==> ErasureCodingPolicyState#DISABLED, #ENABLED, #REMOVED
          3. Please add annotation to enum state
            @InterfaceAudience.Public
            @InterfaceStability.Evolving
            public enum ErasureCodingPolicyState
            
          4. ErasureCodingPolicyManager#addPolicy(ErasureCodingPolicy policy) function is not considering the state. What if user sets ErasureCodingPolicy#state and invoked dfs#addErasureCodingPolicies() API?
          Show
          rakeshr Rakesh R added a comment - Thanks Wei Zhou for the patch. Following are few comments, please take care. Typo: Diabled -> Disabled /** * EC policy state. */ enum ErasureCodingPolicyState { Diabled = 1; Please use captial letters. ErasureCodingPolicyState#Disabled, #Enabled, #Removed ==> ErasureCodingPolicyState#DISABLED, #ENABLED, #REMOVED Please add annotation to enum state @InterfaceAudience.Public @InterfaceStability.Evolving public enum ErasureCodingPolicyState ErasureCodingPolicyManager#addPolicy(ErasureCodingPolicy policy) function is not considering the state. What if user sets ErasureCodingPolicy#state and invoked dfs#addErasureCodingPolicies() API?
          Hide
          zhouwei Wei Zhou added a comment -

          The findbugs warnings and test failure are not related to this patch, thanks!

          Show
          zhouwei Wei Zhou added a comment - The findbugs warnings and test failure are not related to this patch, thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 47s Maven dependency ordering for branch
          +1 mvninstall 15m 36s trunk passed
          +1 compile 16m 22s trunk passed
          +1 checkstyle 2m 9s trunk passed
          +1 mvnsite 3m 26s trunk passed
          -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 55s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
          +1 javadoc 2m 19s trunk passed
                Patch Compile Tests
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 2m 29s the patch passed
          +1 compile 13m 14s the patch passed
          +1 cc 13m 14s the patch passed
          +1 javac 13m 14s the patch passed
          +1 checkstyle 2m 10s the patch passed
          +1 mvnsite 3m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 5m 51s the patch passed
          +1 javadoc 2m 18s the patch passed
                Other Tests
          +1 unit 8m 48s hadoop-common in the patch passed.
          +1 unit 1m 21s hadoop-hdfs-client in the patch passed.
          -1 unit 69m 40s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          157m 45s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.ha.TestHAAppend



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881680/HDFS-12258.02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 978807018f57 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7769e96
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20680/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20680/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20680/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20680/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20680/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 47s Maven dependency ordering for branch +1 mvninstall 15m 36s trunk passed +1 compile 16m 22s trunk passed +1 checkstyle 2m 9s trunk passed +1 mvnsite 3m 26s trunk passed -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 55s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 2m 19s trunk passed       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 2m 29s the patch passed +1 compile 13m 14s the patch passed +1 cc 13m 14s the patch passed +1 javac 13m 14s the patch passed +1 checkstyle 2m 10s the patch passed +1 mvnsite 3m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 5m 51s the patch passed +1 javadoc 2m 18s the patch passed       Other Tests +1 unit 8m 48s hadoop-common in the patch passed. +1 unit 1m 21s hadoop-hdfs-client in the patch passed. -1 unit 69m 40s hadoop-hdfs in the patch failed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 157m 45s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestHAAppend Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881680/HDFS-12258.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 978807018f57 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7769e96 Default Java 1.8.0_144 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20680/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20680/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20680/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20680/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20680/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhouwei Wei Zhou added a comment -

          Update patch, fix code style and related tests issue reported. Thanks!

          Show
          zhouwei Wei Zhou added a comment - Update patch, fix code style and related tests issue reported. Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 33s Maven dependency ordering for branch
          +1 mvninstall 16m 28s trunk passed
          +1 compile 17m 13s trunk passed
          +1 checkstyle 2m 4s trunk passed
          +1 mvnsite 3m 29s trunk passed
          -1 findbugs 1m 37s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 2m 5s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
          +1 javadoc 2m 14s trunk passed
                Patch Compile Tests
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 2m 29s the patch passed
          +1 compile 12m 39s the patch passed
          +1 cc 12m 39s the patch passed
          +1 javac 12m 39s the patch passed
          -0 checkstyle 2m 15s root: The patch generated 9 new + 123 unchanged - 0 fixed = 132 total (was 123)
          +1 mvnsite 3m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 5m 6s the patch passed
          +1 javadoc 2m 4s the patch passed
                Other Tests
          -1 unit 7m 7s hadoop-common in the patch failed.
          +1 unit 1m 19s hadoop-hdfs-client in the patch passed.
          -1 unit 79m 39s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          166m 46s



          Reason Tests
          Failed junit tests hadoop.conf.TestCommonConfigurationFields
            hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.TestStripedINodeFile
          Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881426/HDFS-12258.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux bbf135b72c98 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f13ca94
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20661/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20661/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20661/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20661/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20661/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20661/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20661/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests 0 mvndep 1m 33s Maven dependency ordering for branch +1 mvninstall 16m 28s trunk passed +1 compile 17m 13s trunk passed +1 checkstyle 2m 4s trunk passed +1 mvnsite 3m 29s trunk passed -1 findbugs 1m 37s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 2m 5s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 2m 14s trunk passed       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 2m 29s the patch passed +1 compile 12m 39s the patch passed +1 cc 12m 39s the patch passed +1 javac 12m 39s the patch passed -0 checkstyle 2m 15s root: The patch generated 9 new + 123 unchanged - 0 fixed = 132 total (was 123) +1 mvnsite 3m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 5m 6s the patch passed +1 javadoc 2m 4s the patch passed       Other Tests -1 unit 7m 7s hadoop-common in the patch failed. +1 unit 1m 19s hadoop-hdfs-client in the patch passed. -1 unit 79m 39s hadoop-hdfs in the patch failed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 166m 46s Reason Tests Failed junit tests hadoop.conf.TestCommonConfigurationFields   hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.TestStripedINodeFile Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881426/HDFS-12258.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux bbf135b72c98 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f13ca94 Default Java 1.8.0_144 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20661/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20661/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20661/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20661/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20661/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20661/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20661/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhouwei Wei Zhou added a comment -

          Initial patch for this issue. An ErasureCodingPolicyState added into ErasureCodingPolicy to denote the state of the policy. Thanks SammiChen for her help!

          Show
          zhouwei Wei Zhou added a comment - Initial patch for this issue. An ErasureCodingPolicyState added into ErasureCodingPolicy to denote the state of the policy. Thanks SammiChen for her help!

            People

            • Assignee:
              zhouwei Wei Zhou
              Reporter:
              Sammi SammiChen
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development