[HDFS-12245] Fix INodeId javadoc

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Component/s: documentation, namenode
• Target Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Adam Antal
• Reporter: Wei-Chiu Chuang
• Created: 02/Aug/17 05:32
• Updated: 02/Oct/19 17:15
• Resolved: 11/Apr/19 01:03

Description

The INodeId javadoc states that id 1 to 1000 is reserved and root inode id start from 1001. That is no longer true after HDFS-4434.

Also, it's a little weird in INodeId

  public static final long LAST_RESERVED_ID = 2 << 14 - 1;
  public static final long ROOT_INODE_ID = LAST_RESERVED_ID + 1;

It seems the intent was for LAST_RESERVED_ID to be (2^14) - 1 = 32767. But due to Java operator precedence, LAST_RESERVED_ID = 2^(14-1) = 16384. Maybe it doesn't matter, not sure.

Issue Links

• is broken by: HDFS-4434 Provide a mapping from INodeId to INode
• is duplicated by: HDFS-13657 INodeId's LAST_RESERVED_ID may not as expected and the comment is misleading