Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12215

DataNode#transferBlock does not create its daemon in the xceiver thread group

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: datanode
    • Labels:
      None

      Description

      As mentioned in HDFS-12044, DataNode#transferBlock daemon is not calculated to xceiver count.

      1. HDFS-12215.00.patch
        0.9 kB
        Lei (Eddy) Xu

        Issue Links

          Activity

          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          The patch simply puts DataTransfer to Daemon as the same in #transferBlock().

          Show
          eddyxu Lei (Eddy) Xu added a comment - The patch simply puts DataTransfer to Daemon as the same in #transferBlock() .
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          Thanks for the fix, Lei (Eddy) Xu.
          The patch LGTM. +1 (non-binding).

          Show
          hanishakoneru Hanisha Koneru added a comment - Thanks for the fix, Lei (Eddy) Xu . The patch LGTM. +1 (non-binding).
          Hide
          andrew.wang Andrew Wang added a comment -

          +1 LGTM pending Jenkins, thanks Eddy!

          Show
          andrew.wang Andrew Wang added a comment - +1 LGTM pending Jenkins, thanks Eddy!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 13m 54s trunk passed
          +1 compile 0m 52s trunk passed
          +1 checkstyle 0m 40s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 findbugs 1m 43s trunk passed
          +1 javadoc 0m 41s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 49s the patch passed
          +1 compile 0m 48s the patch passed
          +1 javac 0m 48s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 0m 53s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 3s the patch passed
          +1 javadoc 0m 44s the patch passed
                Other Tests
          -1 unit 75m 14s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          101m 52s



          Reason Tests
          Failed junit tests hadoop.hdfs.qjournal.server.TestJournalNodeSync
            hadoop.hdfs.TestClientProtocolForPipelineRecovery
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
            hadoop.hdfs.TestMissingBlocksAlert
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12215
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883799/HDFS-12215.00.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0a8cf6786394 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e864f81
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20867/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20867/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20867/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 54s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 0m 55s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 41s trunk passed       Patch Compile Tests +1 mvninstall 0m 49s the patch passed +1 compile 0m 48s the patch passed +1 javac 0m 48s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 0m 53s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 3s the patch passed +1 javadoc 0m 44s the patch passed       Other Tests -1 unit 75m 14s hadoop-hdfs in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 101m 52s Reason Tests Failed junit tests hadoop.hdfs.qjournal.server.TestJournalNodeSync   hadoop.hdfs.TestClientProtocolForPipelineRecovery   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestMissingBlocksAlert   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12215 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883799/HDFS-12215.00.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0a8cf6786394 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e864f81 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/20867/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20867/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20867/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thanks a lot for the reviews, Hanisha Koneru and Andrew Wang

          The test failures are not relevant. Passed locally on my laptop.

          Committed to trunk and branch-2

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thanks a lot for the reviews, Hanisha Koneru and Andrew Wang The test failures are not relevant. Passed locally on my laptop. Committed to trunk and branch-2
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12247 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12247/)
          HDFS-12215. DataNode.transferBlock does not create its daemon in the (lei: rev 36bada3032e438099ada9d865c3945d42c3e7c2a)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12247 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12247/ ) HDFS-12215 . DataNode.transferBlock does not create its daemon in the (lei: rev 36bada3032e438099ada9d865c3945d42c3e7c2a) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java

            People

            • Assignee:
              eddyxu Lei (Eddy) Xu
              Reporter:
              eddyxu Lei (Eddy) Xu
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development