Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 3.0.0-beta1
    • Component/s: httpfs
    • Labels:
      None

      Description

      HDFS-10860 deprecated environment variable HTTPFS_TEMP by mistake. This env var is still useful when the admin uses a custom temp directory for HttpFS.

      1. HDFS-12166.001.patch
        4 kB
        John Zhuge
      2. HDFS-12166.002.patch
        4 kB
        John Zhuge

        Issue Links

          Activity

          Hide
          jzhuge John Zhuge added a comment -

          Patch 001

          • Un-deprecate HTTPFS_TEMP
          • Set system property httpfs.temp.dir
          Show
          jzhuge John Zhuge added a comment - Patch 001 Un-deprecate HTTPFS_TEMP Set system property httpfs.temp.dir
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
                Prechecks
          0 shelldocs 0m 4s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 15m 10s trunk passed
          +1 compile 0m 21s trunk passed
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 2m 25s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 17s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 18s the patch passed
          +1 compile 0m 16s the patch passed
          +1 javac 0m 16s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 1m 6s the patch passed
          +1 shellcheck 0m 2s There were no new shellcheck issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 31s the patch passed
          +1 javadoc 0m 13s the patch passed
                Other Tests
          +1 unit 3m 25s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          26m 51s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12166
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878075/HDFS-12166.001.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 257622b0f532 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c21c260
          Default Java 1.8.0_131
          shellcheck v0.4.6
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20343/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20343/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks 0 shelldocs 0m 4s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 10s trunk passed +1 compile 0m 21s trunk passed +1 checkstyle 0m 15s trunk passed +1 mvnsite 2m 25s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 17s trunk passed       Patch Compile Tests +1 mvninstall 0m 18s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 1m 6s the patch passed +1 shellcheck 0m 2s There were no new shellcheck issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 31s the patch passed +1 javadoc 0m 13s the patch passed       Other Tests +1 unit 3m 25s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 26m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12166 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878075/HDFS-12166.001.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle uname Linux 257622b0f532 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c21c260 Default Java 1.8.0_131 shellcheck v0.4.6 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20343/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20343/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Patch 002

          • Use HTTPFS_HOME if defined
          Show
          jzhuge John Zhuge added a comment - Patch 002 Use HTTPFS_HOME if defined
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
                Prechecks
          0 shelldocs 0m 4s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 13m 17s trunk passed
          +1 compile 0m 21s trunk passed
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 2m 23s trunk passed
          +1 findbugs 0m 28s trunk passed
          +1 javadoc 0m 17s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 18s the patch passed
          +1 compile 0m 17s the patch passed
          +1 javac 0m 17s the patch passed
          +1 checkstyle 0m 12s the patch passed
          +1 mvnsite 1m 9s the patch passed
          +1 shellcheck 0m 0s There were no new shellcheck issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 32s the patch passed
          +1 javadoc 0m 14s the patch passed
                Other Tests
          +1 unit 3m 42s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          25m 35s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12166
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878098/HDFS-12166.002.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle
          uname Linux d685c6618db5 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c21c260
          Default Java 1.8.0_131
          shellcheck v0.4.6
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20345/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20345/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated.       Prechecks 0 shelldocs 0m 4s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 17s trunk passed +1 compile 0m 21s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 2m 23s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 17s trunk passed       Patch Compile Tests +1 mvninstall 0m 18s the patch passed +1 compile 0m 17s the patch passed +1 javac 0m 17s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 1m 9s the patch passed +1 shellcheck 0m 0s There were no new shellcheck issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 14s the patch passed       Other Tests +1 unit 3m 42s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 25m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12166 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878098/HDFS-12166.002.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle uname Linux d685c6618db5 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c21c260 Default Java 1.8.0_131 shellcheck v0.4.6 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20345/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20345/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          +1, thanks John.

          Show
          xiaochen Xiao Chen added a comment - +1, thanks John.
          Hide
          jzhuge John Zhuge added a comment -

          Thanks Xiao. Will commit tomorrow pending no other comment.

          Show
          jzhuge John Zhuge added a comment - Thanks Xiao. Will commit tomorrow pending no other comment.
          Hide
          jzhuge John Zhuge added a comment -

          Committed to trunk.

          Thanks Xiao Chen for the quick review!

          Show
          jzhuge John Zhuge added a comment - Committed to trunk. Thanks Xiao Chen for the quick review!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12042 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12042/)
          HDFS-12166. Do not deprecate HTTPFS_TEMP. Contributed by John Zhuge. (jzhuge: rev 3b48f81411230d1cfa7b0f6ad82f44cb0dc0efa6)

          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/libexec/shellprofile.d/hadoop-httpfs.sh
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServerWebServer.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/conf/httpfs-env.sh
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/site/markdown/ServerSetup.md.vm
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12042 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12042/ ) HDFS-12166 . Do not deprecate HTTPFS_TEMP. Contributed by John Zhuge. (jzhuge: rev 3b48f81411230d1cfa7b0f6ad82f44cb0dc0efa6) (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/libexec/shellprofile.d/hadoop-httpfs.sh (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServerWebServer.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/conf/httpfs-env.sh (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/site/markdown/ServerSetup.md.vm

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              jzhuge John Zhuge
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development