[HDFS-12107] FsDatasetImpl#removeVolumes floods the logs when removing the volume

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha4
• Fix Version/s: 3.0.0-beta1
• Hadoop Flags: Reviewed
• Assignee: Kelvin Chu
• Reporter: Haohui Mai
• Created: 09/Jul/17 23:01
• Updated: 31/Aug/17 23:06
• Resolved: 02/Aug/17 01:42

Description

FsDatasetImpl#removeVolumes() prints all block ids on a volume when removing it, which floods the log of DN.

for (String bpid : volumeMap.getBlockPoolList()) {
            List<ReplicaInfo> blocks = new ArrayList<>();
            for (Iterator<ReplicaInfo> it =
                  volumeMap.replicas(bpid).iterator(); it.hasNext();) {
              ReplicaInfo block = it.next();
              final StorageLocation blockStorageLocation =
                  block.getVolume().getStorageLocation();
              LOG.info("checking for block " + block.getBlockId() +
                  " with storageLocation " + blockStorageLocation);
              if (blockStorageLocation.equals(sdLocation)) {
                blocks.add(block);
                it.remove();
              }
            }

The logging level should be DEBUG or TRACE instead of INFO.