Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12078

Add time unit to the description of property dfs.namenode.stale.datanode.interval in hdfs-default.xml

    Details

    • Hadoop Flags:
      Reviewed

      Description

      The description of property dfs.namenode.stale.datanode.interval in hdfs-default.xml doesn't mention about the time unit, we should add that to avoid confusing users.

      I have reviewed all properties in hdfs-default.xml, this is the only one property causes such confusion, user should be able to easily figure out the appropriate time unit for properties by either

      • Specified by property name, e.g dfs.namenode.full.block.report.lease.length.ms
      • Specified by property value with time unit suffix, e.g dfs.blockreport.initialDelay=0s
      • Explained by description of the property, e.g dfs.namenode.safemode.extension=3000, description: Determines extension of safe mode in milliseconds ...

      change to the property name and value will be an incompatible change, to minimize the impact, propose to simply add the time unit in the description (3rd approach). And this should be only one property needs the fix in hdfs-default.xml.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11964 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11964/)
        HDFS-12078. Add time unit to the description of property (aajisaka: rev 186650d21d482e2f3bc4523ae989ebe76081b0e3)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11964 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11964/ ) HDFS-12078 . Add time unit to the description of property (aajisaka: rev 186650d21d482e2f3bc4523ae989ebe76081b0e3) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        Hide
        cheersyang Weiwei Yang added a comment -

        Thanks a lot Akira Ajisaka .

        Show
        cheersyang Weiwei Yang added a comment - Thanks a lot Akira Ajisaka .
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thank you, Weiwei Yang!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thank you, Weiwei Yang !
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 15m 8s trunk passed
        +1 compile 0m 49s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 49s the patch passed
        +1 javac 0m 49s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 javadoc 0m 37s the patch passed
        -1 unit 65m 8s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        87m 40s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12078
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875438/HDFS-12078.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux b5b4428d0957 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / bf1f599
        Default Java 1.8.0_131
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20141/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20141/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20141/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 15m 8s trunk passed +1 compile 0m 49s trunk passed +1 mvnsite 0m 55s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 49s the patch passed +1 javac 0m 49s the patch passed +1 mvnsite 0m 52s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 0m 37s the patch passed -1 unit 65m 8s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 87m 40s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12078 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875438/HDFS-12078.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux b5b4428d0957 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bf1f599 Default Java 1.8.0_131 unit https://builds.apache.org/job/PreCommit-HDFS-Build/20141/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20141/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20141/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            cheersyang Weiwei Yang
            Reporter:
            cheersyang Weiwei Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development