Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1205

FSDatasetAsyncDiskService should name its threads

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FSDatasetAsyncService creates threads but doesn't name them. The ThreadFactory should name them with the volume they work on as well as a thread index.

      1. hdfs-1205.txt
        2 kB
        Eli Collins
      2. hdfs-1205.txt
        2 kB
        Todd Lipcon
      3. hdfs-1205-0.20.txt
        2 kB
        Todd Lipcon

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #381 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/381/)
        HDFS-1205. FSDatasetAsyncDiskService should name its threads. Contributed by Todd Lipcon.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #381 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/381/ ) HDFS-1205 . FSDatasetAsyncDiskService should name its threads. Contributed by Todd Lipcon.
        Hide
        Eli Collins added a comment -

        I've run the tests and committed this. Thanks Todd.

        Show
        Eli Collins added a comment - I've run the tests and committed this. Thanks Todd.
        Hide
        Eli Collins added a comment -

        Here are test-patch results. The javadoc warning is in trunk and is fixed in HDFS-1369. Per the above there's no new test.

             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no new tests are needed for this patch.
             [exec]                         Also please list what manual steps were performed to verify this patch.
             [exec] 
             [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec] 
             [exec]     +1 system tests framework.  The patch passed system tests framework compile.
        
        Show
        Eli Collins added a comment - Here are test-patch results. The javadoc warning is in trunk and is fixed in HDFS-1369 . Per the above there's no new test. [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile.
        Hide
        Eli Collins added a comment -

        Re-attaching the trunk patch so hudson will pick it up and not the 20 version.

        Show
        Eli Collins added a comment - Re-attaching the trunk patch so hudson will pick it up and not the 20 version.
        Hide
        Eli Collins added a comment -

        +1

        Show
        Eli Collins added a comment - +1
        Hide
        Todd Lipcon added a comment -

        Ran commit-tests locally and passed. No new test case included – existing tests cover the code, and manually verified the names by jstacking the unit tests until I caught one:

        todd@178:~$ jps | grep JUnit | awk '

        {print $1}

        ' | xargs jstack | grep Async
        "Async disk worker #0 for volume /Users/todd/dev/git/hadoop-hdfs/build/test/data/dfs/data/data5/current" daemon prio=5 tid=101a75000 nid=0x134b18000 waiting on condition [134b17000]

        Show
        Todd Lipcon added a comment - Ran commit-tests locally and passed. No new test case included – existing tests cover the code, and manually verified the names by jstacking the unit tests until I caught one: todd@178:~$ jps | grep JUnit | awk ' {print $1} ' | xargs jstack | grep Async "Async disk worker #0 for volume /Users/todd/dev/git/hadoop-hdfs/build/test/data/dfs/data/data5/current" daemon prio=5 tid=101a75000 nid=0x134b18000 waiting on condition [134b17000]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12447006/hdfs-1205-0.20.txt
        against trunk revision 957669.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/406/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447006/hdfs-1205-0.20.txt against trunk revision 957669. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/406/console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Attaching patches for trunk and 0.20

        Show
        Todd Lipcon added a comment - Attaching patches for trunk and 0.20

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development