Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12052

Set SWEBHDFS delegation token kind when ssl is enabled in HttpFS

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.3, 3.0.0-alpha3
    • Fix Version/s: 3.0.0-beta1, 2.10.0
    • Component/s: httpfs, webhdfs
    • Labels:
      None

      Description

      When httpfs runs with httpfs.ssl.enabled it should return SWEBHDFS delegation tokens.

      Currently, httpfs returns WEBHDFS delegation "kind" for tokens regardless of whether ssl is enabled or not. If clients directly connect to renew tokens (for example, hdfs dfs) all works because httpfs doesn't check whether token kind is for swebhdfs or webhdfs. However, this breaks when yarn rm needs to renew the token for the job (for example, when running hadoop distcp). Since DT kind is WEBHDFS, rm tries to establish non-ssl connection to httpfs and fails.

      I've tested a simple patch which I'll upload to this jira, and it fixes this issue (hadoop distcp works).

      1. HDFS-12052.00.patch
        1 kB
        Zoran Dimitrijevic
      2. HDFS-12052.01.patch
        19 kB
        Zoran Dimitrijevic
      3. HDFS-12052.02.patch
        21 kB
        Zoran Dimitrijevic
      4. HDFS-12052.03.patch
        31 kB
        Zoran Dimitrijevic
      5. HDFS-12052.04.patch
        32 kB
        Zoran Dimitrijevic
      6. HDFS-12052.05.patch
        30 kB
        Zoran Dimitrijevic
      7. HDFS-12052.06.patch
        21 kB
        Zoran Dimitrijevic
      8. HDFS-12052.07.patch
        21 kB
        Zoran Dimitrijevic

        Activity

        Hide
        xiaochen Xiao Chen added a comment -

        Committed this to branch-2, after resolving minor conflicts. Ran the test locally before pushing.

        Thanks again

        Show
        xiaochen Xiao Chen added a comment - Committed this to branch-2, after resolving minor conflicts. Ran the test locally before pushing. Thanks again
        Hide
        3opan Zoran Dimitrijevic added a comment -

        Thank you!

        Show
        3opan Zoran Dimitrijevic added a comment - Thank you!
        Hide
        xiaochen Xiao Chen added a comment -

        Aha, thank you for the response. I skimmed through the comments and assumed this wasn't committed to branch-2 because of conflicts. Sorry for the wrong assumption.

        Just tried backporting, and the conflict is pretty minor. I'll just go ahead and cherry-pick this to branch-2 if no objections. Thanks!

        Show
        xiaochen Xiao Chen added a comment - Aha, thank you for the response. I skimmed through the comments and assumed this wasn't committed to branch-2 because of conflicts. Sorry for the wrong assumption. Just tried backporting, and the conflict is pretty minor. I'll just go ahead and cherry-pick this to branch-2 if no objections. Thanks!
        Hide
        3opan Zoran Dimitrijevic added a comment -

        Sure. But I think it was exactly the same fix as for 3+. I did it for
        Altiscale 2.7+ branch. What do you want me to do?

        Show
        3opan Zoran Dimitrijevic added a comment - Sure. But I think it was exactly the same fix as for 3+. I did it for Altiscale 2.7+ branch. What do you want me to do?
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Zoran Dimitrijevic for reporting and fixing this issue! Would you be interested to provide a branch-2 fix as well?

        Show
        xiaochen Xiao Chen added a comment - Thanks Zoran Dimitrijevic for reporting and fixing this issue! Would you be interested to provide a branch-2 fix as well?
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11988 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11988/)
        HDFS-12052. Set SWEBHDFS delegation token kind when ssl is enabled in (jzhuge: rev 12c8fdceaf263425661169cba25402df89d444c1)

        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSAuthenticationFilter.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServerWebServer.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/HttpFSKerberosAuthenticationHandlerForTesting.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11988 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11988/ ) HDFS-12052 . Set SWEBHDFS delegation token kind when ssl is enabled in (jzhuge: rev 12c8fdceaf263425661169cba25402df89d444c1) (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSAuthenticationFilter.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServerWebServer.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/HttpFSKerberosAuthenticationHandlerForTesting.java
        Hide
        jzhuge John Zhuge added a comment -

        Committed to trunk.

        Thanks Zoran Dimitrijevic for the contribution!

        Show
        jzhuge John Zhuge added a comment - Committed to trunk. Thanks Zoran Dimitrijevic for the contribution!
        Hide
        jzhuge John Zhuge added a comment -

        Thanks Zoran Dimitrijevic. Will commit tomorrow morning so that others have a chance to comment or review.

        Show
        jzhuge John Zhuge added a comment - Thanks Zoran Dimitrijevic . Will commit tomorrow morning so that others have a chance to comment or review.
        Hide
        3opan Zoran Dimitrijevic added a comment -

        John Zhuge thanks. Removed unnecessary import and it seems it's finally all good. Please submit the patch when you have time. Cheers.

        Show
        3opan Zoran Dimitrijevic added a comment - John Zhuge thanks. Removed unnecessary import and it seems it's finally all good. Please submit the patch when you have time. Cheers.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 13m 27s trunk passed
        +1 compile 0m 30s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 findbugs 0m 25s trunk passed
        +1 javadoc 0m 15s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 15s the patch passed
        +1 javac 0m 15s the patch passed
        +1 checkstyle 0m 11s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 0 new + 53 unchanged - 9 fixed = 53 total (was 62)
        +1 mvnsite 0m 45s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 30s the patch passed
        +1 javadoc 0m 11s the patch passed
              Other Tests
        +1 unit 3m 20s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        23m 12s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12052
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876550/HDFS-12052.07.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 052717cd9ef9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f1efa14
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20221/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20221/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 27s trunk passed +1 compile 0m 30s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 56s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 15s trunk passed       Patch Compile Tests +1 mvninstall 0m 19s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed +1 checkstyle 0m 11s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 0 new + 53 unchanged - 9 fixed = 53 total (was 62) +1 mvnsite 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 11s the patch passed       Other Tests +1 unit 3m 20s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 23m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12052 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876550/HDFS-12052.07.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 052717cd9ef9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f1efa14 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20221/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20221/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment - - edited

        Clicked the link https://builds.apache.org/job/PreCommit-HDFS-Build/20219/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt:

        ./hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSAuthenticationFilter.java:22:import org.apache.hadoop.fs.http.server.HttpFSServerWebServer;:1:
        Redundant import from the same package - org.apache.hadoop.fs.http.server.HttpFSServerWebServer. [RedundantImport]
        
        Show
        jzhuge John Zhuge added a comment - - edited Clicked the link https://builds.apache.org/job/PreCommit-HDFS-Build/20219/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt: ./hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSAuthenticationFilter.java:22:import org.apache.hadoop.fs.http.server.HttpFSServerWebServer;:1: Redundant import from the same package - org.apache.hadoop.fs.http.server.HttpFSServerWebServer. [RedundantImport]
        Hide
        3opan Zoran Dimitrijevic added a comment -

        I run dev-support/bin/test-patch --dirty-workspace --plugins=checkstyle,maven HDFS-12052.06.patch and it was +1. So, how do I see which new style offense still exists in this patch?

        Vote Subsystem Runtime Comment
        ============================================================================
        +1 mvninstall 9m 48s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 checkstyle 0m 9s the patch passed
            10m 21s
        Show
        3opan Zoran Dimitrijevic added a comment - I run dev-support/bin/test-patch --dirty-workspace --plugins=checkstyle,maven HDFS-12052 .06.patch and it was +1. So, how do I see which new style offense still exists in this patch? Vote Subsystem Runtime Comment ============================================================================ +1 mvninstall 9m 48s trunk passed +1 checkstyle 0m 13s trunk passed +1 checkstyle 0m 9s the patch passed     10m 21s
        Hide
        jzhuge John Zhuge added a comment -

        +1 LGTM pending the last minor checkstyle issue

        Show
        jzhuge John Zhuge added a comment - +1 LGTM pending the last minor checkstyle issue
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 13m 17s trunk passed
        +1 compile 0m 23s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 48s trunk passed
        +1 findbugs 0m 25s trunk passed
        +1 javadoc 0m 14s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 16s the patch passed
        +1 javac 0m 16s the patch passed
        -0 checkstyle 0m 12s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 1 new + 52 unchanged - 9 fixed = 53 total (was 61)
        +1 mvnsite 0m 44s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 30s the patch passed
        +1 javadoc 0m 11s the patch passed
              Other Tests
        +1 unit 3m 17s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        22m 37s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12052
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876534/HDFS-12052.06.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux baafe598894f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5496a34
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20219/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20219/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20219/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 17s trunk passed +1 compile 0m 23s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 48s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 14s trunk passed       Patch Compile Tests +1 mvninstall 0m 17s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed -0 checkstyle 0m 12s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 1 new + 52 unchanged - 9 fixed = 53 total (was 61) +1 mvnsite 0m 44s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 11s the patch passed       Other Tests +1 unit 3m 17s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 22m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12052 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876534/HDFS-12052.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux baafe598894f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5496a34 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20219/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20219/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20219/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Yetus only reports checkstyle issues on the modified lines.

        I am also very eager to make everything I touch as pretty as possible. Unfortunately too many gratuitous changes are not manageable when you have to maintain dozens of branches and do backports constantly, often in different commit orders. Clean backports are very much appreciated. Thank you Zoran Dimitrijevic for removing the style fixes.

        That said, style fixes on or very close to the modified lines are ok. Please do file refactor JIRAs where we can anticipate conflicts and resolve them just once.

        Show
        jzhuge John Zhuge added a comment - Yetus only reports checkstyle issues on the modified lines. I am also very eager to make everything I touch as pretty as possible. Unfortunately too many gratuitous changes are not manageable when you have to maintain dozens of branches and do backports constantly, often in different commit orders. Clean backports are very much appreciated. Thank you Zoran Dimitrijevic for removing the style fixes. That said, style fixes on or very close to the modified lines are ok. Please do file refactor JIRAs where we can anticipate conflicts and resolve them just once.
        Hide
        3opan Zoran Dimitrijevic added a comment -

        OK, so I am using the const which I made package private and corrected it to httpfs.ssl.enabled.

        John Zhuge I have removed unrelated style fixes (about 50 of those) from this patch. However, we should fix them and I can fix them in a different patch - because it's really hard to refactor code when even a simple test file contains 60 style issues that are trivial to fix...

        All good now?

        Show
        3opan Zoran Dimitrijevic added a comment - OK, so I am using the const which I made package private and corrected it to httpfs.ssl.enabled. John Zhuge I have removed unrelated style fixes (about 50 of those) from this patch. However, we should fix them and I can fix them in a different patch - because it's really hard to refactor code when even a simple test file contains 60 style issues that are trivial to fix... All good now?
        Hide
        jzhuge John Zhuge added a comment -

        Sorry for the confusion. The correct property name is httpfs.ssl.enabled. The property names are documented in doc and httpfs-default.xml. Environment variables are deprecated.

        HDFS-10860 made mistakes in using both hadoop.httpfs.ssl.enabled and httpfs.ssl.enabled. Filed HDFS-12114 to fix.

        For your patch, please use the following code:

              conf.setBoolean(HttpFSServerWebServer.SSL_ENABLED_KEY, true);
        

        You'd have to make HttpFSServerWebServer.SSL_ENABLED_KEY package private.

        Show
        jzhuge John Zhuge added a comment - Sorry for the confusion. The correct property name is httpfs.ssl.enabled . The property names are documented in doc and httpfs-default.xml. Environment variables are deprecated. HDFS-10860 made mistakes in using both hadoop.httpfs.ssl.enabled and httpfs.ssl.enabled. Filed HDFS-12114 to fix. For your patch, please use the following code: conf.setBoolean(HttpFSServerWebServer.SSL_ENABLED_KEY, true ); You'd have to make HttpFSServerWebServer.SSL_ENABLED_KEY package private.
        Hide
        raviprak Ravi Prakash added a comment - - edited

        I tried understanding the whole sequence of configurations set in environment variables, xml files, properties being passed around between HttpFS* and HttpServer2 and AuthenticationFilter, and threw up my hands.

        It makes sense to me that when HttpFS is configured with SSL, the delegation tokens returned by the server should be SWEBHDFS.

        Just one change, could you please use HttpFSServerWebServer.SSL_ENABLED_KEY instead of the hard coded string "httpfs.ssl.enabled"?

        I too am fine with the style fixes in this patch itself.

        Show
        raviprak Ravi Prakash added a comment - - edited I tried understanding the whole sequence of configurations set in environment variables, xml files, properties being passed around between HttpFS* and HttpServer2 and AuthenticationFilter , and threw up my hands. It makes sense to me that when HttpFS is configured with SSL, the delegation tokens returned by the server should be SWEBHDFS. Just one change, could you please use HttpFSServerWebServer.SSL_ENABLED_KEY instead of the hard coded string "httpfs.ssl.enabled" ? I too am fine with the style fixes in this patch itself.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 14m 39s trunk passed
        +1 compile 0m 19s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 49s trunk passed
        +1 findbugs 0m 27s trunk passed
        +1 javadoc 0m 15s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 17s the patch passed
        +1 javac 0m 17s the patch passed
        +1 checkstyle 0m 11s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 0 new + 7 unchanged - 54 fixed = 7 total (was 61)
        +1 mvnsite 0m 47s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 32s the patch passed
        +1 javadoc 0m 12s the patch passed
              Other Tests
        +1 unit 3m 24s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        24m 14s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12052
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876483/HDFS-12052.05.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f7537a72e3c1 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 09653ea
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20214/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20214/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 39s trunk passed +1 compile 0m 19s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 49s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 15s trunk passed       Patch Compile Tests +1 mvninstall 0m 17s the patch passed +1 compile 0m 17s the patch passed +1 javac 0m 17s the patch passed +1 checkstyle 0m 11s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 0 new + 7 unchanged - 54 fixed = 7 total (was 61) +1 mvnsite 0m 47s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 12s the patch passed       Other Tests +1 unit 3m 24s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 24m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12052 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876483/HDFS-12052.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f7537a72e3c1 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 09653ea Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20214/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20214/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        3opan Zoran Dimitrijevic added a comment -

        Removed unrelated style fixes from all but tests. I'll upload one more patch which doesn't have any unrelated style fixes even in that file if needed.

        Can you please comment about hadoop prefix and whether we want to fix that in this patch or in a different patch?

        Show
        3opan Zoran Dimitrijevic added a comment - Removed unrelated style fixes from all but tests. I'll upload one more patch which doesn't have any unrelated style fixes even in that file if needed. Can you please comment about hadoop prefix and whether we want to fix that in this patch or in a different patch?
        Hide
        aw Allen Wittenauer added a comment -

        They add noise to the code review and will complicate backport.

        I don't think this is going to be easy to backport anyway, given the shifts in code between 2 and 3. Personally, I'd prefer we fix style issues here anyway so that future commits don't have these issues. It's just a guideline to not fix style issues.

        The much bigger issue is this one:

        Do we want to use httpfs.ssl.enabled or hadoop.httpfs.ssl.enabled ?

        This is a much bigger problem. It looks like the shell profile code is wrong, but John Zhuge would know for sure. We should probably fix this at the same time while we are here.

        Show
        aw Allen Wittenauer added a comment - They add noise to the code review and will complicate backport. I don't think this is going to be easy to backport anyway, given the shifts in code between 2 and 3. Personally, I'd prefer we fix style issues here anyway so that future commits don't have these issues. It's just a guideline to not fix style issues. The much bigger issue is this one: Do we want to use httpfs.ssl.enabled or hadoop.httpfs.ssl.enabled ? This is a much bigger problem. It looks like the shell profile code is wrong, but John Zhuge would know for sure. We should probably fix this at the same time while we are here.
        Hide
        3opan Zoran Dimitrijevic added a comment -

        Sure John Zhuge. I had to reformat the tests which are then detected as new code by style checks - I'll remove all style fixes unrelated to test refactoring. You can then review the new patch which will contain these fixes so that we don't waste this opportunity to clean up the style as well?

        Show
        3opan Zoran Dimitrijevic added a comment - Sure John Zhuge . I had to reformat the tests which are then detected as new code by style checks - I'll remove all style fixes unrelated to test refactoring. You can then review the new patch which will contain these fixes so that we don't waste this opportunity to clean up the style as well?
        Hide
        jzhuge John Zhuge added a comment - - edited

        Thank you Zoran Dimitrijevic for the excellent find and the patch submitted.

        Could you please revert the unrelated format changes? They add noise to the code review and will complicate backport. Please read https://wiki.apache.org/hadoop/HowToContribute regarding "reformat" :

        Please do not:
        
        * reformat code unrelated to the bug being fixed: formatting changes should be separate patches/commits.
        

        Please note the reformat might been done automatically by your IDE.

        Show
        jzhuge John Zhuge added a comment - - edited Thank you Zoran Dimitrijevic for the excellent find and the patch submitted. Could you please revert the unrelated format changes? They add noise to the code review and will complicate backport. Please read https://wiki.apache.org/hadoop/HowToContribute regarding "reformat" : Please do not: * reformat code unrelated to the bug being fixed: formatting changes should be separate patches/commits. Please note the reformat might been done automatically by your IDE.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 13m 9s trunk passed
        +1 compile 0m 18s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 48s trunk passed
        +1 findbugs 0m 25s trunk passed
        +1 javadoc 0m 15s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 16s the patch passed
        +1 javac 0m 16s the patch passed
        +1 checkstyle 0m 10s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 0 new + 3 unchanged - 59 fixed = 3 total (was 62)
        +1 mvnsite 0m 45s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 30s the patch passed
        +1 javadoc 0m 11s the patch passed
              Other Tests
        +1 unit 3m 16s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        22m 14s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12052
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876366/HDFS-12052.04.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 801416647b2e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3de47ab
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20209/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20209/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 9s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 48s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 15s trunk passed       Patch Compile Tests +1 mvninstall 0m 17s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed +1 checkstyle 0m 10s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 0 new + 3 unchanged - 59 fixed = 3 total (was 62) +1 mvnsite 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 11s the patch passed       Other Tests +1 unit 3m 16s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 22m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12052 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876366/HDFS-12052.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 801416647b2e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3de47ab Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20209/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20209/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 13m 18s trunk passed
        +1 compile 0m 18s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 47s trunk passed
        +1 findbugs 0m 26s trunk passed
        +1 javadoc 0m 14s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 16s the patch passed
        +1 compile 0m 16s the patch passed
        +1 javac 0m 16s the patch passed
        -0 checkstyle 0m 10s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 1 new + 4 unchanged - 58 fixed = 5 total (was 62)
        +1 mvnsite 0m 45s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 30s the patch passed
        +1 javadoc 0m 12s the patch passed
              Other Tests
        +1 unit 3m 17s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        22m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12052
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876362/HDFS-12052.03.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 20bde48bb2e1 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3de47ab
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20208/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20208/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20208/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 18s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 47s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 14s trunk passed       Patch Compile Tests +1 mvninstall 0m 16s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed -0 checkstyle 0m 10s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 1 new + 4 unchanged - 58 fixed = 5 total (was 62) +1 mvnsite 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 12s the patch passed       Other Tests +1 unit 3m 17s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 22m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12052 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876362/HDFS-12052.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 20bde48bb2e1 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3de47ab Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20208/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20208/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20208/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 2m 18s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 13m 15s trunk passed
        +1 compile 0m 18s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 48s trunk passed
        +1 findbugs 0m 25s trunk passed
        +1 javadoc 0m 14s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 15s the patch passed
        +1 javac 0m 15s the patch passed
        -0 checkstyle 0m 11s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 1 new + 46 unchanged - 16 fixed = 47 total (was 62)
        +1 mvnsite 0m 45s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 31s the patch passed
        +1 javadoc 0m 12s the patch passed
              Other Tests
        +1 unit 3m 17s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        24m 29s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12052
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876341/HDFS-12052.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 25ba055bdd36 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3de47ab
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20205/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20205/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20205/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 2m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 15s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 48s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 14s trunk passed       Patch Compile Tests +1 mvninstall 0m 17s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed -0 checkstyle 0m 11s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 1 new + 46 unchanged - 16 fixed = 47 total (was 62) +1 mvnsite 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 31s the patch passed +1 javadoc 0m 12s the patch passed       Other Tests +1 unit 3m 17s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 24m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12052 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876341/HDFS-12052.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 25ba055bdd36 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3de47ab Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20205/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20205/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20205/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        3opan Zoran Dimitrijevic added a comment -

        Cleaned up few style issues to make style check happy.

        Show
        3opan Zoran Dimitrijevic added a comment - Cleaned up few style issues to make style check happy.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 13m 18s trunk passed
        +1 compile 0m 18s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 48s trunk passed
        +1 findbugs 0m 25s trunk passed
        +1 javadoc 0m 14s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 15s the patch passed
        +1 javac 0m 15s the patch passed
        -0 checkstyle 0m 11s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 7 new + 58 unchanged - 4 fixed = 65 total (was 62)
        +1 mvnsite 0m 47s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 30s the patch passed
        +1 javadoc 0m 11s the patch passed
              Other Tests
        +1 unit 3m 16s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        22m 25s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12052
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876338/HDFS-12052.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bb5b06291ed2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ba5b056
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20204/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20204/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20204/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 18s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 48s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 14s trunk passed       Patch Compile Tests +1 mvninstall 0m 17s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed -0 checkstyle 0m 11s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 7 new + 58 unchanged - 4 fixed = 65 total (was 62) +1 mvnsite 0m 47s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 11s the patch passed       Other Tests +1 unit 3m 16s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 22m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12052 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876338/HDFS-12052.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bb5b06291ed2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ba5b056 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20204/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20204/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20204/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        3opan Zoran Dimitrijevic added a comment -

        Do we want to use httpfs.ssl.enabled or hadoop.httpfs.ssl.enabled ? I searched over git repo, and it seems we set one in hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/libexec/shellprofile.d/hadoop-httpfs.sh and the other one in hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/resources/httpfs-default.xml

        Show
        3opan Zoran Dimitrijevic added a comment - Do we want to use httpfs.ssl.enabled or hadoop.httpfs.ssl.enabled ? I searched over git repo, and it seems we set one in hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/libexec/shellprofile.d/hadoop-httpfs.sh and the other one in hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/resources/httpfs-default.xml
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 13m 5s trunk passed
        +1 compile 0m 19s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 48s trunk passed
        +1 findbugs 0m 27s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 16s the patch passed
        +1 javac 0m 16s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 45s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 30s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 3m 15s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        22m 15s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12052
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874784/HDFS-12052.00.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ff3be9ec87e2 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7e031c2
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20066/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20066/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 5s trunk passed +1 compile 0m 19s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 48s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 3m 15s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 22m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12052 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874784/HDFS-12052.00.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ff3be9ec87e2 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7e031c2 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20066/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20066/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        3opan Zoran Dimitrijevic added a comment -

        This simple patch fixes the issue. I'll add tests soon.

        Show
        3opan Zoran Dimitrijevic added a comment - This simple patch fixes the issue. I'll add tests soon.

          People

          • Assignee:
            3opan Zoran Dimitrijevic
            Reporter:
            3opan Zoran Dimitrijevic
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development