Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We occasionally see that the under-replicated block count is not going down quickly enough. We've made at least one fix to speed up block replications (HDFS-9205) but we need better insight into the current state and activity of the block re-replication logic. For example, we need to understand whether is it because re-replication is not making forward progress at all, or is it because new under-replicated blocks are being added faster.

      We should include additional metrics:

      1. Cumulative number of blocks that were successfully replicated.
      2. Cumulative number of re-replications that timed out.
      3. Cumulative number of blocks that were dequeued for re-replication but not scheduled e.g. because they were invalid, or under-construction or replication was postponed.

      The growth rate of of the above metrics will make it clear whether block replication is making forward progress and if not then provide potential clues about why it is stalled.

      Thanks Arpit Agarwal for the offline discussions.

      1. HDFS-12043.001.patch
        6 kB
        Chen Liang
      2. HDFS-12043.002.patch
        12 kB
        Chen Liang
      3. HDFS-12043.003.patch
        12 kB
        Chen Liang
      4. HDFS-12043.004.patch
        13 kB
        Chen Liang
      5. HDFS-12043-branch-2.005.patch
        11 kB
        Chen Liang

        Issue Links

          Activity

          Hide
          vagarychen Chen Liang added a comment -

          Post v001 patch.

          Show
          vagarychen Chen Liang added a comment - Post v001 patch.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for this improvement Chen Liang! A few comments:

          1. Looks like we should call incFailedReconstructionSchedule here in scheduleReconstruction?
                if (block.isStriped()) {
                  if (pendingNum > 0) {
                    // Wait the previous reconstruction to finish.
                    return null;
                  }
            
          2. We should use the same terminology for all metric name i.e. either reconstruction or re-replication
          3. Suggest changing the description of failedReconstructionSchedule to Number of times we failed to schedule a block reconstruction.
          4. Number of timed out re-replication schedule: Reword as Number of timed out block re-replications.
          5. Nitpick: Number of successful re-replication should be Number of successful re-replications.

          Also, it is feasible to add unit tests for these counters?

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for this improvement Chen Liang ! A few comments: Looks like we should call incFailedReconstructionSchedule here in scheduleReconstruction ? if (block.isStriped()) { if (pendingNum > 0) { // Wait the previous reconstruction to finish. return null ; } We should use the same terminology for all metric name i.e. either reconstruction or re-replication Suggest changing the description of failedReconstructionSchedule to Number of times we failed to schedule a block reconstruction . Number of timed out re-replication schedule : Reword as Number of timed out block re-replications . Nitpick: Number of successful re-replication should be Number of successful re-replications . Also, it is feasible to add unit tests for these counters?
          Hide
          vagarychen Chen Liang added a comment -

          Thanks Arpit Agarwal for the comments! Post v002 patch.

          The other comments are addressed. Regarding the if (pendingNum > 0) branch, my understanding is that this means there are unfinished replication going on, not necessarily failed re-replication. It could still finish successfully, also it may timeout and counted by the other timeout counter. What do you think?

          Also in v002 patch, changed the place of incrementing timeout re-replication to the place where it gets detected in PendingReconstructionBlocks's thread. v001 patch actually delays the increment by calling in BlockManager's thread.

          Show
          vagarychen Chen Liang added a comment - Thanks Arpit Agarwal for the comments! Post v002 patch. The other comments are addressed. Regarding the if (pendingNum > 0) branch, my understanding is that this means there are unfinished replication going on, not necessarily failed re-replication. It could still finish successfully, also it may timeout and counted by the other timeout counter. What do you think? Also in v002 patch, changed the place of incrementing timeout re-replication to the place where it gets detected in PendingReconstructionBlocks 's thread. v001 patch actually delays the increment by calling in BlockManager 's thread.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 13m 26s trunk passed
          +1 compile 0m 58s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 findbugs 1m 49s trunk passed
          +1 javadoc 0m 43s trunk passed
          +1 mvninstall 0m 56s the patch passed
          +1 compile 0m 51s the patch passed
          +1 javac 0m 51s the patch passed
          -0 checkstyle 0m 36s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 174 unchanged - 1 fixed = 177 total (was 175)
          +1 mvnsite 0m 51s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 45s the patch passed
          +1 javadoc 0m 38s the patch passed
          -1 unit 66m 19s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          92m 18s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.TestReconstructStripedBlocks
            hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12043
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874983/HDFS-12043.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8cef9ac02737 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c1edca1
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20087/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20087/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20087/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20087/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 26s trunk passed +1 compile 0m 58s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 3s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 56s the patch passed +1 compile 0m 51s the patch passed +1 javac 0m 51s the patch passed -0 checkstyle 0m 36s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 174 unchanged - 1 fixed = 177 total (was 175) +1 mvnsite 0m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 38s the patch passed -1 unit 66m 19s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 92m 18s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestReconstructStripedBlocks   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12043 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874983/HDFS-12043.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8cef9ac02737 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c1edca1 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20087/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20087/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20087/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20087/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for updating the patch Chen Liang!

          Regarding the if (pendingNum > 0) branch, my understanding is that this means there are unfinished replication going on, not necessarily failed re-replication. It could still finish successfully, also it may timeout and counted by the other timeout counter.

          We should capture this somewhere because that slot was effectively wasted in this replication monitor iteration. Perhaps we can rename this metric from failedReReplicationSchedule to numTimesReReplicationNotScheduled which covers the other failures and this case of (pendingNum > 0).

          Also a nitpick, successfulReReplication and timeoutReReplication should be plural to be consistent with other metric names. timeoutReReplication can be called timedoutReReplications .

          We should also update the metrics documentation in Metrics.md. Ok to do so separately.

          I still need to review the unit tests.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for updating the patch Chen Liang ! Regarding the if (pendingNum > 0) branch, my understanding is that this means there are unfinished replication going on, not necessarily failed re-replication. It could still finish successfully, also it may timeout and counted by the other timeout counter. We should capture this somewhere because that slot was effectively wasted in this replication monitor iteration. Perhaps we can rename this metric from failedReReplicationSchedule to numTimesReReplicationNotScheduled which covers the other failures and this case of (pendingNum > 0) . Also a nitpick, successfulReReplication and timeoutReReplication should be plural to be consistent with other metric names. timeoutReReplication can be called timedoutReReplications . We should also update the metrics documentation in Metrics.md. Ok to do so separately. I still need to review the unit tests.
          Hide
          vagarychen Chen Liang added a comment -

          Thanks Arpit Agarwal for the comments! Post v003 patch to rename the metrics and added to if (pendingNum > 0) check.

          Show
          vagarychen Chen Liang added a comment - Thanks Arpit Agarwal for the comments! Post v003 patch to rename the metrics and added to if (pendingNum > 0) check.
          Hide
          vagarychen Chen Liang added a comment -

          Thanks Arpit Agarwal who pointed out offline that the use of thread.sleep() in the test can be reliable. Post v004 patch to use GenericTestUtils.waitFor() instead.

          Show
          vagarychen Chen Liang added a comment - Thanks Arpit Agarwal who pointed out offline that the use of thread.sleep() in the test can be reliable. Post v004 patch to use GenericTestUtils.waitFor() instead.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks Chen Liang. +1 for the v4 patch, pending Jenkins.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks Chen Liang . +1 for the v4 patch, pending Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 13m 25s trunk passed
          +1 compile 0m 51s trunk passed
          +1 checkstyle 0m 36s trunk passed
          +1 mvnsite 0m 54s trunk passed
          -1 findbugs 1m 49s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 0m 40s trunk passed
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 50s the patch passed
          +1 javac 0m 50s the patch passed
          -0 checkstyle 0m 32s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 174 unchanged - 1 fixed = 177 total (was 175)
          +1 mvnsite 0m 51s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 56s the patch passed
          +1 javadoc 0m 39s the patch passed
          -1 unit 68m 37s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          94m 18s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
            hadoop.hdfs.web.TestWebHdfsTimeouts
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12043
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875134/HDFS-12043.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 98fb1bee6f03 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 441378e
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20101/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20101/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20101/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20101/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20101/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 25s trunk passed +1 compile 0m 51s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 0m 54s trunk passed -1 findbugs 1m 49s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 50s the patch passed +1 javac 0m 50s the patch passed -0 checkstyle 0m 32s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 174 unchanged - 1 fixed = 177 total (was 175) +1 mvnsite 0m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 56s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 68m 37s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 94m 18s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12043 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875134/HDFS-12043.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 98fb1bee6f03 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 441378e Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20101/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20101/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20101/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20101/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20101/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Committed to trunk, thanks for the contribution Chen Liang!

          Show
          arpitagarwal Arpit Agarwal added a comment - Committed to trunk, thanks for the contribution Chen Liang !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11956 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11956/)
          HDFS-12043. Add counters for block re-replication. Contributed by Chen (arp: rev 900221f95ea9fe1936b4d5f277e6047ee8734eca)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReconstruction.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/PendingReconstructionBlocks.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11956 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11956/ ) HDFS-12043 . Add counters for block re-replication. Contributed by Chen (arp: rev 900221f95ea9fe1936b4d5f277e6047ee8734eca) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReconstruction.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/PendingReconstructionBlocks.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 14m 22s trunk passed
          +1 compile 0m 48s trunk passed
          +1 checkstyle 0m 39s trunk passed
          +1 mvnsite 0m 53s trunk passed
          -1 findbugs 1m 42s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 0m 41s trunk passed
          +1 mvninstall 0m 49s the patch passed
          +1 compile 0m 45s the patch passed
          +1 javac 0m 45s the patch passed
          -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 175 unchanged - 1 fixed = 178 total (was 176)
          +1 mvnsite 0m 51s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 44s the patch passed
          +1 javadoc 0m 38s the patch passed
          -1 unit 70m 33s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          96m 51s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12043
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875142/HDFS-12043.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d78ba43457d0 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 441378e
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20102/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20102/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20102/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20102/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20102/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 22s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 0m 53s trunk passed -1 findbugs 1m 42s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 175 unchanged - 1 fixed = 178 total (was 176) +1 mvnsite 0m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 38s the patch passed -1 unit 70m 33s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 96m 51s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12043 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875142/HDFS-12043.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d78ba43457d0 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 441378e Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20102/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20102/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20102/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20102/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20102/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vagarychen Chen Liang added a comment -

          Post v005 patch for branch-2

          Show
          vagarychen Chen Liang added a comment - Post v005 patch for branch-2
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Cloned as HDFS-12074 for Jenkins run.

          Show
          arpitagarwal Arpit Agarwal added a comment - Cloned as HDFS-12074 for Jenkins run.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11959 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11959/)
          Revert "HDFS-12043. Add counters for block re-replication. Contributed (arp: rev a2f0cbd92f7e90909cf817c261a5fae13a9695b4)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReconstruction.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/PendingReconstructionBlocks.java
            HDFS-12043. Add counters for block re-replication. Contributed by Chen (arp: rev 6a9dc5f44b0c7945e3e9a56248cd4ff80d5c8f0f)
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/PendingReconstructionBlocks.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReconstruction.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11959 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11959/ ) Revert " HDFS-12043 . Add counters for block re-replication. Contributed (arp: rev a2f0cbd92f7e90909cf817c261a5fae13a9695b4) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReconstruction.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/PendingReconstructionBlocks.java HDFS-12043 . Add counters for block re-replication. Contributed by Chen (arp: rev 6a9dc5f44b0c7945e3e9a56248cd4ff80d5c8f0f) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/PendingReconstructionBlocks.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReconstruction.java
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Committed to branch-2. Thanks for the backport Chen Liang.

          Show
          arpitagarwal Arpit Agarwal added a comment - Committed to branch-2. Thanks for the backport Chen Liang .
          Hide
          andrew.wang Andrew Wang added a comment -

          Bit of unfortunate history on this JIRA, looks like alpha4 was released between the initial bad commit and the subsequent revert and re-commit.

          I'm going to change the fix version to 3.0.0-beta1, since that's where the correct version will be released.

          Show
          andrew.wang Andrew Wang added a comment - Bit of unfortunate history on this JIRA, looks like alpha4 was released between the initial bad commit and the subsequent revert and re-commit. I'm going to change the fix version to 3.0.0-beta1, since that's where the correct version will be released.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thank you Andrew Wang.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thank you Andrew Wang .

            People

            • Assignee:
              vagarychen Chen Liang
              Reporter:
              vagarychen Chen Liang
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development