Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1204

0.20: Lease expiration should recover single files, not entire lease holder

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20-append
    • Fix Version/s: 0.20-append, 0.20.205.0
    • Component/s: None
    • Labels:
      None

      Description

      This was brought up in HDFS-200 but didn't make it into the branch on Apache.

      1. hdfs-1204.txt
        0.9 kB
        Todd Lipcon
      2. hdfs-1204.txt
        5 kB
        Todd Lipcon
      3. HDFS-1204.20-security.1.patch
        5 kB
        Jitendra Nath Pandey

        Activity

        Hide
        Matt Foley added a comment -

        Closed upon release of 0.20.205.0

        Show
        Matt Foley added a comment - Closed upon release of 0.20.205.0
        Hide
        Suresh Srinivas added a comment -

        +1 for the patch. I committed it to 0.20-security branch.

        Show
        Suresh Srinivas added a comment - +1 for the patch. I committed it to 0.20-security branch.
        Hide
        Jitendra Nath Pandey added a comment -

        Patch for 20-security.

        Show
        Jitendra Nath Pandey added a comment - Patch for 20-security.
        Hide
        Todd Lipcon added a comment -

        I think it does not - it looks like it was a regression caused by HDFS-200 in branch 20 append.

        Show
        Todd Lipcon added a comment - I think it does not - it looks like it was a regression caused by HDFS-200 in branch 20 append.
        Hide
        dhruba borthakur added a comment -

        Sam/Todd : can you pl comment on whether this bug exists in Hadoop trunk?

        Show
        dhruba borthakur added a comment - Sam/Todd : can you pl comment on whether this bug exists in Hadoop trunk?
        Hide
        Todd Lipcon added a comment -

        Here's a patch including the new unit test. Slightly edited the unit test to add synchronization around the checkLeases call - my build has assertions enabled, and it was throwing the assertion that internalReleaseLeaseOne was called w/o the FSN lock.

        Show
        Todd Lipcon added a comment - Here's a patch including the new unit test. Slightly edited the unit test to add synchronization around the checkLeases call - my build has assertions enabled, and it was throwing the assertion that internalReleaseLeaseOne was called w/o the FSN lock.
        Hide
        Todd Lipcon added a comment -

        ah, I didn't see but apparently Sam also posted a unit test here: https://issues.apache.org/jira/secure/attachment/12444747/checkLeases-fix-unit-test-1.txt

        (should commit the unit test too)

        Show
        Todd Lipcon added a comment - ah, I didn't see but apparently Sam also posted a unit test here: https://issues.apache.org/jira/secure/attachment/12444747/checkLeases-fix-unit-test-1.txt (should commit the unit test too)
        Hide
        Todd Lipcon added a comment -

        Assigning to Sam Rash, since I just made the patch based on his comment.

        Show
        Todd Lipcon added a comment - Assigning to Sam Rash, since I just made the patch based on his comment.
        Hide
        dhruba borthakur added a comment -

        +1

        Show
        dhruba borthakur added a comment - +1

          People

          • Assignee:
            sam rash
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development