Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11992

Replace commons-logging APIs with slf4j in FsDatasetImpl

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha3
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:
      None

      Description

      FsDatasetImpl.LOG is widely used and this will change the APIs of InstrumentedLock and InstrumentedWriteLock, so this issue is to change only FsDatasetImpl.LOG and other related APIs.

      1. HDFS-11992.001.patch
        12 kB
        hu xiaodong
      2. HDFS-11992.002.patch
        12 kB
        hu xiaodong
      3. HDFS-11992.branch-2.01.patch
        13 kB
        hu xiaodong
      4. HDFS-11992-branch-2.001.patch
        13 kB
        hu xiaodong

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 15m 51s trunk passed
          +1 compile 16m 58s trunk passed
          +1 checkstyle 1m 59s trunk passed
          +1 mvnsite 2m 21s trunk passed
          -1 findbugs 1m 38s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 41s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 47s the patch passed
          +1 compile 13m 43s the patch passed
          +1 javac 13m 43s the patch passed
          -0 checkstyle 2m 2s root: The patch generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100)
          +1 mvnsite 2m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 32s the patch passed
          +1 javadoc 2m 5s the patch passed
          -1 unit 10m 22s hadoop-common in the patch failed.
          -1 unit 91m 52s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          174m 3s



          Reason Tests
          Failed junit tests hadoop.fs.TestFilterFileSystem
            hadoop.fs.TestHarFileSystem
            hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.web.TestWebHdfsTimeouts



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11992
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873460/HDFS-11992.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2eb3a5a25933 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 75043d3
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19945/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19945/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19945/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19945/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19945/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19945/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 15m 51s trunk passed +1 compile 16m 58s trunk passed +1 checkstyle 1m 59s trunk passed +1 mvnsite 2m 21s trunk passed -1 findbugs 1m 38s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 41s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 47s the patch passed +1 compile 13m 43s the patch passed +1 javac 13m 43s the patch passed -0 checkstyle 2m 2s root: The patch generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100) +1 mvnsite 2m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 32s the patch passed +1 javadoc 2m 5s the patch passed -1 unit 10m 22s hadoop-common in the patch failed. -1 unit 91m 52s hadoop-hdfs in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 174m 3s Reason Tests Failed junit tests hadoop.fs.TestFilterFileSystem   hadoop.fs.TestHarFileSystem   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.web.TestWebHdfsTimeouts Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11992 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873460/HDFS-11992.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2eb3a5a25933 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 75043d3 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19945/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19945/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19945/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19945/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19945/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19945/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vagarychen Chen Liang added a comment -

          Thanks hu xiaodong for the contribution! v001 patch LGTM.

          Show
          vagarychen Chen Liang added a comment - Thanks hu xiaodong for the contribution! v001 patch LGTM.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks hu xiaodong for the patch.
          1.

                FsDatasetImpl.LOG.warn(" Getting exception while validating integrity " +
                        "and setting Length for blockFile", e);
          
          • Would you remove a whitespace before 'Getting'?
          • Length -> length

          2. Would you fix checkstyle warning?

          ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestInstrumentedReadWriteLock.java:38:  static final Logger LOG = LoggerFactory.getLogger(TestInstrumentedReadWriteLock.class);: Line is longer than 80 characters (found 89). [LineLength]
          

          3. Would you use {}-placeholders for logging? For example,

              if (LOG.isDebugEnabled()) {
                LOG.debug("Changing meta file offset of block " + b + " from " +
                    oldPos + " to " + newPos);
              }
          

          can be replaced with

              LOG.debug("Changing meta file offset of block {} from {} to {}",
                  b, oldPos, newPos);
          

          Please see https://www.slf4j.org/faq.html#logging_performance for more details.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks hu xiaodong for the patch. 1. FsDatasetImpl.LOG.warn( " Getting exception while validating integrity " + "and setting Length for blockFile" , e); Would you remove a whitespace before 'Getting'? Length -> length 2. Would you fix checkstyle warning? ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestInstrumentedReadWriteLock.java:38: static final Logger LOG = LoggerFactory.getLogger(TestInstrumentedReadWriteLock.class);: Line is longer than 80 characters (found 89). [LineLength] 3. Would you use {}-placeholders for logging? For example, if (LOG.isDebugEnabled()) { LOG.debug( "Changing meta file offset of block " + b + " from " + oldPos + " to " + newPos); } can be replaced with LOG.debug( "Changing meta file offset of block {} from {} to {}" , b, oldPos, newPos); Please see https://www.slf4j.org/faq.html#logging_performance for more details.
          Hide
          xiaodong.hu hu xiaodong added a comment -

          Thanks Akira Ajisaka,
          I will modify as you said.
          But if use {}-placeholders for logging, there are lots of files that need to be changed. about 100 points need to be modify.

          Show
          xiaodong.hu hu xiaodong added a comment - Thanks Akira Ajisaka , I will modify as you said. But if use {}-placeholders for logging, there are lots of files that need to be changed. about 100 points need to be modify.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Yes. There are lot of files to be changed, so either way is fine.

          • Use {}-placeholders for logging in this issue
            or
          • Create a separate issue(s) to use {}-placeholders.
          Show
          ajisakaa Akira Ajisaka added a comment - Yes. There are lot of files to be changed, so either way is fine. Use {}-placeholders for logging in this issue or Create a separate issue(s) to use {}-placeholders.
          Hide
          xiaodong.hu hu xiaodong added a comment -

          I think creating a separate issues to use {}-placeholders is more suitable. A patch too big may went wrong.

          Show
          xiaodong.hu hu xiaodong added a comment - I think creating a separate issues to use {}-placeholders is more suitable. A patch too big may went wrong.
          Hide
          xiaodong.hu hu xiaodong added a comment -

          hello, Akira Ajisaka
          I have modified as you said excepting Using {}-placeholders for logging.
          see the 002.patch.
          thank you very much.

          Show
          xiaodong.hu hu xiaodong added a comment - hello, Akira Ajisaka I have modified as you said excepting Using {}-placeholders for logging. see the 002.patch. thank you very much.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 32s Maven dependency ordering for branch
          +1 mvninstall 15m 11s trunk passed
          +1 compile 15m 19s trunk passed
          +1 checkstyle 2m 3s trunk passed
          +1 mvnsite 2m 15s trunk passed
          -1 findbugs 1m 35s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 45s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 37s the patch passed
          +1 compile 10m 23s the patch passed
          +1 javac 10m 23s the patch passed
          +1 checkstyle 1m 57s the patch passed
          +1 mvnsite 2m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 30s the patch passed
          +1 javadoc 1m 36s the patch passed
          +1 unit 8m 7s hadoop-common in the patch passed.
          -1 unit 70m 16s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          143m 38s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11992
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873622/HDFS-11992.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 21c91c5a373e 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 099dfe9
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19964/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19964/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19964/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19964/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 32s Maven dependency ordering for branch +1 mvninstall 15m 11s trunk passed +1 compile 15m 19s trunk passed +1 checkstyle 2m 3s trunk passed +1 mvnsite 2m 15s trunk passed -1 findbugs 1m 35s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 45s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 37s the patch passed +1 compile 10m 23s the patch passed +1 javac 10m 23s the patch passed +1 checkstyle 1m 57s the patch passed +1 mvnsite 2m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 30s the patch passed +1 javadoc 1m 36s the patch passed +1 unit 8m 7s hadoop-common in the patch passed. -1 unit 70m 16s hadoop-hdfs in the patch failed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 143m 38s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11992 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873622/HDFS-11992.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 21c91c5a373e 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 099dfe9 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19964/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19964/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19964/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19964/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, checking this in.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, checking this in.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks! Committed this to trunk.
          I noticed HADOOP-14542 is required when backporting to branch-2 due to the use of IOUtils.cleanup(Logger, Closeable...). Would you create a patch for branch-2 after HADOOP-14542 is fixed?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks! Committed this to trunk. I noticed HADOOP-14542 is required when backporting to branch-2 due to the use of IOUtils.cleanup(Logger, Closeable...) . Would you create a patch for branch-2 after HADOOP-14542 is fixed?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11899 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11899/)
          HDFS-11992. Replace commons-logging APIs with slf4j in FsDatasetImpl. (aajisaka: rev 1a598479a9faec787706bcf924dfbd88a80e1b82)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/InstrumentedReadWriteLock.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/InstrumentedReadLock.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestInstrumentedLock.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/InstrumentedLock.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestInstrumentedReadWriteLock.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/InstrumentedWriteLock.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11899 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11899/ ) HDFS-11992 . Replace commons-logging APIs with slf4j in FsDatasetImpl. (aajisaka: rev 1a598479a9faec787706bcf924dfbd88a80e1b82) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/InstrumentedReadWriteLock.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/InstrumentedReadLock.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestInstrumentedLock.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/InstrumentedLock.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestInstrumentedReadWriteLock.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/InstrumentedWriteLock.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          Hide
          xiaodong.hu hu xiaodong added a comment -

          thanks Akira Ajisaka, I will create a patch for branch-2 after HADOOP-14542 is fixed.

          Show
          xiaodong.hu hu xiaodong added a comment - thanks Akira Ajisaka , I will create a patch for branch-2 after HADOOP-14542 is fixed.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Now HADOOP-14542 is fixed. Please go ahead.

          Show
          ajisakaa Akira Ajisaka added a comment - Now HADOOP-14542 is fixed. Please go ahead.
          Hide
          xiaodong.hu hu xiaodong added a comment -

          OK, Akira Ajisaka, patch for branch-2 attached.

          Show
          xiaodong.hu hu xiaodong added a comment - OK, Akira Ajisaka , patch for branch-2 attached.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 1s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 54s Maven dependency ordering for branch
          -1 mvninstall 0m 26s root in branch-2 failed.
          +1 compile 5m 51s branch-2 passed with JDK v1.8.0_131
          -1 compile 0m 25s root in branch-2 failed with JDK v1.7.0_131.
          +1 checkstyle 1m 29s branch-2 passed
          -1 mvnsite 0m 28s hadoop-hdfs in branch-2 failed.
          -1 findbugs 0m 26s hadoop-hdfs in branch-2 failed.
          +1 javadoc 1m 23s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 1m 48s branch-2 passed with JDK v1.7.0_131
          0 mvndep 0m 15s Maven dependency ordering for patch
          -1 mvninstall 0m 22s hadoop-hdfs in the patch failed.
          +1 compile 5m 53s the patch passed with JDK v1.8.0_131
          +1 javac 5m 53s the patch passed
          -1 compile 0m 24s root in the patch failed with JDK v1.7.0_131.
          -1 javac 0m 24s root in the patch failed with JDK v1.7.0_131.
          +1 checkstyle 1m 36s the patch passed
          -1 mvnsite 0m 29s hadoop-hdfs in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 29s hadoop-hdfs in the patch failed.
          +1 javadoc 1m 27s the patch passed with JDK v1.8.0_131
          +1 javadoc 1m 50s the patch passed with JDK v1.7.0_131
          +1 unit 8m 0s hadoop-common in the patch passed with JDK v1.7.0_131.
          -1 unit 0m 28s hadoop-hdfs in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          63m 50s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HDFS-11992
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874041/HDFS-11992.branch-2.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2f6667bb6fa2 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 897d5a4
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/branch-compile-root-jdk1.7.0_131.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19997/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19997/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 54s Maven dependency ordering for branch -1 mvninstall 0m 26s root in branch-2 failed. +1 compile 5m 51s branch-2 passed with JDK v1.8.0_131 -1 compile 0m 25s root in branch-2 failed with JDK v1.7.0_131. +1 checkstyle 1m 29s branch-2 passed -1 mvnsite 0m 28s hadoop-hdfs in branch-2 failed. -1 findbugs 0m 26s hadoop-hdfs in branch-2 failed. +1 javadoc 1m 23s branch-2 passed with JDK v1.8.0_131 +1 javadoc 1m 48s branch-2 passed with JDK v1.7.0_131 0 mvndep 0m 15s Maven dependency ordering for patch -1 mvninstall 0m 22s hadoop-hdfs in the patch failed. +1 compile 5m 53s the patch passed with JDK v1.8.0_131 +1 javac 5m 53s the patch passed -1 compile 0m 24s root in the patch failed with JDK v1.7.0_131. -1 javac 0m 24s root in the patch failed with JDK v1.7.0_131. +1 checkstyle 1m 36s the patch passed -1 mvnsite 0m 29s hadoop-hdfs in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 29s hadoop-hdfs in the patch failed. +1 javadoc 1m 27s the patch passed with JDK v1.8.0_131 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_131 +1 unit 8m 0s hadoop-common in the patch passed with JDK v1.7.0_131. -1 unit 0m 28s hadoop-hdfs in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 63m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HDFS-11992 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874041/HDFS-11992.branch-2.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2f6667bb6fa2 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 897d5a4 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/branch-compile-root-jdk1.7.0_131.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19997/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19997/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19997/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaodong.hu hu xiaodong added a comment -

          rename branch-2 patch according to HowToContribute

          Show
          xiaodong.hu hu xiaodong added a comment - rename branch-2 patch according to HowToContribute
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 17m 29s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 4m 4s Maven dependency ordering for branch
          -1 mvninstall 0m 29s root in branch-2 failed.
          +1 compile 5m 21s branch-2 passed with JDK v1.8.0_131
          -1 compile 0m 25s root in branch-2 failed with JDK v1.7.0_131.
          +1 checkstyle 1m 23s branch-2 passed
          -1 mvnsite 0m 27s hadoop-hdfs in branch-2 failed.
          -1 findbugs 0m 25s hadoop-hdfs in branch-2 failed.
          +1 javadoc 1m 21s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 1m 50s branch-2 passed with JDK v1.7.0_131
          0 mvndep 0m 17s Maven dependency ordering for patch
          -1 mvninstall 0m 23s hadoop-hdfs in the patch failed.
          +1 compile 5m 17s the patch passed with JDK v1.8.0_131
          +1 javac 5m 17s the patch passed
          -1 compile 0m 25s root in the patch failed with JDK v1.7.0_131.
          -1 javac 0m 25s root in the patch failed with JDK v1.7.0_131.
          +1 checkstyle 1m 24s the patch passed
          -1 mvnsite 0m 28s hadoop-hdfs in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 26s hadoop-hdfs in the patch failed.
          +1 javadoc 0m 43s hadoop-common in the patch passed with JDK v1.8.0_131.
          +1 javadoc 0m 38s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_131 with JDK v1.8.0_131 generated 0 new + 23 unchanged - 3 fixed = 23 total (was 26)
          +1 javadoc 0m 48s hadoop-common in the patch passed with JDK v1.7.0_131.
          +1 javadoc 0m 59s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131 with JDK v1.7.0_131 generated 0 new + 23 unchanged - 3 fixed = 23 total (was 26)
          +1 unit 7m 31s hadoop-common in the patch passed with JDK v1.7.0_131.
          -1 unit 0m 26s hadoop-hdfs in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          68m 6s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HDFS-11992
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874081/HDFS-11992-branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 88ace7ee5f12 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 897d5a4
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/branch-compile-root-jdk1.7.0_131.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19998/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19998/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 17m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 4m 4s Maven dependency ordering for branch -1 mvninstall 0m 29s root in branch-2 failed. +1 compile 5m 21s branch-2 passed with JDK v1.8.0_131 -1 compile 0m 25s root in branch-2 failed with JDK v1.7.0_131. +1 checkstyle 1m 23s branch-2 passed -1 mvnsite 0m 27s hadoop-hdfs in branch-2 failed. -1 findbugs 0m 25s hadoop-hdfs in branch-2 failed. +1 javadoc 1m 21s branch-2 passed with JDK v1.8.0_131 +1 javadoc 1m 50s branch-2 passed with JDK v1.7.0_131 0 mvndep 0m 17s Maven dependency ordering for patch -1 mvninstall 0m 23s hadoop-hdfs in the patch failed. +1 compile 5m 17s the patch passed with JDK v1.8.0_131 +1 javac 5m 17s the patch passed -1 compile 0m 25s root in the patch failed with JDK v1.7.0_131. -1 javac 0m 25s root in the patch failed with JDK v1.7.0_131. +1 checkstyle 1m 24s the patch passed -1 mvnsite 0m 28s hadoop-hdfs in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 26s hadoop-hdfs in the patch failed. +1 javadoc 0m 43s hadoop-common in the patch passed with JDK v1.8.0_131. +1 javadoc 0m 38s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_131 with JDK v1.8.0_131 generated 0 new + 23 unchanged - 3 fixed = 23 total (was 26) +1 javadoc 0m 48s hadoop-common in the patch passed with JDK v1.7.0_131. +1 javadoc 0m 59s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131 with JDK v1.7.0_131 generated 0 new + 23 unchanged - 3 fixed = 23 total (was 26) +1 unit 7m 31s hadoop-common in the patch passed with JDK v1.7.0_131. -1 unit 0m 26s hadoop-hdfs in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 68m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HDFS-11992 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874081/HDFS-11992-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 88ace7ee5f12 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 897d5a4 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/branch-compile-root-jdk1.7.0_131.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19998/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19998/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19998/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          compile 0m 25s root in branch-2 failed with JDK v1.7.0_131.

          This failure is caused by HADOOP-14146 and not related to the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - compile 0m 25s root in branch-2 failed with JDK v1.7.0_131. This failure is caused by HADOOP-14146 and not related to the patch.
          Hide
          xiaodong.hu hu xiaodong added a comment -

          Hi Akira Ajisaka,
          Is there any other things should I do for branch-2?

          Show
          xiaodong.hu hu xiaodong added a comment - Hi Akira Ajisaka , Is there any other things should I do for branch-2?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Kicked precommit job manually: https://builds.apache.org/job/PreCommit-HDFS-Build/20038/
          Let me see what happens.

          Show
          ajisakaa Akira Ajisaka added a comment - Kicked precommit job manually: https://builds.apache.org/job/PreCommit-HDFS-Build/20038/ Let me see what happens.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 42s Maven dependency ordering for branch
          +1 mvninstall 6m 34s branch-2 passed
          +1 compile 5m 21s branch-2 passed with JDK v1.8.0_131
          +1 compile 6m 37s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 1m 22s branch-2 passed
          +1 mvnsite 1m 47s branch-2 passed
          +1 findbugs 3m 20s branch-2 passed
          +1 javadoc 1m 10s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 1m 41s branch-2 passed with JDK v1.7.0_131
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 18s the patch passed
          +1 compile 5m 8s the patch passed with JDK v1.8.0_131
          +1 javac 5m 8s the patch passed
          +1 compile 6m 9s the patch passed with JDK v1.7.0_131
          +1 javac 6m 9s the patch passed
          +1 checkstyle 1m 17s the patch passed
          +1 mvnsite 1m 41s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 48s the patch passed
          +1 javadoc 1m 15s the patch passed with JDK v1.8.0_131
          +1 javadoc 1m 40s the patch passed with JDK v1.7.0_131
          -1 unit 10m 4s hadoop-common in the patch failed with JDK v1.7.0_131.
          -1 unit 52m 0s hadoop-hdfs in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          173m 19s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts
            hadoop.hdfs.TestSafeMode
            hadoop.hdfs.server.namenode.TestNameNodeMXBean
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          JDK v1.7.0_131 Failed junit tests hadoop.security.TestShellBasedUnixGroupsMapping
            hadoop.crypto.key.TestValueQueue
            hadoop.hdfs.web.TestWebHdfsTimeouts
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.balancer.TestBalancerRPCDelay



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HDFS-11992
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874081/HDFS-11992-branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 632acc071841 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 239b382
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20038/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_131.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20038/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20038/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20038/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 42s Maven dependency ordering for branch +1 mvninstall 6m 34s branch-2 passed +1 compile 5m 21s branch-2 passed with JDK v1.8.0_131 +1 compile 6m 37s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 1m 22s branch-2 passed +1 mvnsite 1m 47s branch-2 passed +1 findbugs 3m 20s branch-2 passed +1 javadoc 1m 10s branch-2 passed with JDK v1.8.0_131 +1 javadoc 1m 41s branch-2 passed with JDK v1.7.0_131 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 18s the patch passed +1 compile 5m 8s the patch passed with JDK v1.8.0_131 +1 javac 5m 8s the patch passed +1 compile 6m 9s the patch passed with JDK v1.7.0_131 +1 javac 6m 9s the patch passed +1 checkstyle 1m 17s the patch passed +1 mvnsite 1m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 48s the patch passed +1 javadoc 1m 15s the patch passed with JDK v1.8.0_131 +1 javadoc 1m 40s the patch passed with JDK v1.7.0_131 -1 unit 10m 4s hadoop-common in the patch failed with JDK v1.7.0_131. -1 unit 52m 0s hadoop-hdfs in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 173m 19s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.7.0_131 Failed junit tests hadoop.security.TestShellBasedUnixGroupsMapping   hadoop.crypto.key.TestValueQueue   hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.balancer.TestBalancerRPCDelay Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HDFS-11992 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874081/HDFS-11992-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 632acc071841 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 239b382 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/20038/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_131.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20038/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20038/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20038/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1. All the failed tests except TestFsDatasetImpl passed locally. TestFsDatasetImpl is failing but it is not related to the patch. Filed HDFS-12040.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1. All the failed tests except TestFsDatasetImpl passed locally. TestFsDatasetImpl is failing but it is not related to the patch. Filed HDFS-12040 .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2. Thanks hu xiaodong!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2. Thanks hu xiaodong !

            People

            • Assignee:
              xiaodong.hu hu xiaodong
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development