[HDFS-11927] hdfs oiv_legacy:Normalize the verification of input parameter

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.0.0-alpha3
• Component/s: tools
• Target Version/s: 3.5.0
• Flags: Patch
• Assignee: LiXin Ge
• Reporter: LiXin Ge
• Created: 05/Jun/17 10:25
• Updated: 04/Jan/24 07:22

Description

At present, hdfs oiv_legacy tool lacks in verification of input parameter.people can type in irrelevant option like:

./hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p XML -step 1024

or type in option with wrong format which he think come into effec but actually not:

./hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p FileDistribution maxSize 4096 step 512 format

or some meaningless word which can also get through:

./hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p XML Hello World

We'd better not let these cases go unchecked.
By the way, this patch fixed some checkstyle warnings in DelimitedImageVisitor.java