Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11927

hdfs oiv_legacy:Normalize the verification of input parameter

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0-alpha3
    • Fix Version/s: None
    • Component/s: tools
    • Labels:
      None
    • Target Version/s:
    • Flags:
      Patch

      Description

      At present, hdfs oiv_legacy tool lacks in verification of input parameter.people can type in irrelevant option like:

      ./hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p XML -step 1024

      or type in option with wrong format which he think come into effec but actually not:

      ./hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p FileDistribution maxSize 4096 step 512 format

      or some meaningless word which can also get through:

      ./hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p XML Hello World

      We'd better not let these cases go unchecked.
      By the way, this patch fixed some checkstyle warnings in DelimitedImageVisitor.java

        Attachments

        1. HDFS-11927.002.patch
          11 kB
          LiXin Ge
        2. HDFS-11927.patch
          11 kB
          LiXin Ge

          Activity

            People

            • Assignee:
              GeLiXin LiXin Ge
              Reporter:
              GeLiXin LiXin Ge
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: