Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11736

OIV tests should not write outside 'target' directory.

    Details

      Description

      A few tests use Files.createTempDir() from Guava package, but do not set java.io.tmpdir system property. Thus the temp directory is created in unpredictable places and is not being cleaned up by mvn clean.
      This was probably introduced in TestOfflineImageViewer and then replicated in TestCheckpoint, TestStandbyCheckpoints.

      1. HDFS-11736.001.patch
        3 kB
        Yiqun Lin
      2. HDFS-11736.002.patch
        3 kB
        Yiqun Lin
      3. HDFS-11736.003.patch
        4 kB
        Yiqun Lin
      4. HDFS-11736-branch-2.001.patch
        4 kB
        Yiqun Lin
      5. HDFS-11736-branch-2.7.001.patch
        2 kB
        Yiqun Lin
      6. HDFS-11736-branch-2.7.002.patch
        3 kB
        Yiqun Lin

        Activity

        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to branch-2 and branch-2.8. Thanks!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to branch-2 and branch-2.8. Thanks!
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, checking this in.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, checking this in.
        Hide
        linyiqun Yiqun Lin added a comment -

        The test failures are not related. And the patch for branch-2 can cleanly apply to branch-2.8.

        Show
        linyiqun Yiqun Lin added a comment - The test failures are not related. And the patch for branch-2 can cleanly apply to branch-2.8.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 12m 33s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 6m 50s branch-2 passed
        +1 compile 0m 40s branch-2 passed with JDK v1.8.0_131
        +1 compile 0m 43s branch-2 passed with JDK v1.7.0_131
        +1 checkstyle 0m 30s branch-2 passed
        +1 mvnsite 0m 53s branch-2 passed
        +1 findbugs 1m 58s branch-2 passed
        +1 javadoc 0m 38s branch-2 passed with JDK v1.8.0_131
        +1 javadoc 0m 59s branch-2 passed with JDK v1.7.0_131
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 37s the patch passed with JDK v1.8.0_131
        +1 javac 0m 37s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.7.0_131
        +1 javac 0m 40s the patch passed
        +1 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 128 unchanged - 2 fixed = 128 total (was 130)
        +1 mvnsite 0m 50s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 11s the patch passed
        +1 javadoc 0m 36s the patch passed with JDK v1.8.0_131
        +1 javadoc 0m 58s the patch passed with JDK v1.7.0_131
        -1 unit 53m 57s hadoop-hdfs in the patch failed with JDK v1.7.0_131.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        139m 43s



        Reason Tests
        JDK v1.7.0_131 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain
        JDK v1.7.0_131 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5e40efe
        JIRA Issue HDFS-11736
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873228/HDFS-11736-branch-2.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 28a11fdbc113 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 12cb345
        Default Java 1.7.0_131
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19924/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt
        JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19924/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19924/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 6m 50s branch-2 passed +1 compile 0m 40s branch-2 passed with JDK v1.8.0_131 +1 compile 0m 43s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 30s branch-2 passed +1 mvnsite 0m 53s branch-2 passed +1 findbugs 1m 58s branch-2 passed +1 javadoc 0m 38s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 59s branch-2 passed with JDK v1.7.0_131 +1 mvninstall 0m 44s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_131 +1 javac 0m 37s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_131 +1 javac 0m 40s the patch passed +1 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 128 unchanged - 2 fixed = 128 total (was 130) +1 mvnsite 0m 50s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 11s the patch passed +1 javadoc 0m 36s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 58s the patch passed with JDK v1.7.0_131 -1 unit 53m 57s hadoop-hdfs in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 139m 43s Reason Tests JDK v1.7.0_131 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain JDK v1.7.0_131 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HDFS-11736 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873228/HDFS-11736-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 28a11fdbc113 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 12cb345 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/19924/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19924/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19924/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment - - edited

        Thanks Jason Lowe for reporting this. Attach the patch for branch-2/2.8.

        Show
        linyiqun Yiqun Lin added a comment - - edited Thanks Jason Lowe for reporting this. Attach the patch for branch-2/2.8.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jason Lowe for the report. I've reverted this commit from branch-2 and branch-2.8. Hi Yiqun Lin, would you create patch for branch-2/2.8?

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jason Lowe for the report. I've reverted this commit from branch-2 and branch-2.8. Hi Yiqun Lin , would you create patch for branch-2/2.8?
        Hide
        jlowe Jason Lowe added a comment -

        The branch-2 and branch-2.8 builds broke after this commit due to a compilation error:

        [ERROR] COMPILATION ERROR : 
        [INFO] -------------------------------------------------------------
        [ERROR] /hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java:[117,35] cannot find symbol
          symbol:   method getNameNodeDirectory(java.lang.String,int,int)
          location: class org.apache.hadoop.hdfs.MiniDFSCluster
        
        Show
        jlowe Jason Lowe added a comment - The branch-2 and branch-2.8 builds broke after this commit due to a compilation error: [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java:[117,35] cannot find symbol symbol: method getNameNodeDirectory(java.lang.String,int,int) location: class org.apache.hadoop.hdfs.MiniDFSCluster
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11866 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11866/)
        HDFS-11736. OIV tests should not write outside 'target' directory. (aajisaka: rev 315f07700dcfe32513b87f63070db854ecb3cf48)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11866 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11866/ ) HDFS-11736 . OIV tests should not write outside 'target' directory. (aajisaka: rev 315f07700dcfe32513b87f63070db854ecb3cf48) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Sorry, I forgot to pushing this to branch-2. Now I've done. Thanks Yiqun Lin!

        Show
        ajisakaa Akira Ajisaka added a comment - Sorry, I forgot to pushing this to branch-2. Now I've done. Thanks Yiqun Lin !
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for the commit, are you missing the commit of branch-2? As I see there are only three commits on this JIRA.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for the commit, are you missing the commit of branch-2? As I see there are only three commits on this JIRA.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, branch-2.8, and branch-2.7.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, branch-2.8, and branch-2.7.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, checking this in.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, checking this in.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 12m 44s trunk passed
        +1 compile 0m 43s trunk passed
        +1 checkstyle 0m 36s trunk passed
        +1 mvnsite 0m 48s trunk passed
        +1 findbugs 1m 30s trunk passed
        +1 javadoc 0m 39s trunk passed
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        +1 checkstyle 0m 31s the patch passed
        +1 mvnsite 0m 45s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 37s the patch passed
        +1 javadoc 0m 37s the patch passed
        -1 unit 64m 24s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        88m 12s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.web.TestWebHdfsTimeouts



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11736
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872849/HDFS-11736.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 104cd1d1afdb 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8633ef8
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19895/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19895/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19895/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 12m 44s trunk passed +1 compile 0m 43s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 0m 48s trunk passed +1 findbugs 1m 30s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 checkstyle 0m 31s the patch passed +1 mvnsite 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 37s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 64m 24s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 88m 12s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.web.TestWebHdfsTimeouts Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11736 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872849/HDFS-11736.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 104cd1d1afdb 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8633ef8 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/19895/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19895/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19895/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 1s branch-2.7 passed
        +1 compile 1m 1s branch-2.7 passed with JDK v1.8.0_131
        +1 compile 1m 0s branch-2.7 passed with JDK v1.7.0_131
        +1 checkstyle 0m 23s branch-2.7 passed
        +1 mvnsite 0m 59s branch-2.7 passed
        +1 findbugs 2m 53s branch-2.7 passed
        +1 javadoc 0m 58s branch-2.7 passed with JDK v1.8.0_131
        +1 javadoc 1m 43s branch-2.7 passed with JDK v1.7.0_131
        +1 mvninstall 0m 53s the patch passed
        +1 compile 0m 56s the patch passed with JDK v1.8.0_131
        +1 javac 0m 56s the patch passed
        +1 compile 0m 57s the patch passed with JDK v1.7.0_131
        +1 javac 0m 57s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 56s the patch passed
        -1 whitespace 0m 0s The patch has 2123 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        -1 whitespace 0m 55s The patch 70 line(s) with tabs.
        +1 findbugs 3m 5s the patch passed
        +1 javadoc 0m 55s the patch passed with JDK v1.8.0_131
        +1 javadoc 1m 39s the patch passed with JDK v1.7.0_131
        -1 unit 42m 56s hadoop-hdfs in the patch failed with JDK v1.7.0_131.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        117m 5s



        Reason Tests
        JDK v1.8.0_131 Failed junit tests hadoop.hdfs.web.TestHttpsFileSystem
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
        JDK v1.7.0_131 Failed junit tests hadoop.hdfs.TestDFSShell
          hadoop.hdfs.server.namenode.TestCacheDirectives
          hadoop.hdfs.web.TestHttpsFileSystem
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:67e87c9
        JIRA Issue HDFS-11736
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872832/HDFS-11736-branch-2.7.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f84b7b11515e 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / 11e6c96
        Default Java 1.7.0_131
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19892/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19892/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19892/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt
        JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19892/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19892/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 1s branch-2.7 passed +1 compile 1m 1s branch-2.7 passed with JDK v1.8.0_131 +1 compile 1m 0s branch-2.7 passed with JDK v1.7.0_131 +1 checkstyle 0m 23s branch-2.7 passed +1 mvnsite 0m 59s branch-2.7 passed +1 findbugs 2m 53s branch-2.7 passed +1 javadoc 0m 58s branch-2.7 passed with JDK v1.8.0_131 +1 javadoc 1m 43s branch-2.7 passed with JDK v1.7.0_131 +1 mvninstall 0m 53s the patch passed +1 compile 0m 56s the patch passed with JDK v1.8.0_131 +1 javac 0m 56s the patch passed +1 compile 0m 57s the patch passed with JDK v1.7.0_131 +1 javac 0m 57s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 56s the patch passed -1 whitespace 0m 0s The patch has 2123 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 55s The patch 70 line(s) with tabs. +1 findbugs 3m 5s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_131 +1 javadoc 1m 39s the patch passed with JDK v1.7.0_131 -1 unit 42m 56s hadoop-hdfs in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 117m 5s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.hdfs.web.TestHttpsFileSystem   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots JDK v1.7.0_131 Failed junit tests hadoop.hdfs.TestDFSShell   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.web.TestHttpsFileSystem   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots Subsystem Report/Notes Docker Image:yetus/hadoop:67e87c9 JIRA Issue HDFS-11736 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872832/HDFS-11736-branch-2.7.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f84b7b11515e 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 11e6c96 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19892/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19892/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19892/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19892/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19892/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka, attach the new patch to fix checkstyle warnings.
        .

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka , attach the new patch to fix checkstyle warnings. .
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Would you remove unused imports to fix checkstyle warnings? I'm +1 if that is addressed.

        Show
        ajisakaa Akira Ajisaka added a comment - Would you remove unused imports to fix checkstyle warnings? I'm +1 if that is addressed.
        Hide
        linyiqun Yiqun Lin added a comment - - edited

        The failed tests are not related. Akira Ajisaka, can you take an additional review on the latest patch of trunk and branch-2.7? Will fix checkstyle issues while committing. Thanks in advance.

        Show
        linyiqun Yiqun Lin added a comment - - edited The failed tests are not related. Akira Ajisaka , can you take an additional review on the latest patch of trunk and branch-2.7? Will fix checkstyle issues while committing. Thanks in advance.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 35s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 16s branch-2.7 passed
        +1 compile 1m 4s branch-2.7 passed with JDK v1.8.0_131
        +1 compile 1m 2s branch-2.7 passed with JDK v1.7.0_131
        +1 checkstyle 0m 23s branch-2.7 passed
        +1 mvnsite 0m 57s branch-2.7 passed
        +1 findbugs 2m 58s branch-2.7 passed
        +1 javadoc 1m 0s branch-2.7 passed with JDK v1.8.0_131
        +1 javadoc 1m 49s branch-2.7 passed with JDK v1.7.0_131
        +1 mvninstall 0m 54s the patch passed
        +1 compile 1m 0s the patch passed with JDK v1.8.0_131
        +1 javac 1m 0s the patch passed
        +1 compile 1m 2s the patch passed with JDK v1.7.0_131
        +1 javac 1m 2s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 58s the patch passed
        -1 whitespace 0m 0s The patch has 1552 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        -1 whitespace 0m 38s The patch 70 line(s) with tabs.
        +1 findbugs 3m 10s the patch passed
        +1 javadoc 0m 57s the patch passed with JDK v1.8.0_131
        +1 javadoc 1m 42s the patch passed with JDK v1.7.0_131
        -1 unit 55m 17s hadoop-hdfs in the patch failed with JDK v1.7.0_131.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        139m 28s



        Reason Tests
        JDK v1.8.0_131 Failed junit tests hadoop.hdfs.server.blockmanagement.TestNodeCount
          hadoop.hdfs.TestDatanodeRegistration
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
        JDK v1.7.0_131 Failed junit tests hadoop.hdfs.server.blockmanagement.TestNodeCount
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:67e87c9
        JIRA Issue HDFS-11736
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872685/HDFS-11736-branch-2.7.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1280e7499999 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / b6f3e1a
        Default Java 1.7.0_131
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19878/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19878/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19878/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt
        JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19878/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19878/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 35s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 16s branch-2.7 passed +1 compile 1m 4s branch-2.7 passed with JDK v1.8.0_131 +1 compile 1m 2s branch-2.7 passed with JDK v1.7.0_131 +1 checkstyle 0m 23s branch-2.7 passed +1 mvnsite 0m 57s branch-2.7 passed +1 findbugs 2m 58s branch-2.7 passed +1 javadoc 1m 0s branch-2.7 passed with JDK v1.8.0_131 +1 javadoc 1m 49s branch-2.7 passed with JDK v1.7.0_131 +1 mvninstall 0m 54s the patch passed +1 compile 1m 0s the patch passed with JDK v1.8.0_131 +1 javac 1m 0s the patch passed +1 compile 1m 2s the patch passed with JDK v1.7.0_131 +1 javac 1m 2s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 58s the patch passed -1 whitespace 0m 0s The patch has 1552 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 38s The patch 70 line(s) with tabs. +1 findbugs 3m 10s the patch passed +1 javadoc 0m 57s the patch passed with JDK v1.8.0_131 +1 javadoc 1m 42s the patch passed with JDK v1.7.0_131 -1 unit 55m 17s hadoop-hdfs in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 139m 28s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.TestDatanodeRegistration   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots JDK v1.7.0_131 Failed junit tests hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles Subsystem Report/Notes Docker Image:yetus/hadoop:67e87c9 JIRA Issue HDFS-11736 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872685/HDFS-11736-branch-2.7.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1280e7499999 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / b6f3e1a Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19878/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19878/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19878/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19878/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19878/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 12m 49s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 0m 50s trunk passed
        +1 findbugs 1m 30s trunk passed
        +1 javadoc 0m 40s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        -0 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 133 unchanged - 0 fixed = 136 total (was 133)
        +1 mvnsite 0m 45s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 38s the patch passed
        +1 javadoc 0m 37s the patch passed
        -1 unit 62m 58s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        86m 52s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
          hadoop.hdfs.web.TestWebHdfsTimeouts



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11736
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872684/HDFS-11736.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1a8ba954e5ae 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e86eef9
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19877/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19877/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19877/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19877/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 12m 49s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 0m 50s trunk passed +1 findbugs 1m 30s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 133 unchanged - 0 fixed = 136 total (was 133) +1 mvnsite 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 38s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 62m 58s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 86m 52s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy   hadoop.hdfs.web.TestWebHdfsTimeouts Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11736 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872684/HDFS-11736.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1a8ba954e5ae 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e86eef9 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19877/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19877/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19877/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19877/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Attach the patch for branch-2.7.

        Show
        linyiqun Yiqun Lin added a comment - Attach the patch for branch-2.7.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for your review. I found one failure test TestStandbyCheckpoints is related. The root cause of this is that the OivImgDir doesn't be deleted after each test methods.
        Attach the new patch to address this. Found one difference in branch-2.7, the method GenericTestUtils#getTempDir doesn't exist. And there are only two places using Files.createTempDir(). Will attach the patch for branch-2.7 soon.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for your review. I found one failure test TestStandbyCheckpoints is related. The root cause of this is that the OivImgDir doesn't be deleted after each test methods. Attach the new patch to address this. Found one difference in branch-2.7, the method GenericTestUtils#getTempDir doesn't exist. And there are only two places using Files.createTempDir() . Will attach the patch for branch-2.7 soon.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 16m 17s trunk passed
        +1 compile 0m 50s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 0m 40s trunk passed
        +1 mvninstall 0m 52s the patch passed
        +1 compile 0m 48s the patch passed
        +1 javac 0m 48s the patch passed
        -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 133 unchanged - 0 fixed = 136 total (was 133)
        +1 mvnsite 0m 49s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 44s the patch passed
        +1 javadoc 0m 37s the patch passed
        -1 unit 89m 11s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 25s The patch does not generate ASF License warnings.
        118m 3s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11736
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872098/HDFS-11736.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 27b95c27e124 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5672ae7
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19837/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19837/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19837/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19837/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 16m 17s trunk passed +1 compile 0m 50s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 0m 56s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 52s the patch passed +1 compile 0m 48s the patch passed +1 javac 0m 48s the patch passed -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 133 unchanged - 0 fixed = 136 total (was 133) +1 mvnsite 0m 49s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 89m 11s hadoop-hdfs in the patch failed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 118m 3s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11736 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872098/HDFS-11736.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 27b95c27e124 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5672ae7 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19837/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19837/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19837/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19837/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Update target versions since this problem also exists in other branches and should be fixed as well.

        Show
        linyiqun Yiqun Lin added a comment - Update target versions since this problem also exists in other branches and should be fixed as well.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Konstantin Shvachko for reporting this. Good catch.
        It will be nice to fix in 2.7.4. Attach the patch, kindly review.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Konstantin Shvachko for reporting this. Good catch. It will be nice to fix in 2.7.4. Attach the patch, kindly review.
        Hide
        shv Konstantin Shvachko added a comment -

        We should instead use something based on GenericTestUtils.getTestDir() or GenericTestUtils.getRandomizedTestDir().
        For OIV directory in particular we can simply create a directory inside NameNode directory, where it actually belongs. MiniDFSCluster.getNameNodeDirectory() is based on getTestDir() already.

        Show
        shv Konstantin Shvachko added a comment - We should instead use something based on GenericTestUtils.getTestDir() or GenericTestUtils.getRandomizedTestDir() . For OIV directory in particular we can simply create a directory inside NameNode directory, where it actually belongs. MiniDFSCluster.getNameNodeDirectory() is based on getTestDir() already.

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            shv Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development