Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11696

Fix warnings from Spotbugs in hadoop-hdfs

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are totally 12 findbugs issues generated after switching from Findbugs to Spotbugs across the project in HADOOP-14316. This JIRA focus on cleaning up the part of warnings under scope of HDFS(mainly contained in hadoop-hdfs and hadoop-hdfs-client).

      1. HADOOP-14337.001.patch
        10 kB
        Yiqun Lin
      2. HADOOP-14337.002.patch
        10 kB
        Yiqun Lin
      3. HADOOP-14337.003.patch
        10 kB
        Yiqun Lin
      4. findbugsHtml.html
        7 kB
        Akira Ajisaka
      5. HDFS-11696.004.patch
        12 kB
        Yiqun Lin
      6. HDFS-11696.005.patch
        10 kB
        Yiqun Lin
      7. HDFS-11696.006.patch
        12 kB
        Yiqun Lin
      8. HDFS-11696.007.patch
        11 kB
        Yiqun Lin
      9. HDFS-11696.008.patch
        10 kB
        Yiqun Lin
      10. HDFS-11696.009.patch
        12 kB
        Yiqun Lin
      11. HDFS-11696.010.patch
        12 kB
        Yiqun Lin

        Issue Links

          Activity

          Hide
          linyiqun Yiqun Lin added a comment -

          Attach the initial patch. Kindly review.

          Show
          linyiqun Yiqun Lin added a comment - Attach the initial patch. Kindly review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 6s Maven dependency ordering for branch
          +1 mvninstall 13m 58s trunk passed
          +1 compile 1m 42s trunk passed
          +1 checkstyle 0m 47s trunk passed
          +1 mvnsite 1m 36s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          -1 findbugs 1m 29s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 49s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 1m 4s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 29s the patch passed
          +1 compile 1m 32s the patch passed
          +1 javac 1m 32s the patch passed
          +1 checkstyle 0m 44s hadoop-hdfs-project: The patch generated 0 new + 355 unchanged - 2 fixed = 355 total (was 357)
          +1 mvnsite 1m 30s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 40s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          -1 findbugs 2m 2s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 3 unchanged - 7 fixed = 4 total (was 10)
          +1 javadoc 1m 0s the patch passed
          +1 unit 1m 13s hadoop-hdfs-client in the patch passed.
          -1 unit 67m 21s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          106m 13s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs
            Null passed for non-null parameter of java.nio.file.Files.isRegularFile(Path, LinkOption[]) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java:of java.nio.file.Files.isRegularFile(Path, LinkOption[]) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java:[line 138]
          Failed junit tests hadoop.hdfs.TestDFSRollback
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestFileAppendRestart
            hadoop.hdfs.TestDFSUpgrade
            hadoop.hdfs.server.namenode.TestFSImage
            hadoop.hdfs.TestDatanodeLayoutUpgrade
            hadoop.hdfs.server.namenode.TestStartupOptionUpgrade
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.namenode.TestNameNodeOptionParsing
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.TestPersistBlocks



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue HADOOP-14337
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864423/HADOOP-14337.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0cdf40407025 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 667966c
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 6s Maven dependency ordering for branch +1 mvninstall 13m 58s trunk passed +1 compile 1m 42s trunk passed +1 checkstyle 0m 47s trunk passed +1 mvnsite 1m 36s trunk passed +1 mvneclipse 0m 29s trunk passed -1 findbugs 1m 29s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 49s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 4s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 29s the patch passed +1 compile 1m 32s the patch passed +1 javac 1m 32s the patch passed +1 checkstyle 0m 44s hadoop-hdfs-project: The patch generated 0 new + 355 unchanged - 2 fixed = 355 total (was 357) +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 40s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) -1 findbugs 2m 2s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 3 unchanged - 7 fixed = 4 total (was 10) +1 javadoc 1m 0s the patch passed +1 unit 1m 13s hadoop-hdfs-client in the patch passed. -1 unit 67m 21s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 106m 13s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Null passed for non-null parameter of java.nio.file.Files.isRegularFile(Path, LinkOption[]) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java:of java.nio.file.Files.isRegularFile(Path, LinkOption[]) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java: [line 138] Failed junit tests hadoop.hdfs.TestDFSRollback   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestFileAppendRestart   hadoop.hdfs.TestDFSUpgrade   hadoop.hdfs.server.namenode.TestFSImage   hadoop.hdfs.TestDatanodeLayoutUpgrade   hadoop.hdfs.server.namenode.TestStartupOptionUpgrade   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.namenode.TestNameNodeOptionParsing   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.TestPersistBlocks Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue HADOOP-14337 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864423/HADOOP-14337.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0cdf40407025 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 667966c Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12144/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment -

          Attach the new patch to fix remaining findbugs issues.

          Show
          linyiqun Yiqun Lin added a comment - Attach the new patch to fix remaining findbugs issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 23s Maven dependency ordering for branch
          +1 mvninstall 14m 55s trunk passed
          +1 compile 1m 53s trunk passed
          +1 checkstyle 0m 47s trunk passed
          +1 mvnsite 1m 44s trunk passed
          +1 mvneclipse 0m 30s trunk passed
          -1 findbugs 1m 27s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 40s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 1m 3s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 22s the patch passed
          +1 compile 1m 25s the patch passed
          +1 javac 1m 25s the patch passed
          +1 checkstyle 0m 43s hadoop-hdfs-project: The patch generated 0 new + 356 unchanged - 2 fixed = 356 total (was 358)
          +1 mvnsite 1m 21s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 28s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          -1 findbugs 1m 47s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 3 unchanged - 7 fixed = 4 total (was 10)
          +1 javadoc 0m 58s the patch passed
          +1 unit 1m 12s hadoop-hdfs-client in the patch passed.
          -1 unit 69m 22s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          108m 38s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs
            Null passed for non-null parameter of java.nio.file.SimpleFileVisitor.visitFile(Object, BasicFileAttributes) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java:of java.nio.file.SimpleFileVisitor.visitFile(Object, BasicFileAttributes) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java:[line 144]
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.server.namenode.TestStartupOptionUpgrade
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue HADOOP-14337
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864438/HADOOP-14337.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 96d85d358cc2 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b080338
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 23s Maven dependency ordering for branch +1 mvninstall 14m 55s trunk passed +1 compile 1m 53s trunk passed +1 checkstyle 0m 47s trunk passed +1 mvnsite 1m 44s trunk passed +1 mvneclipse 0m 30s trunk passed -1 findbugs 1m 27s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 40s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 3s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 1m 25s the patch passed +1 javac 1m 25s the patch passed +1 checkstyle 0m 43s hadoop-hdfs-project: The patch generated 0 new + 356 unchanged - 2 fixed = 356 total (was 358) +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 28s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) -1 findbugs 1m 47s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 3 unchanged - 7 fixed = 4 total (was 10) +1 javadoc 0m 58s the patch passed +1 unit 1m 12s hadoop-hdfs-client in the patch passed. -1 unit 69m 22s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 108m 38s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Null passed for non-null parameter of java.nio.file.SimpleFileVisitor.visitFile(Object, BasicFileAttributes) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java:of java.nio.file.SimpleFileVisitor.visitFile(Object, BasicFileAttributes) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java: [line 144] Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.namenode.TestStartupOptionUpgrade   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue HADOOP-14337 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864438/HADOOP-14337.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 96d85d358cc2 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b080338 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12145/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment -

          Attach the new patch to fix the remaining failure tests.

          Show
          linyiqun Yiqun Lin added a comment - Attach the new patch to fix the remaining failure tests.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 15m 7s trunk passed
          +1 compile 1m 48s trunk passed
          +1 checkstyle 0m 47s trunk passed
          +1 mvnsite 1m 44s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          -1 findbugs 1m 20s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 1m 0s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 20s the patch passed
          +1 compile 1m 26s the patch passed
          +1 javac 1m 26s the patch passed
          +1 checkstyle 0m 43s hadoop-hdfs-project: The patch generated 0 new + 356 unchanged - 2 fixed = 356 total (was 358)
          +1 mvnsite 1m 29s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 36s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 findbugs 1m 51s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 3 unchanged - 7 fixed = 3 total (was 10)
          +1 javadoc 1m 1s the patch passed
          +1 unit 1m 15s hadoop-hdfs-client in the patch passed.
          -1 unit 68m 33s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          108m 10s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue HADOOP-14337
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864456/HADOOP-14337.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6f26d55fcfad 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b080338
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12147/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12147/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12147/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12147/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12147/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 15m 7s trunk passed +1 compile 1m 48s trunk passed +1 checkstyle 0m 47s trunk passed +1 mvnsite 1m 44s trunk passed +1 mvneclipse 0m 29s trunk passed -1 findbugs 1m 20s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 0s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 20s the patch passed +1 compile 1m 26s the patch passed +1 javac 1m 26s the patch passed +1 checkstyle 0m 43s hadoop-hdfs-project: The patch generated 0 new + 356 unchanged - 2 fixed = 356 total (was 358) +1 mvnsite 1m 29s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 36s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 findbugs 1m 51s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 3 unchanged - 7 fixed = 3 total (was 10) +1 javadoc 1m 1s the patch passed +1 unit 1m 15s hadoop-hdfs-client in the patch passed. -1 unit 68m 33s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 108m 10s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue HADOOP-14337 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864456/HADOOP-14337.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6f26d55fcfad 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b080338 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12147/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12147/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12147/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12147/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12147/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment - - edited

          Hi Akira Ajisaka, would you mind have a review on this? BTW, I am a little confused that I have fixed all the findbugs issues under the HDFS but the Jenkins still told me there were 3 warnings remained, .
          Thanks.

          Show
          linyiqun Yiqun Lin added a comment - - edited Hi Akira Ajisaka , would you mind have a review on this? BTW, I am a little confused that I have fixed all the findbugs issues under the HDFS but the Jenkins still told me there were 3 warnings remained, . Thanks.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hi Yiqun Lin

          I have same confusion, seems like the jenkins job somehow generates 2 findbugs report, first one seems is before the patch, latter one is after the patch:

          hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          

          then

          hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          hadoop-hdfs-project/hadoop-hdfs generated 0 new + 3 unchanged - 7 fixed = 3 total (was 10)
          

          BTW, the last line says 3 unchanged, does that mean there is still 3 warnings unfixed in hadoop-hdfs-project/hadoop-hdfs?

          Show
          cheersyang Weiwei Yang added a comment - Hi Yiqun Lin I have same confusion, seems like the jenkins job somehow generates 2 findbugs report, first one seems is before the patch, latter one is after the patch: hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. then hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) hadoop-hdfs-project/hadoop-hdfs generated 0 new + 3 unchanged - 7 fixed = 3 total (was 10) BTW, the last line says 3 unchanged, does that mean there is still 3 warnings unfixed in hadoop-hdfs-project/hadoop-hdfs?
          Hide
          linyiqun Yiqun Lin added a comment - - edited

          BTW, the last line says 3 unchanged, does that mean there is still 3 warnings unfixed in hadoop-hdfs-project/hadoop-hdfs?

          From my understanding of this, that should be this meaning. But I think this is not correct, .

          Show
          linyiqun Yiqun Lin added a comment - - edited BTW, the last line says 3 unchanged, does that mean there is still 3 warnings unfixed in hadoop-hdfs-project/hadoop-hdfs? From my understanding of this, that should be this meaning. But I think this is not correct, .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          does that mean there is still 3 warnings unfixed in hadoop-hdfs-project/hadoop-hdfs?

          Yes. I ran findbugs:findbugs and found 3 warnings after applying the patch. Attaching the report.

          Show
          ajisakaa Akira Ajisaka added a comment - does that mean there is still 3 warnings unfixed in hadoop-hdfs-project/hadoop-hdfs? Yes. I ran findbugs:findbugs and found 3 warnings after applying the patch. Attaching the report.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 7s Maven dependency ordering for branch
          +1 mvninstall 14m 35s trunk passed
          +1 compile 1m 48s trunk passed
          +1 checkstyle 0m 49s trunk passed
          +1 mvnsite 1m 40s trunk passed
          +1 mvneclipse 0m 32s trunk passed
          -1 findbugs 1m 29s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 46s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 1m 15s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 35s the patch passed
          +1 compile 1m 40s the patch passed
          +1 javac 1m 40s the patch passed
          +1 checkstyle 0m 47s hadoop-hdfs-project: The patch generated 0 new + 353 unchanged - 2 fixed = 353 total (was 355)
          +1 mvnsite 1m 33s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 35s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 findbugs 1m 58s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 3 unchanged - 7 fixed = 3 total (was 10)
          +1 javadoc 1m 2s the patch passed
          +1 unit 1m 18s hadoop-hdfs-client in the patch passed.
          -1 unit 93m 57s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          132m 23s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.datanode.TestDataNodeMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11696
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864456/HADOOP-14337.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b890694aa536 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ad1e3e4
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19387/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19387/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19387/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19387/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19387/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 14m 35s trunk passed +1 compile 1m 48s trunk passed +1 checkstyle 0m 49s trunk passed +1 mvnsite 1m 40s trunk passed +1 mvneclipse 0m 32s trunk passed -1 findbugs 1m 29s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 46s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 15s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 35s the patch passed +1 compile 1m 40s the patch passed +1 javac 1m 40s the patch passed +1 checkstyle 0m 47s hadoop-hdfs-project: The patch generated 0 new + 353 unchanged - 2 fixed = 353 total (was 355) +1 mvnsite 1m 33s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 35s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 findbugs 1m 58s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 3 unchanged - 7 fixed = 3 total (was 10) +1 javadoc 1m 2s the patch passed +1 unit 1m 18s hadoop-hdfs-client in the patch passed. -1 unit 93m 57s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 132m 23s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.TestDataNodeMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11696 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864456/HADOOP-14337.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b890694aa536 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ad1e3e4 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19387/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19387/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19387/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19387/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19387/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment - - edited

          Akira Ajisaka, thanks for providing the findbugs report!
          Attach the new patch to fix remained findbugs issues.

          Show
          linyiqun Yiqun Lin added a comment - - edited Akira Ajisaka , thanks for providing the findbugs report! Attach the new patch to fix remained findbugs issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 29s Maven dependency ordering for branch
          +1 mvninstall 13m 30s trunk passed
          +1 compile 1m 23s trunk passed
          +1 checkstyle 0m 45s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          -1 findbugs 1m 23s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 1m 2s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 19s the patch passed
          +1 compile 1m 22s the patch passed
          +1 javac 1m 22s the patch passed
          +1 checkstyle 0m 41s hadoop-hdfs-project: The patch generated 0 new + 353 unchanged - 2 fixed = 353 total (was 355)
          +1 mvnsite 1m 21s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 27s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 1 unchanged - 9 fixed = 2 total (was 10)
          +1 javadoc 0m 56s the patch passed
          +1 unit 1m 10s hadoop-hdfs-client in the patch passed.
          -1 unit 64m 26s hadoop-hdfs in the patch failed.
          -1 asflicense 0m 20s The patch generated 1 ASF License warnings.
          99m 3s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs
            Null passed for non-null parameter of java.nio.file.SimpleFileVisitor.visitFile(Object, BasicFileAttributes) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java:of java.nio.file.SimpleFileVisitor.visitFile(Object, BasicFileAttributes) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java:[line 146]
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
            hadoop.hdfs.server.balancer.TestBalancer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11696
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867491/HDFS-11696.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 055ef74ddb61 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eed7314
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19394/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19394/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19394/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19394/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19394/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/19394/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19394/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 13m 30s trunk passed +1 compile 1m 23s trunk passed +1 checkstyle 0m 45s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 28s trunk passed -1 findbugs 1m 23s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 2s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 19s the patch passed +1 compile 1m 22s the patch passed +1 javac 1m 22s the patch passed +1 checkstyle 0m 41s hadoop-hdfs-project: The patch generated 0 new + 353 unchanged - 2 fixed = 353 total (was 355) +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 1 unchanged - 9 fixed = 2 total (was 10) +1 javadoc 0m 56s the patch passed +1 unit 1m 10s hadoop-hdfs-client in the patch passed. -1 unit 64m 26s hadoop-hdfs in the patch failed. -1 asflicense 0m 20s The patch generated 1 ASF License warnings. 99m 3s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Null passed for non-null parameter of java.nio.file.SimpleFileVisitor.visitFile(Object, BasicFileAttributes) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java:of java.nio.file.SimpleFileVisitor.visitFile(Object, BasicFileAttributes) in org.apache.hadoop.hdfs.server.namenode.NNUpgradeUtil$1.visitFile(Path, BasicFileAttributes) Method invoked at NNUpgradeUtil.java: [line 146] Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.balancer.TestBalancer Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11696 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867491/HDFS-11696.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 055ef74ddb61 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eed7314 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19394/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19394/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19394/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19394/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19394/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/19394/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19394/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment -

          Attach the updated patch to fix the new generated warnings.
          One note:
          In the line super.visitFile(file, attrs); in NNUpgradeUtil#doPreUpgrade, If input file is null, it will throw NPE inside. In order to fix findbus issue, I do this outside to keep the consistent logic.

          Show
          linyiqun Yiqun Lin added a comment - Attach the updated patch to fix the new generated warnings. One note: In the line super.visitFile(file, attrs); in NNUpgradeUtil#doPreUpgrade , If input file is null, it will throw NPE inside. In order to fix findbus issue, I do this outside to keep the consistent logic.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 14m 5s trunk passed
          +1 compile 0m 52s trunk passed
          +1 checkstyle 0m 41s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          -1 findbugs 1m 47s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 0m 44s trunk passed
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 49s the patch passed
          +1 javac 0m 49s the patch passed
          +1 checkstyle 0m 36s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 304 unchanged - 2 fixed = 304 total (was 306)
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 49s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)
          +1 javadoc 0m 39s the patch passed
          -1 unit 69m 10s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          96m 41s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestMaintenanceState
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            hadoop.hdfs.TestDFSClientRetries
            hadoop.hdfs.TestDFSRSDefault10x4StripedOutputStreamWithFailure
            hadoop.hdfs.server.blockmanagement.TestBlockManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11696
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867535/HDFS-11696.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dbb58ea3790d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 51b671e
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19399/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19399/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19399/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19399/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 5s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 15s trunk passed -1 findbugs 1m 47s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 49s the patch passed +1 javac 0m 49s the patch passed +1 checkstyle 0m 36s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 304 unchanged - 2 fixed = 304 total (was 306) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10) +1 javadoc 0m 39s the patch passed -1 unit 69m 10s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 96m 41s Reason Tests Failed junit tests hadoop.hdfs.TestMaintenanceState   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.TestDFSRSDefault10x4StripedOutputStreamWithFailure   hadoop.hdfs.server.blockmanagement.TestBlockManager Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11696 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867535/HDFS-11696.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dbb58ea3790d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 51b671e Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19399/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19399/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19399/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19399/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment -

          The v05 patch missing the fix under hdfs-client, reupload the patch.

          Show
          linyiqun Yiqun Lin added a comment - The v05 patch missing the fix under hdfs-client, reupload the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 14m 48s trunk passed
          +1 compile 1m 45s trunk passed
          +1 checkstyle 0m 47s trunk passed
          +1 mvnsite 1m 39s trunk passed
          +1 mvneclipse 0m 34s trunk passed
          -1 findbugs 1m 44s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 2m 1s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 1m 7s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 27s the patch passed
          +1 compile 1m 33s the patch passed
          +1 javac 1m 33s the patch passed
          +1 checkstyle 0m 43s hadoop-hdfs-project: The patch generated 0 new + 353 unchanged - 2 fixed = 353 total (was 355)
          +1 mvnsite 1m 29s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 42s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 findbugs 2m 1s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)
          +1 javadoc 1m 1s the patch passed
          +1 unit 1m 21s hadoop-hdfs-client in the patch passed.
          -1 unit 68m 47s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          108m 10s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11696
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867555/HDFS-11696.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ea9740481c6f 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 51b671e
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19400/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19400/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19400/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19400/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19400/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 14m 48s trunk passed +1 compile 1m 45s trunk passed +1 checkstyle 0m 47s trunk passed +1 mvnsite 1m 39s trunk passed +1 mvneclipse 0m 34s trunk passed -1 findbugs 1m 44s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 2m 1s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 7s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 1m 33s the patch passed +1 javac 1m 33s the patch passed +1 checkstyle 0m 43s hadoop-hdfs-project: The patch generated 0 new + 353 unchanged - 2 fixed = 353 total (was 355) +1 mvnsite 1m 29s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 42s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 findbugs 2m 1s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10) +1 javadoc 1m 1s the patch passed +1 unit 1m 21s hadoop-hdfs-client in the patch passed. -1 unit 68m 47s hadoop-hdfs in the patch failed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 108m 10s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11696 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867555/HDFS-11696.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ea9740481c6f 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 51b671e Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19400/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19400/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19400/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19400/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19400/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for updating the patch, Yiqun Lin. Can we just ignore the warnings in NNUpgradeUtil.java by adding a section in findbugs-exclude.xml? The method throws NPE even after the fix when the input variable is null.

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for updating the patch, Yiqun Lin . Can we just ignore the warnings in NNUpgradeUtil.java by adding a section in findbugs-exclude.xml? The method throws NPE even after the fix when the input variable is null.
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks for the review, Akira Ajisaka. Agree on your comment.
          Attach the new patch.

          Show
          linyiqun Yiqun Lin added a comment - Thanks for the review, Akira Ajisaka . Agree on your comment. Attach the new patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 28s Maven dependency ordering for branch
          +1 mvninstall 13m 49s trunk passed
          +1 compile 1m 26s trunk passed
          +1 checkstyle 0m 46s trunk passed
          +1 mvnsite 1m 27s trunk passed
          +1 mvneclipse 0m 30s trunk passed
          -1 findbugs 1m 23s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 38s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 1m 2s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 20s the patch passed
          +1 compile 1m 25s the patch passed
          +1 javac 1m 25s the patch passed
          +1 checkstyle 0m 44s hadoop-hdfs-project: The patch generated 0 new + 352 unchanged - 2 fixed = 352 total (was 354)
          +1 mvnsite 1m 25s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 37s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 findbugs 1m 57s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)
          +1 javadoc 1m 3s the patch passed
          +1 unit 1m 19s hadoop-hdfs-client in the patch passed.
          -1 unit 69m 17s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          105m 21s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11696
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868008/HDFS-11696.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux ef7abce6bb35 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6600abb
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19431/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19431/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19431/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19431/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19431/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 13m 49s trunk passed +1 compile 1m 26s trunk passed +1 checkstyle 0m 46s trunk passed +1 mvnsite 1m 27s trunk passed +1 mvneclipse 0m 30s trunk passed -1 findbugs 1m 23s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 38s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 2s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 20s the patch passed +1 compile 1m 25s the patch passed +1 javac 1m 25s the patch passed +1 checkstyle 0m 44s hadoop-hdfs-project: The patch generated 0 new + 352 unchanged - 2 fixed = 352 total (was 354) +1 mvnsite 1m 25s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 37s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 findbugs 1m 57s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10) +1 javadoc 1m 3s the patch passed +1 unit 1m 19s hadoop-hdfs-client in the patch passed. -1 unit 69m 17s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 105m 21s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11696 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868008/HDFS-11696.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux ef7abce6bb35 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6600abb Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19431/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19431/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19431/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19431/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19431/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, LGTM

          Show
          ajisakaa Akira Ajisaka added a comment - +1, LGTM
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks Yiqun Lin for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Yiqun Lin for the contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11737 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11737/)
          HDFS-11696. Fix warnings from Spotbugs in hadoop-hdfs. Contributed by (aajisaka: rev 89a8edc0149e3f31a5ade9a0927c4b6332cf6b1a)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/protocol/SlowDiskReports.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11737 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11737/ ) HDFS-11696 . Fix warnings from Spotbugs in hadoop-hdfs. Contributed by (aajisaka: rev 89a8edc0149e3f31a5ade9a0927c4b6332cf6b1a) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/protocol/SlowDiskReports.java (edit) hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Akira Ajisaka for the review and commit!

          Show
          linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for the review and commit!
          Hide
          andrew.wang Andrew Wang added a comment -

          This JIRA caused a regression, since it makes "hdfs namenode -nonInteractive" also require "-force". Looking at the documentation, force is not required:

          https://hadoop.apache.org/docs/r2.7.2/hadoop-project-dist/hadoop-hdfs/HDFSCommands.html

          I'm going to revert this change so we can revisit this.

          Show
          andrew.wang Andrew Wang added a comment - This JIRA caused a regression, since it makes "hdfs namenode -nonInteractive" also require "-force". Looking at the documentation, force is not required: https://hadoop.apache.org/docs/r2.7.2/hadoop-project-dist/hadoop-hdfs/HDFSCommands.html I'm going to revert this change so we can revisit this.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11954 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11954/)
          Revert "HDFS-11696. Fix warnings from Spotbugs in hadoop-hdfs. (wang: rev 441378e7e4609d89b7181dacc8ba92b253a962df)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/protocol/SlowDiskReports.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11954 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11954/ ) Revert " HDFS-11696 . Fix warnings from Spotbugs in hadoop-hdfs. (wang: rev 441378e7e4609d89b7181dacc8ba92b253a962df) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/protocol/SlowDiskReports.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java (edit) hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java
          Hide
          linyiqun Yiqun Lin added a comment -

          Hi Andrew Wang, could you please explain more info of the above problem? The option -nonInteractive and -force is used under the option -format, so I did a simple checking for the format state in following codes:

               public void setForceFormat(boolean force) {
          +      Preconditions.checkState(this == FORMAT);
                 isForceFormat = force;
               }
               
          @@ -234,6 +238,7 @@ public boolean getInteractiveFormat() {
               }
               
               public void setInteractiveFormat(boolean interactive) {
          +      Preconditions.checkState(this == FORMAT);
                 isInteractiveFormat = interactive;
               }
          

          From my understanding on this, this change will still make current options run okay, right?
          Is there some corner cases that I am missing? Please let me know if I am not correct. Thanks,

          Show
          linyiqun Yiqun Lin added a comment - Hi Andrew Wang , could you please explain more info of the above problem? The option -nonInteractive and -force is used under the option -format , so I did a simple checking for the format state in following codes: public void setForceFormat( boolean force) { + Preconditions.checkState( this == FORMAT); isForceFormat = force; } @@ -234,6 +238,7 @@ public boolean getInteractiveFormat() { } public void setInteractiveFormat( boolean interactive) { + Preconditions.checkState( this == FORMAT); isInteractiveFormat = interactive; } From my understanding on this, this change will still make current options run okay, right? Is there some corner cases that I am missing? Please let me know if I am not correct. Thanks,
          Hide
          andrew.wang Andrew Wang added a comment -

          Sorry, I read the patch incorrectly before. There's still a behavior change with this patch though. Previously, we did not throw an error when sub-flags are specified without their parent. This is not documented to work, but we have an init script that does this so there are probably others out there that will hit this same issue.

          Is there a way to address the spotbugs issues without changing the option parsing behavior?

          Show
          andrew.wang Andrew Wang added a comment - Sorry, I read the patch incorrectly before. There's still a behavior change with this patch though. Previously, we did not throw an error when sub-flags are specified without their parent. This is not documented to work, but we have an init script that does this so there are probably others out there that will hit this same issue. Is there a way to address the spotbugs issues without changing the option parsing behavior?
          Hide
          linyiqun Yiqun Lin added a comment - - edited

          Is there a way to address the spotbugs issues without changing the option parsing behavior?

          I think we can just add some new entries in findbug exclude file to ignore these warnings.
          Attach the new patch. Andrew Wang, please have a check. Thanks.

          Show
          linyiqun Yiqun Lin added a comment - - edited Is there a way to address the spotbugs issues without changing the option parsing behavior? I think we can just add some new entries in findbug exclude file to ignore these warnings. Attach the new patch. Andrew Wang , please have a check. Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 7s Maven dependency ordering for branch
          +1 mvninstall 13m 7s trunk passed
          +1 compile 1m 24s trunk passed
          +1 checkstyle 0m 43s trunk passed
          +1 mvnsite 1m 27s trunk passed
          -1 findbugs 1m 23s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 38s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 1m 1s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 18s the patch passed
          +1 compile 1m 23s the patch passed
          +1 javac 1m 23s the patch passed
          +1 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 0 new + 318 unchanged - 2 fixed = 318 total (was 320)
          +1 mvnsite 1m 21s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 1m 28s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)
          +1 javadoc 0m 56s the patch passed
          +1 unit 1m 10s hadoop-hdfs-client in the patch passed.
          -1 unit 70m 33s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          103m 26s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11696
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875917/HDFS-11696.008.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 70ef8ba8d94b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 946dd25
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20175/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20175/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20175/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20175/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20175/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 13m 7s trunk passed +1 compile 1m 24s trunk passed +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 27s trunk passed -1 findbugs 1m 23s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 38s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 1s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 18s the patch passed +1 compile 1m 23s the patch passed +1 javac 1m 23s the patch passed +1 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 0 new + 318 unchanged - 2 fixed = 318 total (was 320) +1 mvnsite 1m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 1m 28s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10) +1 javadoc 0m 56s the patch passed +1 unit 1m 10s hadoop-hdfs-client in the patch passed. -1 unit 70m 33s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 103m 26s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11696 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875917/HDFS-11696.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 70ef8ba8d94b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 946dd25 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20175/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20175/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20175/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20175/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20175/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Looks good, thanks Yiqun, do you mind also adding a regression test for the flags behavior? 1 pending that.

          Show
          andrew.wang Andrew Wang added a comment - Looks good, thanks Yiqun, do you mind also adding a regression test for the flags behavior? 1 pending that.
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Andrew Wang for the review.
          Add the unit test for the -format option parsing to ensure the sub option -nonInteractive , -force can be parsed as expected.

          Show
          linyiqun Yiqun Lin added a comment - Thanks Andrew Wang for the review. Add the unit test for the -format option parsing to ensure the sub option -nonInteractive , -force can be parsed as expected.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 23s Maven dependency ordering for branch
          +1 mvninstall 13m 10s trunk passed
          +1 compile 1m 25s trunk passed
          +1 checkstyle 0m 43s trunk passed
          +1 mvnsite 1m 27s trunk passed
          -1 findbugs 1m 21s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 1m 2s trunk passed
                Patch Compile Tests
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 18s the patch passed
          +1 compile 1m 23s the patch passed
          +1 javac 1m 23s the patch passed
          +1 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 0 new + 334 unchanged - 2 fixed = 334 total (was 336)
          +1 mvnsite 1m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 27s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 findbugs 1m 44s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)
          +1 javadoc 0m 58s the patch passed
                Other Tests
          +1 unit 1m 9s hadoop-hdfs-client in the patch passed.
          -1 unit 65m 12s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          98m 25s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure210
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure020
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure030
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure060
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure050
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11696
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876092/HDFS-11696.009.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 3a9579fda5a3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8153fe2
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20187/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20187/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20187/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20187/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20187/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 23s Maven dependency ordering for branch +1 mvninstall 13m 10s trunk passed +1 compile 1m 25s trunk passed +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 27s trunk passed -1 findbugs 1m 21s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 2s trunk passed       Patch Compile Tests 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 18s the patch passed +1 compile 1m 23s the patch passed +1 javac 1m 23s the patch passed +1 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 0 new + 334 unchanged - 2 fixed = 334 total (was 336) +1 mvnsite 1m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 27s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 findbugs 1m 44s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10) +1 javadoc 0m 58s the patch passed       Other Tests +1 unit 1m 9s hadoop-hdfs-client in the patch passed. -1 unit 65m 12s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 98m 25s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure210   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure020   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure030   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure060   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure050   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11696 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876092/HDFS-11696.009.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 3a9579fda5a3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8153fe2 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20187/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20187/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20187/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20187/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20187/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment -

          Rebase the patch and attach the updated patch.
          Hi Andrew Wang, could you please take a review on the latest patch? Now findbugs warning appears constantly after each Jenkins building.

          Show
          linyiqun Yiqun Lin added a comment - Rebase the patch and attach the updated patch. Hi Andrew Wang , could you please take a review on the latest patch? Now findbugs warning appears constantly after each Jenkins building.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 15m 5s trunk passed
          +1 compile 1m 32s trunk passed
          +1 checkstyle 0m 45s trunk passed
          +1 mvnsite 1m 34s trunk passed
          -1 findbugs 1m 27s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 46s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
          +1 javadoc 1m 0s trunk passed
                Patch Compile Tests
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 22s the patch passed
          +1 compile 1m 25s the patch passed
          +1 javac 1m 25s the patch passed
          +1 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 0 new + 320 unchanged - 2 fixed = 320 total (was 322)
          +1 mvnsite 1m 28s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 34s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 9 fixed = 0 total (was 9)
          +1 javadoc 0m 58s the patch passed
                Other Tests
          +1 unit 1m 11s hadoop-hdfs-client in the patch passed.
          -1 unit 65m 59s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          101m 53s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11696
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880818/HDFS-11696.010.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 44452f747c33 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9891295
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20593/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20593/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20593/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20593/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 15m 5s trunk passed +1 compile 1m 32s trunk passed +1 checkstyle 0m 45s trunk passed +1 mvnsite 1m 34s trunk passed -1 findbugs 1m 27s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 46s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 1m 0s trunk passed       Patch Compile Tests 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 1m 25s the patch passed +1 javac 1m 25s the patch passed +1 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 0 new + 320 unchanged - 2 fixed = 320 total (was 322) +1 mvnsite 1m 28s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 34s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 9 fixed = 0 total (was 9) +1 javadoc 0m 58s the patch passed       Other Tests +1 unit 1m 11s hadoop-hdfs-client in the patch passed. -1 unit 65m 59s hadoop-hdfs in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 101m 53s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11696 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880818/HDFS-11696.010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 44452f747c33 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9891295 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20593/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20593/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20593/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20593/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          +1 thanks Yiqun!

          Show
          andrew.wang Andrew Wang added a comment - +1 thanks Yiqun!
          Hide
          linyiqun Yiqun Lin added a comment -

          Committed this to trunk. Thanks Andrew Wang for the review!

          Show
          linyiqun Yiqun Lin added a comment - Committed this to trunk. Thanks Andrew Wang for the review!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12188 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12188/)
          HDFS-11696. Fix warnings from Spotbugs in hadoop-hdfs. Contributed by (yqlin: rev 2e43c28e01fe006210e71aab179527669f6412ed)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeOptionParsing.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/protocol/SlowDiskReports.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12188 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12188/ ) HDFS-11696 . Fix warnings from Spotbugs in hadoop-hdfs. Contributed by (yqlin: rev 2e43c28e01fe006210e71aab179527669f6412ed) (edit) hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeOptionParsing.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/protocol/SlowDiskReports.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java

            People

            • Assignee:
              linyiqun Yiqun Lin
              Reporter:
              linyiqun Yiqun Lin
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development