Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1165

createSymlink should not hold the fsnamesytem lock when sync its edit log to disk

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Duplicate
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0, 0.22.0
    • Component/s: namenode
    • Labels:
      None

      Description

      Holding the fsnamesytem lock while calling logSync is unnecessary and decrease NameNode performance.

        Activity

        Hide
        Todd Lipcon added a comment -

        Since HDFS-988 is marked blocker, and I should have a unit test for it ready soon, I'm marking this one as duplicate.

        Show
        Todd Lipcon added a comment - Since HDFS-988 is marked blocker, and I should have a unit test for it ready soon, I'm marking this one as duplicate.
        Hide
        Eli Collins added a comment -

        Good find Hairong. Assuming HDFS-988 goes into 21 I think we can close this, unless Todd do you want to pull out that particular fix to a patch for this jira?

        Show
        Eli Collins added a comment - Good find Hairong. Assuming HDFS-988 goes into 21 I think we can close this, unless Todd do you want to pull out that particular fix to a patch for this jira?
        Hide
        Todd Lipcon added a comment -

        This is fixed in HDFS-988 (which generally cleans up synchronization and safemode checks throughout FSN). I need to do a unit test over there, then it should be good to commit.

        Show
        Todd Lipcon added a comment - This is fixed in HDFS-988 (which generally cleans up synchronization and safemode checks throughout FSN). I need to do a unit test over there, then it should be good to commit.

          People

          • Assignee:
            Eli Collins
            Reporter:
            Hairong Kuang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development