Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11647

Add -E option in hdfs "count" command to show erasure policy summarization

    Details

      Description

      Add -E option in hdfs "count" command to show erasure policy summarization

      1. HDFS-11647-001.patch
        18 kB
        luhuichun
      2. HDFS-11647-002.patch
        18 kB
        luhuichun
      3. HDFS-11647-003.patch
        20 kB
        luhuichun
      4. HDFS-11647-004.patch
        20 kB
        luhuichun
      5. HDFS-11647-005.patch
        20 kB
        luhuichun
      6. HDFS-11647-006.patch
        20 kB
        luhuichun
      7. HDFS-11647-007.patch
        20 kB
        luhuichun

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 7s HDFS-11647 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HDFS-11647
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870937/HADOOP-11647.patch
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19787/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 7s HDFS-11647 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-11647 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870937/HADOOP-11647.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19787/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Hey, luhuichun

          Thanks a lot for working on this. Looks good overall. Some minor comments:

          • Should ContentSummary#ecPolicy has a default value? Does user expect getErasureCodingPolicy to return null?
          • getErasureCodingPolicy() == right.getErasureCodingPolicy() &&
            

          Because the ec policy is a string, we should check null && .equals() here. Also, please fix the indent of this line and in hashCode.

          • In Count.java, please add spaces on both sides of symbols like "+" and "=". You could take a look of hadoop code style for reference.
          • We can use StringBuilder in {processOptions}

            .

          • hdfs.proto, why dont you name optional string redundancyPolicy = 13; as ecPolicy as used everywhere else? It'd be nice to keep them consistent.
          • ContentSummaryComputationContext#REPLICATED please change the signature to public static final String... for consistency.
          • public String getErasureCodingPolicyName(INode inode) }}, we might want to be consistent of the signature between modules. In some places, we call it {{ecPolicy(), in some places it is getErasureCodingPolicy.
          • } catch (IOException ioe) {
                LOG.warn("Encountered error getting ec policy for " + inode.getFullPathName(), ioe);
                return "";
            }
            

          If the IOE is HDFS related, we should throw it instead of ignore it here.

          if (isStriped()) {
             String ecPolicyName = summary.getErasureCodingPolicyName(this);
          }
          

          This has no side-effect to summary?

          Thanks!

          Show
          eddyxu Lei (Eddy) Xu added a comment - Hey, luhuichun Thanks a lot for working on this. Looks good overall. Some minor comments: Should ContentSummary#ecPolicy has a default value? Does user expect getErasureCodingPolicy to return null ? getErasureCodingPolicy() == right.getErasureCodingPolicy() && Because the ec policy is a string, we should check null && .equals() here. Also, please fix the indent of this line and in hashCode . In Count.java , please add spaces on both sides of symbols like "+" and "=". You could take a look of hadoop code style for reference. We can use StringBuilder in {processOptions} . hdfs.proto , why dont you name optional string redundancyPolicy = 13; as ecPolicy as used everywhere else? It'd be nice to keep them consistent. ContentSummaryComputationContext#REPLICATED please change the signature to public static final String... for consistency. public String getErasureCodingPolicyName(INode inode) }}, we might want to be consistent of the signature between modules. In some places, we call it {{ecPolicy() , in some places it is getErasureCodingPolicy . } catch (IOException ioe) { LOG.warn( "Encountered error getting ec policy for " + inode.getFullPathName(), ioe); return ""; } If the IOE is HDFS related, we should throw it instead of ignore it here. if (isStriped()) { String ecPolicyName = summary.getErasureCodingPolicyName( this ); } This has no side-effect to summary ? Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 13m 19s trunk passed
          +1 compile 13m 25s trunk passed
          +1 checkstyle 1m 56s trunk passed
          +1 mvnsite 2m 45s trunk passed
          -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 2m 4s trunk passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 58s the patch passed
          +1 compile 10m 8s the patch passed
          +1 cc 10m 8s the patch passed
          +1 javac 10m 8s the patch passed
          -0 checkstyle 1m 52s root: The patch generated 7 new + 146 unchanged - 0 fixed = 153 total (was 146)
          +1 mvnsite 2m 40s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          -1 findbugs 1m 54s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 2m 3s the patch passed
          -1 unit 8m 3s hadoop-common in the patch failed.
          +1 unit 1m 28s hadoop-hdfs-client in the patch passed.
          -1 unit 70m 42s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          144m 46s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs
            Dead store to bsp in org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java:org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java:[line 862]
          Failed junit tests hadoop.cli.TestCLI
            hadoop.fs.shell.TestCount
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11647
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872217/HDFS-11647-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux b4eafd73628c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 99634d1
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19847/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19847/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19847/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19847/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19847/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19847/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19847/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 13m 19s trunk passed +1 compile 13m 25s trunk passed +1 checkstyle 1m 56s trunk passed +1 mvnsite 2m 45s trunk passed -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 2m 4s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 58s the patch passed +1 compile 10m 8s the patch passed +1 cc 10m 8s the patch passed +1 javac 10m 8s the patch passed -0 checkstyle 1m 52s root: The patch generated 7 new + 146 unchanged - 0 fixed = 153 total (was 146) +1 mvnsite 2m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 1m 54s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 2m 3s the patch passed -1 unit 8m 3s hadoop-common in the patch failed. +1 unit 1m 28s hadoop-hdfs-client in the patch passed. -1 unit 70m 42s hadoop-hdfs in the patch failed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 144m 46s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Dead store to bsp in org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java:org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java: [line 862] Failed junit tests hadoop.cli.TestCLI   hadoop.fs.shell.TestCount   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11647 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872217/HDFS-11647-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux b4eafd73628c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99634d1 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19847/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19847/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19847/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19847/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19847/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19847/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19847/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 14m 53s trunk passed
          +1 compile 16m 38s trunk passed
          +1 checkstyle 2m 12s trunk passed
          +1 mvnsite 3m 6s trunk passed
          -1 findbugs 1m 37s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 2m 15s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 2m 18s the patch passed
          +1 compile 11m 44s the patch passed
          +1 cc 11m 44s the patch passed
          +1 javac 11m 44s the patch passed
          -0 checkstyle 2m 4s root: The patch generated 7 new + 146 unchanged - 0 fixed = 153 total (was 146)
          +1 mvnsite 3m 7s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          -1 findbugs 2m 16s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 2m 14s the patch passed
          -1 unit 8m 12s hadoop-common in the patch failed.
          +1 unit 1m 18s hadoop-hdfs-client in the patch passed.
          -1 unit 62m 43s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          147m 2s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs
            Dead store to bsp in org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java:org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java:[line 862]
          Failed junit tests hadoop.cli.TestCLI
            hadoop.fs.shell.TestCount
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130
            hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
            hadoop.hdfs.server.namenode.ha.TestHAFsck
            hadoop.hdfs.server.namenode.TestDecommissioningStatus



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11647
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872226/HDFS-11647-002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 8eb8ffcdc047 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 99634d1
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19849/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19849/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19849/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19849/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19849/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19849/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19849/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 14m 53s trunk passed +1 compile 16m 38s trunk passed +1 checkstyle 2m 12s trunk passed +1 mvnsite 3m 6s trunk passed -1 findbugs 1m 37s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 2m 15s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 2m 18s the patch passed +1 compile 11m 44s the patch passed +1 cc 11m 44s the patch passed +1 javac 11m 44s the patch passed -0 checkstyle 2m 4s root: The patch generated 7 new + 146 unchanged - 0 fixed = 153 total (was 146) +1 mvnsite 3m 7s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. -1 findbugs 2m 16s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 2m 14s the patch passed -1 unit 8m 12s hadoop-common in the patch failed. +1 unit 1m 18s hadoop-hdfs-client in the patch passed. -1 unit 62m 43s hadoop-hdfs in the patch failed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 147m 2s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Dead store to bsp in org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java:org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java: [line 862] Failed junit tests hadoop.cli.TestCLI   hadoop.fs.shell.TestCount   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.server.namenode.ha.TestHAFsck   hadoop.hdfs.server.namenode.TestDecommissioningStatus Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11647 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872226/HDFS-11647-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 8eb8ffcdc047 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99634d1 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19849/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19849/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19849/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19849/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19849/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19849/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19849/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 1m 24s Maven dependency ordering for branch
          +1 mvninstall 13m 4s trunk passed
          +1 compile 13m 39s trunk passed
          +1 checkstyle 1m 56s trunk passed
          +1 mvnsite 2m 43s trunk passed
          -1 findbugs 1m 24s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 2m 3s trunk passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 59s the patch passed
          +1 compile 10m 10s the patch passed
          +1 cc 10m 10s the patch passed
          +1 javac 10m 10s the patch passed
          -0 checkstyle 1m 56s root: The patch generated 7 new + 135 unchanged - 0 fixed = 142 total (was 135)
          +1 mvnsite 2m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 5m 2s the patch passed
          +1 javadoc 2m 4s the patch passed
          -1 unit 7m 57s hadoop-common in the patch failed.
          +1 unit 1m 20s hadoop-hdfs-client in the patch passed.
          -1 unit 63m 14s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          138m 16s



          Reason Tests
          Failed junit tests hadoop.net.TestDNS
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11647
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872791/HDFS-11647-003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc
          uname Linux e527c5962734 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bec79ca
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19888/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19888/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19888/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19888/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19888/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 1m 24s Maven dependency ordering for branch +1 mvninstall 13m 4s trunk passed +1 compile 13m 39s trunk passed +1 checkstyle 1m 56s trunk passed +1 mvnsite 2m 43s trunk passed -1 findbugs 1m 24s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 2m 3s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 59s the patch passed +1 compile 10m 10s the patch passed +1 cc 10m 10s the patch passed +1 javac 10m 10s the patch passed -0 checkstyle 1m 56s root: The patch generated 7 new + 135 unchanged - 0 fixed = 142 total (was 135) +1 mvnsite 2m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 5m 2s the patch passed +1 javadoc 2m 4s the patch passed -1 unit 7m 57s hadoop-common in the patch failed. +1 unit 1m 20s hadoop-hdfs-client in the patch passed. -1 unit 63m 14s hadoop-hdfs in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 138m 16s Reason Tests Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11647 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872791/HDFS-11647-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc uname Linux e527c5962734 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bec79ca Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19888/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19888/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19888/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19888/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19888/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 21s Maven dependency ordering for branch
          +1 mvninstall 13m 49s trunk passed
          +1 compile 14m 51s trunk passed
          +1 checkstyle 1m 58s trunk passed
          +1 mvnsite 2m 47s trunk passed
          -1 findbugs 1m 24s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 2m 6s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 2m 16s the patch passed
          +1 compile 12m 59s the patch passed
          +1 cc 12m 59s the patch passed
          +1 javac 12m 59s the patch passed
          -0 checkstyle 2m 37s root: The patch generated 1 new + 135 unchanged - 0 fixed = 136 total (was 135)
          +1 mvnsite 4m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 4s The patch has no ill-formed XML file.
          +1 findbugs 7m 41s the patch passed
          +1 javadoc 2m 10s the patch passed
          +1 unit 8m 7s hadoop-common in the patch passed.
          +1 unit 1m 22s hadoop-hdfs-client in the patch passed.
          -1 unit 100m 19s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 38s The patch does not generate ASF License warnings.
          185m 18s



          Reason Tests
          Failed junit tests hadoop.hdfs.tools.TestDFSAdminWithHA
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            hadoop.hdfs.server.namenode.ha.TestBootstrapStandby



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11647
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872834/HDFS-11647-004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc
          uname Linux 7ce60a4afd05 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8633ef8
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19893/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19893/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19893/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19893/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19893/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 21s Maven dependency ordering for branch +1 mvninstall 13m 49s trunk passed +1 compile 14m 51s trunk passed +1 checkstyle 1m 58s trunk passed +1 mvnsite 2m 47s trunk passed -1 findbugs 1m 24s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 2m 6s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 16s the patch passed +1 compile 12m 59s the patch passed +1 cc 12m 59s the patch passed +1 javac 12m 59s the patch passed -0 checkstyle 2m 37s root: The patch generated 1 new + 135 unchanged - 0 fixed = 136 total (was 135) +1 mvnsite 4m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 4s The patch has no ill-formed XML file. +1 findbugs 7m 41s the patch passed +1 javadoc 2m 10s the patch passed +1 unit 8m 7s hadoop-common in the patch passed. +1 unit 1m 22s hadoop-hdfs-client in the patch passed. -1 unit 100m 19s hadoop-hdfs in the patch failed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 185m 18s Reason Tests Failed junit tests hadoop.hdfs.tools.TestDFSAdminWithHA   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.server.namenode.ha.TestBootstrapStandby Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11647 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872834/HDFS-11647-004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc uname Linux 7ce60a4afd05 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8633ef8 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19893/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19893/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19893/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19893/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19893/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user wayblink opened a pull request:

          https://github.com/apache/hadoop/pull/233

          HDFS-11647

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/wayblink/hadoop hdfs-11647

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/233.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #233


          commit 9c60c302974f57fbff5f6bab3627f64fc0039d2b
          Author: wayblink <137658599@qq.com>
          Date: 2017-06-08T15:14:11Z

          a successful test

          commit a93f6894061c008e55f1b5fa01b36ec75f1616ec
          Author: wayblink <137658599@qq.com>
          Date: 2017-06-08T15:15:58Z

          small edit

          commit e04082e72c61157302fcaa4c1c55c5cff8e8b5eb
          Author: wayblink <137658599@qq.com>
          Date: 2017-06-09T04:39:11Z

          add doc in FileSystemSHell.md, modify some details

          commit c934e2e33bcdb7845dfd9a53d6085970da080460
          Author: wayblink <137658599@qq.com>
          Date: 2017-06-10T08:46:36Z

          modify the unit test

          commit 18cb930a4c80e0c6f11bda76012bdb29f69c7a8b
          Author: wayblink <137658599@qq.com>
          Date: 2017-06-12T03:29:06Z

          delete some useless code

          commit 759da1090667194a943609584a9171b4a312c21f
          Author: wayblink <137658599@qq.com>
          Date: 2017-06-13T06:50:27Z

          checkstyle

          commit 57f968847dca8af4dc29bdbb64661540f8ac4414
          Author: wayblink <137658599@qq.com>
          Date: 2017-06-15T03:27:13Z

          format


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user wayblink opened a pull request: https://github.com/apache/hadoop/pull/233 HDFS-11647 You can merge this pull request into a Git repository by running: $ git pull https://github.com/wayblink/hadoop hdfs-11647 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #233 commit 9c60c302974f57fbff5f6bab3627f64fc0039d2b Author: wayblink <137658599@qq.com> Date: 2017-06-08T15:14:11Z a successful test commit a93f6894061c008e55f1b5fa01b36ec75f1616ec Author: wayblink <137658599@qq.com> Date: 2017-06-08T15:15:58Z small edit commit e04082e72c61157302fcaa4c1c55c5cff8e8b5eb Author: wayblink <137658599@qq.com> Date: 2017-06-09T04:39:11Z add doc in FileSystemSHell.md, modify some details commit c934e2e33bcdb7845dfd9a53d6085970da080460 Author: wayblink <137658599@qq.com> Date: 2017-06-10T08:46:36Z modify the unit test commit 18cb930a4c80e0c6f11bda76012bdb29f69c7a8b Author: wayblink <137658599@qq.com> Date: 2017-06-12T03:29:06Z delete some useless code commit 759da1090667194a943609584a9171b4a312c21f Author: wayblink <137658599@qq.com> Date: 2017-06-13T06:50:27Z checkstyle commit 57f968847dca8af4dc29bdbb64661540f8ac4414 Author: wayblink <137658599@qq.com> Date: 2017-06-15T03:27:13Z format
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wayblink closed the pull request at:

          https://github.com/apache/hadoop/pull/233

          Show
          githubbot ASF GitHub Bot added a comment - Github user wayblink closed the pull request at: https://github.com/apache/hadoop/pull/233
          Hide
          luhuichun luhuichun added a comment -

          Lei (Eddy) Xu Hi Eddy, updated according to your comments, thx for review

          Show
          luhuichun luhuichun added a comment - Lei (Eddy) Xu Hi Eddy, updated according to your comments, thx for review
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 13m 8s trunk passed
          +1 compile 13m 31s trunk passed
          +1 checkstyle 1m 57s trunk passed
          +1 mvnsite 2m 45s trunk passed
          -1 findbugs 1m 24s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 2m 3s trunk passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 58s the patch passed
          +1 compile 10m 9s the patch passed
          +1 cc 10m 9s the patch passed
          +1 javac 10m 9s the patch passed
          +1 checkstyle 1m 56s the patch passed
          +1 mvnsite 2m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 findbugs 4m 59s the patch passed
          +1 javadoc 2m 3s the patch passed
          +1 unit 8m 21s hadoop-common in the patch passed.
          +1 unit 1m 19s hadoop-hdfs-client in the patch passed.
          -1 unit 64m 34s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          138m 46s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11647
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873054/HDFS-11647-005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc
          uname Linux af29e729e1b7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 999c8fc
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19911/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19911/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19911/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19911/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 13m 8s trunk passed +1 compile 13m 31s trunk passed +1 checkstyle 1m 57s trunk passed +1 mvnsite 2m 45s trunk passed -1 findbugs 1m 24s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 2m 3s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 58s the patch passed +1 compile 10m 9s the patch passed +1 cc 10m 9s the patch passed +1 javac 10m 9s the patch passed +1 checkstyle 1m 56s the patch passed +1 mvnsite 2m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 findbugs 4m 59s the patch passed +1 javadoc 2m 3s the patch passed +1 unit 8m 21s hadoop-common in the patch passed. +1 unit 1m 19s hadoop-hdfs-client in the patch passed. -1 unit 64m 34s hadoop-hdfs in the patch failed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 138m 46s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11647 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873054/HDFS-11647-005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc uname Linux af29e729e1b7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 999c8fc Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19911/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19911/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19911/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19911/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Just took a detailed off-line review on the latest patch also checking Eddy's comments. Huichun would provide an update. Thanks in advance.

          Show
          drankye Kai Zheng added a comment - Just took a detailed off-line review on the latest patch also checking Eddy's comments. Huichun would provide an update. Thanks in advance.
          Hide
          luhuichun luhuichun added a comment -

          updated with new version

          Show
          luhuichun luhuichun added a comment - updated with new version
          Hide
          luhuichun luhuichun added a comment - - edited

          Lei (Eddy) Xu in ContentSummaryComputationContext.java, we follow the other functions' name practice in the same file,So I think getErasureCodingPolicyName() is better and clear. I did not find ecPolicy() in code base.

          Show
          luhuichun luhuichun added a comment - - edited Lei (Eddy) Xu in ContentSummaryComputationContext.java, we follow the other functions' name practice in the same file,So I think getErasureCodingPolicyName() is better and clear. I did not find ecPolicy() in code base.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 15m 49s trunk passed
          +1 compile 14m 59s trunk passed
          +1 checkstyle 2m 5s trunk passed
          +1 mvnsite 2m 58s trunk passed
          -1 findbugs 1m 31s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 2m 37s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 2m 40s the patch passed
          +1 compile 13m 13s the patch passed
          +1 cc 13m 13s the patch passed
          +1 javac 13m 13s the patch passed
          +1 checkstyle 2m 5s the patch passed
          +1 mvnsite 2m 55s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 5m 16s the patch passed
          +1 javadoc 2m 10s the patch passed
          -1 unit 7m 58s hadoop-common in the patch failed.
          +1 unit 1m 31s hadoop-hdfs-client in the patch passed.
          -1 unit 96m 25s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 43s The patch does not generate ASF License warnings.
          181m 5s



          Reason Tests
          Failed junit tests hadoop.fs.TestHarFileSystem
            hadoop.fs.TestFilterFileSystem
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11647
          GITHUB PR https://github.com/apache/hadoop/pull/233
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc
          uname Linux cfd0dff11a7d 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 75043d3
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19940/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19940/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19940/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19940/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19940/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 15m 49s trunk passed +1 compile 14m 59s trunk passed +1 checkstyle 2m 5s trunk passed +1 mvnsite 2m 58s trunk passed -1 findbugs 1m 31s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 2m 37s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 2m 40s the patch passed +1 compile 13m 13s the patch passed +1 cc 13m 13s the patch passed +1 javac 13m 13s the patch passed +1 checkstyle 2m 5s the patch passed +1 mvnsite 2m 55s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 5m 16s the patch passed +1 javadoc 2m 10s the patch passed -1 unit 7m 58s hadoop-common in the patch failed. +1 unit 1m 31s hadoop-hdfs-client in the patch passed. -1 unit 96m 25s hadoop-hdfs in the patch failed. +1 asflicense 0m 43s The patch does not generate ASF License warnings. 181m 5s Reason Tests Failed junit tests hadoop.fs.TestHarFileSystem   hadoop.fs.TestFilterFileSystem   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11647 GITHUB PR https://github.com/apache/hadoop/pull/233 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc uname Linux cfd0dff11a7d 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 75043d3 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19940/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19940/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19940/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19940/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19940/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Looks like the recent building picked up the github PR instead of the updated patch. The PR was already closed, not sure how to avoid this. Eddy, do you have any idea about this? Thanks!

          Show
          drankye Kai Zheng added a comment - Looks like the recent building picked up the github PR instead of the updated patch. The PR was already closed, not sure how to avoid this. Eddy, do you have any idea about this? Thanks!
          Hide
          andrew.wang Andrew Wang added a comment -

          Unfortunately, once there's a GH PR, Yetus will always use it for precommit. If we want to go back to patches, we need to file a new JIRA.

          Show
          andrew.wang Andrew Wang added a comment - Unfortunately, once there's a GH PR, Yetus will always use it for precommit. If we want to go back to patches, we need to file a new JIRA.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thanks for the update, luhuichun

          One small nits: In FileSystemShell.md

          The output columns with -count -e are: DIR\_COUNT,FILE\_COUNT,CONTENT_SIZE ERASURECODING\_POLICY,PATHNAME
          

          Other than erasure coding policy, the rest of fields are comma separated? Could you make it consistently with comma separated format?

          The rest LGTM.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thanks for the update, luhuichun One small nits: In FileSystemShell.md The output columns with -count -e are: DIR\_COUNT,FILE\_COUNT,CONTENT_SIZE ERASURECODING\_POLICY,PATHNAME Other than erasure coding policy, the rest of fields are comma separated? Could you make it consistently with comma separated format? The rest LGTM.
          Hide
          luhuichun luhuichun added a comment -

          @Lei (Eddy) Xu thx Eddy, updated

          Show
          luhuichun luhuichun added a comment - @Lei (Eddy) Xu thx Eddy, updated
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 1m 34s Maven dependency ordering for branch
          +1 mvninstall 14m 46s trunk passed
          +1 compile 15m 4s trunk passed
          +1 checkstyle 2m 1s trunk passed
          +1 mvnsite 3m 12s trunk passed
          -1 findbugs 1m 43s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 2m 12s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 2m 17s the patch passed
          +1 compile 11m 51s the patch passed
          +1 cc 11m 51s the patch passed
          +1 javac 11m 51s the patch passed
          +1 checkstyle 1m 58s the patch passed
          +1 mvnsite 2m 48s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 findbugs 5m 15s the patch passed
          +1 javadoc 2m 6s the patch passed
          -1 unit 9m 24s hadoop-common in the patch failed.
          +1 unit 2m 3s hadoop-hdfs-client in the patch passed.
          -1 unit 75m 19s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 54s The patch does not generate ASF License warnings.
          159m 55s



          Reason Tests
          Failed junit tests hadoop.security.TestKDiag
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11647
          GITHUB PR https://github.com/apache/hadoop/pull/233
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc
          uname Linux 03ccdf90d6da 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3369540
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19961/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19961/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19961/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19961/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19961/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 1m 34s Maven dependency ordering for branch +1 mvninstall 14m 46s trunk passed +1 compile 15m 4s trunk passed +1 checkstyle 2m 1s trunk passed +1 mvnsite 3m 12s trunk passed -1 findbugs 1m 43s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 2m 12s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 17s the patch passed +1 compile 11m 51s the patch passed +1 cc 11m 51s the patch passed +1 javac 11m 51s the patch passed +1 checkstyle 1m 58s the patch passed +1 mvnsite 2m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 findbugs 5m 15s the patch passed +1 javadoc 2m 6s the patch passed -1 unit 9m 24s hadoop-common in the patch failed. +1 unit 2m 3s hadoop-hdfs-client in the patch passed. -1 unit 75m 19s hadoop-hdfs in the patch failed. +1 asflicense 0m 54s The patch does not generate ASF License warnings. 159m 55s Reason Tests Failed junit tests hadoop.security.TestKDiag   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11647 GITHUB PR https://github.com/apache/hadoop/pull/233 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc uname Linux 03ccdf90d6da 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3369540 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19961/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19961/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19961/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19961/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19961/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          +1. Thanks for the contribution, luhuichun

          Committed to trunk.

          Show
          eddyxu Lei (Eddy) Xu added a comment - +1. Thanks for the contribution, luhuichun Committed to trunk.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11897 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11897/)
          HDFS-11647. Add -E option in hdfs "count" command to show erasure policy (lei: rev 45ff4d38e6175bc59b126633fc46927f8af9b641)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java
          • (edit) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/cli/TestCLI.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/hdfs.proto
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testErasureCodingConf.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ContentSummaryComputationContext.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
          • (edit) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11897 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11897/ ) HDFS-11647 . Add -E option in hdfs "count" command to show erasure policy (lei: rev 45ff4d38e6175bc59b126633fc46927f8af9b641) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java (edit) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/cli/TestCLI.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/hdfs.proto (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testErasureCodingConf.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ContentSummaryComputationContext.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java (edit) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md

            People

            • Assignee:
              luhuichun luhuichun
              Reporter:
              Sammi SammiChen
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development