Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
    • Component/s: datanode
    • Labels:
      None

      Description

      Currently, the thread name looks like

      2017-03-20 18:32:22,022 [DataNode: [[[DISK]file:/Users/szetszwo/hadoop/t2/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/dn1_data0, [DISK]file:/Users/szetszwo/hadoop/t2/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/dn1_data1]]  heartbeating to localhost/127.0.0.1:51772] INFO  ...
      

      which contains the full path for each storage dir. It is unnecessarily long.

      1. HDFS-11558.000.patch
        3 kB
        Xiaobing Zhou
      2. HDFS-11558.001.patch
        2 kB
        Xiaobing Zhou
      3. HDFS-11558.002.patch
        6 kB
        Xiaobing Zhou
      4. HDFS-11558.003.patch
        6 kB
        Xiaobing Zhou
      5. HDFS-11558.004.patch
        7 kB
        Xiaobing Zhou
      6. HDFS-11558.005.patch
        8 kB
        Xiaobing Zhou
      7. HDFS-11558.006.patch
        8 kB
        Xiaobing Zhou
      8. HDFS-11558-branch-2.006.patch
        8 kB
        Xiaobing Zhou
      9. HDFS-11558-branch-2.8.006.patch
        7 kB
        Xiaobing Zhou

        Issue Links

          Activity

          Hide
          xiaobingo Xiaobing Zhou added a comment - - edited

          Posted v0 patch. The actor thread name will be

          [Block pool <registering> (Datanode Uuid unassigned) heartbeating to localhost/127.0.0.1:53006]
          

          or

          [Block pool BP-948066398-XXXX-1490219911913 (Datanode Uuid 751c2964-af32-412d-8681-c3e4a2040804) heartbeating to localhost/127.0.0.1:53014]
          
          Show
          xiaobingo Xiaobing Zhou added a comment - - edited Posted v0 patch. The actor thread name will be [Block pool <registering> (Datanode Uuid unassigned) heartbeating to localhost/127.0.0.1:53006] or [Block pool BP-948066398-XXXX-1490219911913 (Datanode Uuid 751c2964-af32-412d-8681-c3e4a2040804) heartbeating to localhost/127.0.0.1:53014]
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          The patch looks good.
          One suggestion, BPServiceActor#getThreadName just calls BPServiceActor#formatThreadName and seems to be redundant. I think we can get rid of one the methods.

          Show
          hanishakoneru Hanisha Koneru added a comment - The patch looks good. One suggestion, BPServiceActor#getThreadName just calls BPServiceActor#formatThreadName and seems to be redundant. I think we can get rid of one the methods.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Posted v1. Thanks Hanisha Koneru.

          Show
          xiaobingo Xiaobing Zhou added a comment - Posted v1. Thanks Hanisha Koneru .
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          Thank you Xiaobing Zhou. Patch v01 LGTM.

          Show
          hanishakoneru Hanisha Koneru added a comment - Thank you Xiaobing Zhou . Patch v01 LGTM.
          Hide
          liuml07 Mingliang Liu added a comment -

          I'd suggest the thread name be even shorter. The heartbeating info can be inferred by related DN logs. Ping Tsz Wo Nicholas Sze for 2nd opinion.

          Show
          liuml07 Mingliang Liu added a comment - I'd suggest the thread name be even shorter. The heartbeating info can be inferred by related DN logs. Ping Tsz Wo Nicholas Sze for 2nd opinion.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 13m 57s trunk passed
          +1 compile 0m 57s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 6s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 55s the patch passed
          +1 compile 1m 1s the patch passed
          +1 javac 1m 1s the patch passed
          -0 checkstyle 0m 37s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
          +1 mvnsite 1m 8s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 13s the patch passed
          +1 javadoc 0m 40s the patch passed
          -1 unit 71m 37s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          100m 17s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11558
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860028/HDFS-11558.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux aeee1a147511 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f462e1f
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18806/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18806/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18806/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18806/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 57s trunk passed +1 compile 0m 57s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 6s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 55s the patch passed +1 compile 1m 1s the patch passed +1 javac 1m 1s the patch passed -0 checkstyle 0m 37s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24) +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 13s the patch passed +1 javadoc 0m 40s the patch passed -1 unit 71m 37s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 100m 17s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11558 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860028/HDFS-11558.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux aeee1a147511 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f462e1f Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18806/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18806/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18806/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18806/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          > I'd suggest the thread name be even shorter. ...

          I agree. Ideally, we only need

          BP-948066398-XXXX-1490219911913 heartbeat to localhost/127.0.0.1:53014
          

          However, the BP id may be missing in the beginning. How about using the NS id if BP id is missing? The NS id is available in BlockPoolManager.doRefreshNamenodes(..) but it is not passed down the road.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - > I'd suggest the thread name be even shorter. ... I agree. Ideally, we only need BP-948066398-XXXX-1490219911913 heartbeat to localhost/127.0.0.1:53014 However, the BP id may be missing in the beginning. How about using the NS id if BP id is missing? The NS id is available in BlockPoolManager.doRefreshNamenodes(..) but it is not passed down the road.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 for Tsz Wo Nicholas Sze's suggestion and for retaining the NN IP address and port. That could be very useful if a specific actor thread is blocked.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 for Tsz Wo Nicholas Sze 's suggestion and for retaining the NN IP address and port. That could be very useful if a specific actor thread is blocked.
          Hide
          xiaobingo Xiaobing Zhou added a comment - - edited

          Posted v2. Thanks all for reviews. Since actor is instantiated per active or standby namenode, address of which is always available through conf. Do we need assemble it into actor thread name? Arpit Agarwal Thanks.

          With v2 patch, thread name looks like:

          2017-03-27 12:11:12,548 [<nameservice id unspecified> heartbeating] INFO
          
          2017-03-27 12:11:12,584 [BP-2084616792-XXXX-1490641870531 heartbeating]
          
          Show
          xiaobingo Xiaobing Zhou added a comment - - edited Posted v2. Thanks all for reviews. Since actor is instantiated per active or standby namenode, address of which is always available through conf. Do we need assemble it into actor thread name? Arpit Agarwal Thanks. With v2 patch, thread name looks like: 2017-03-27 12:11:12,548 [<nameservice id unspecified> heartbeating] INFO 2017-03-27 12:11:12,584 [BP-2084616792-XXXX-1490641870531 heartbeating]
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 46s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 14m 33s trunk passed
          +1 compile 0m 52s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 17s trunk passed
          +1 mvneclipse 0m 22s trunk passed
          +1 findbugs 2m 20s trunk passed
          +1 javadoc 0m 52s trunk passed
          -1 mvninstall 0m 59s hadoop-hdfs in the patch failed.
          -1 compile 0m 58s hadoop-hdfs in the patch failed.
          -1 javac 0m 58s hadoop-hdfs in the patch failed.
          -0 checkstyle 0m 41s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49)
          -1 mvnsite 1m 3s hadoop-hdfs in the patch failed.
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 30s hadoop-hdfs in the patch failed.
          +1 javadoc 0m 46s the patch passed
          -1 unit 1m 1s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          29m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11558
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860706/HDFS-11558.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 55d835e28e25 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / db2adf3
          Default Java 1.8.0_121
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18851/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18851/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 46s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 33s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 17s trunk passed +1 mvneclipse 0m 22s trunk passed +1 findbugs 2m 20s trunk passed +1 javadoc 0m 52s trunk passed -1 mvninstall 0m 59s hadoop-hdfs in the patch failed. -1 compile 0m 58s hadoop-hdfs in the patch failed. -1 javac 0m 58s hadoop-hdfs in the patch failed. -0 checkstyle 0m 41s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49) -1 mvnsite 1m 3s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 30s hadoop-hdfs in the patch failed. +1 javadoc 0m 46s the patch passed -1 unit 1m 1s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 29m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11558 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860706/HDFS-11558.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 55d835e28e25 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / db2adf3 Default Java 1.8.0_121 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18851/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18851/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18851/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          v3 still keeps NN IP address and port as part of thread name.

          Show
          xiaobingo Xiaobing Zhou added a comment - v3 still keeps NN IP address and port as part of thread name.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 13m 49s trunk passed
          +1 compile 0m 50s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 0m 57s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 55s trunk passed
          +1 javadoc 0m 42s trunk passed
          -1 mvninstall 0m 49s hadoop-hdfs in the patch failed.
          -1 compile 0m 57s hadoop-hdfs in the patch failed.
          -1 javac 0m 57s hadoop-hdfs in the patch failed.
          +1 checkstyle 0m 41s the patch passed
          -1 mvnsite 0m 59s hadoop-hdfs in the patch failed.
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 29s hadoop-hdfs in the patch failed.
          +1 javadoc 0m 45s the patch passed
          -1 unit 0m 54s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          27m 2s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11558
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860809/HDFS-11558.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 274a7a7e168f 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 253e3e7
          Default Java 1.8.0_121
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18867/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18867/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 49s trunk passed +1 compile 0m 50s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 0m 42s trunk passed -1 mvninstall 0m 49s hadoop-hdfs in the patch failed. -1 compile 0m 57s hadoop-hdfs in the patch failed. -1 javac 0m 57s hadoop-hdfs in the patch failed. +1 checkstyle 0m 41s the patch passed -1 mvnsite 0m 59s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 29s hadoop-hdfs in the patch failed. +1 javadoc 0m 45s the patch passed -1 unit 0m 54s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 27m 2s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11558 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860809/HDFS-11558.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 274a7a7e168f 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 253e3e7 Default Java 1.8.0_121 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18867/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18867/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18867/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          v4 fixed some compile issues.

          Show
          xiaobingo Xiaobing Zhou added a comment - v4 fixed some compile issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 15m 36s trunk passed
          +1 compile 0m 52s trunk passed
          +1 checkstyle 0m 39s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 56s trunk passed
          +1 javadoc 0m 43s trunk passed
          +1 mvninstall 0m 53s the patch passed
          +1 compile 0m 48s the patch passed
          +1 javac 0m 48s the patch passed
          +1 checkstyle 0m 35s the patch passed
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 0s the patch passed
          +1 javadoc 0m 39s the patch passed
          -1 unit 79m 42s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          108m 50s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11558
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860909/HDFS-11558.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 79438641890a 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6b09336
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18872/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18872/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18872/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 15m 36s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 53s the patch passed +1 compile 0m 48s the patch passed +1 javac 0m 48s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 0s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 79m 42s hadoop-hdfs in the patch failed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 108m 50s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11558 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860909/HDFS-11558.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 79438641890a 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6b09336 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18872/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18872/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18872/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Let's remove the following constructor. It is only used by a test.

            BPOfferService(
                List<InetSocketAddress> nnAddrs,
                List<InetSocketAddress> lifelineNnAddrs,
                DataNode dn) {
              this(null, nnAddrs, lifelineNnAddrs, dn);
            }
          

          After that, nameserviceId is never null. So that we can remove the null check in formatThreadName.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Let's remove the following constructor. It is only used by a test. BPOfferService( List<InetSocketAddress> nnAddrs, List<InetSocketAddress> lifelineNnAddrs, DataNode dn) { this ( null , nnAddrs, lifelineNnAddrs, dn); } After that, nameserviceId is never null. So that we can remove the null check in formatThreadName.
          Hide
          xiaobingo Xiaobing Zhou added a comment - - edited

          v5 removed the constructor BPOfferService. Thanks Tsz Wo Nicholas Sze.
          nameserviceId can be null for unit tests when cluster is booting when ns is not configured, in other words, nsToAdd will be null in BlockPoolManager#doRefreshNamenodes.

          The stack trace where getNameserviceId is called.

          at org.apache.hadoop.hdfs.server.datanode.BPOfferService.getNameserviceId(BPOfferService.java:183)
          	at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.formatThreadName(BPServiceActor.java:557)
          	at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.start(BPServiceActor.java:544)
          	at org.apache.hadoop.hdfs.server.datanode.BPOfferService.start(BPOfferService.java:301)
          	at org.apache.hadoop.hdfs.server.datanode.BlockPoolManager$1.run(BlockPoolManager.java:129)
          	at java.security.AccessController.doPrivileged(Native Method)
          	at javax.security.auth.Subject.doAs(Subject.java:422)
          	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1965)
          	at org.apache.hadoop.hdfs.server.datanode.BlockPoolManager.startAll(BlockPoolManager.java:124)
          	at org.apache.hadoop.hdfs.server.datanode.BlockPoolManager.doRefreshNamenodes(BlockPoolManager.java:219)
          	at org.apache.hadoop.hdfs.server.datanode.BlockPoolManager.refreshNamenodes(BlockPoolManager.java:158)
          	at org.apache.hadoop.hdfs.server.datanode.DataNode.startDataNode(DataNode.java:1423)
          	at org.apache.hadoop.hdfs.server.datanode.DataNode.<init>(DataNode.java:495)
          	at org.apache.hadoop.hdfs.server.datanode.DataNode.makeInstance(DataNode.java:2735)
          	at org.apache.hadoop.hdfs.server.datanode.DataNode.instantiateDataNode(DataNode.java:2638)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1621)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:868)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:491)
          	at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:450)
          
          Show
          xiaobingo Xiaobing Zhou added a comment - - edited v5 removed the constructor BPOfferService. Thanks Tsz Wo Nicholas Sze . nameserviceId can be null for unit tests when cluster is booting when ns is not configured, in other words, nsToAdd will be null in BlockPoolManager#doRefreshNamenodes. The stack trace where getNameserviceId is called. at org.apache.hadoop.hdfs.server.datanode.BPOfferService.getNameserviceId(BPOfferService.java:183) at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.formatThreadName(BPServiceActor.java:557) at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.start(BPServiceActor.java:544) at org.apache.hadoop.hdfs.server.datanode.BPOfferService.start(BPOfferService.java:301) at org.apache.hadoop.hdfs.server.datanode.BlockPoolManager$1.run(BlockPoolManager.java:129) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1965) at org.apache.hadoop.hdfs.server.datanode.BlockPoolManager.startAll(BlockPoolManager.java:124) at org.apache.hadoop.hdfs.server.datanode.BlockPoolManager.doRefreshNamenodes(BlockPoolManager.java:219) at org.apache.hadoop.hdfs.server.datanode.BlockPoolManager.refreshNamenodes(BlockPoolManager.java:158) at org.apache.hadoop.hdfs.server.datanode.DataNode.startDataNode(DataNode.java:1423) at org.apache.hadoop.hdfs.server.datanode.DataNode.<init>(DataNode.java:495) at org.apache.hadoop.hdfs.server.datanode.DataNode.makeInstance(DataNode.java:2735) at org.apache.hadoop.hdfs.server.datanode.DataNode.instantiateDataNode(DataNode.java:2638) at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1621) at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:868) at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:491) at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:450)
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 for the v005 patch. Will hold off committing in case Tsz Wo Nicholas Sze has further comments.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 for the v005 patch. Will hold off committing in case Tsz Wo Nicholas Sze has further comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 29s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 18m 29s trunk passed
          +1 compile 0m 48s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 0m 57s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 46s trunk passed
          +1 javadoc 0m 41s trunk passed
          +1 mvninstall 0m 48s the patch passed
          +1 compile 0m 47s the patch passed
          +1 javac 0m 47s the patch passed
          +1 checkstyle 0m 33s the patch passed
          +1 mvnsite 0m 50s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 57s the patch passed
          +1 javadoc 0m 39s the patch passed
          -1 unit 74m 30s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          106m 2s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11558
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861745/HDFS-11558.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6102328be822 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5faa949
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18957/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18957/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18957/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 18m 29s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 46s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 0m 47s the patch passed +1 javac 0m 47s the patch passed +1 checkstyle 0m 33s the patch passed +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 74m 30s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 106m 2s Reason Tests Failed junit tests hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11558 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861745/HDFS-11558.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6102328be822 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5faa949 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18957/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18957/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18957/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          > After that, nameserviceId is never null. So that we can remove the null check in formatThreadName.

          Sorry that I may not be clear – I mean pass a non-null value (say "ns") in TestBPOfferService so that nameserviceId is never null.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - > After that, nameserviceId is never null. So that we can remove the null check in formatThreadName. Sorry that I may not be clear – I mean pass a non-null value (say "ns") in TestBPOfferService so that nameserviceId is never null.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Cleared, thanks. Posted v6.

          Show
          xiaobingo Xiaobing Zhou added a comment - Cleared, thanks. Posted v6.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 14m 33s trunk passed
          +1 compile 0m 46s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 51s trunk passed
          +1 javadoc 0m 43s trunk passed
          +1 mvninstall 0m 55s the patch passed
          +1 compile 0m 53s the patch passed
          +1 javac 0m 53s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 37s the patch passed
          -1 unit 65m 15s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          92m 55s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11558
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862362/HDFS-11558.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1d12ea59d9a1 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1a9439e
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18998/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18998/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18998/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 14m 33s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 55s the patch passed +1 compile 0m 53s the patch passed +1 javac 0m 53s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 65m 15s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 92m 55s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11558 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862362/HDFS-11558.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1d12ea59d9a1 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1a9439e Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18998/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18998/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18998/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good. Thanks a lot, Xiaobing.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - +1 patch looks good. Thanks a lot, Xiaobing.
          Hide
          liuml07 Mingliang Liu added a comment - - edited

          Committed to trunk branch. Xiaobing, can you upload the 2.x patches? I see minor conflicts when backporting. Thanks,

          Show
          liuml07 Mingliang Liu added a comment - - edited Committed to trunk branch. Xiaobing, can you upload the 2.x patches? I see minor conflicts when backporting. Thanks,
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks Xiaobing Zhou for your contribution. Thanks Tsz Wo Nicholas Sze, Hanisha Koneru and Arpit Agarwal for your review and discussion.

          Show
          liuml07 Mingliang Liu added a comment - Thanks Xiaobing Zhou for your contribution. Thanks Tsz Wo Nicholas Sze , Hanisha Koneru and Arpit Agarwal for your review and discussion.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Posted branch-2 patch. Thanks all.

          Show
          xiaobingo Xiaobing Zhou added a comment - Posted branch-2 patch. Thanks all.
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Jenkins build Hadoop-trunk-Commit #11572 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11572/)
          HDFS-11558. BPServiceActor thread name is too long. Contributed by (liuml07: rev 3a91376707d451777b8269f81bcd48315edd9fc7)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockPoolManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Jenkins build Hadoop-trunk-Commit #11572 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11572/ ) HDFS-11558 . BPServiceActor thread name is too long. Contributed by (liuml07: rev 3a91376707d451777b8269f81bcd48315edd9fc7) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockPoolManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Posted branch-2.8 patch.

          Show
          xiaobingo Xiaobing Zhou added a comment - Posted branch-2.8 patch.
          Hide
          djp Junping Du added a comment -

          Hi Mingliang Liu, thanks for review and commit. As my email to hadoop dev list, we have 2.8.1 branch get cut-off for release since yesterday. Just merge the commit to branch-2.8.1 assume it is supposed to land in 2.8.1 release. Isn't it?

          Show
          djp Junping Du added a comment - Hi Mingliang Liu , thanks for review and commit. As my email to hadoop dev list, we have 2.8.1 branch get cut-off for release since yesterday. Just merge the commit to branch-2.8.1 assume it is supposed to land in 2.8.1 release. Isn't it?
          Hide
          liuml07 Mingliang Liu added a comment -

          Sorry I missed the call for cutting of branch-2.8.1. Thanks for cherry-picking.

          Show
          liuml07 Mingliang Liu added a comment - Sorry I missed the call for cutting of branch-2.8.1 . Thanks for cherry-picking.
          Hide
          djp Junping Du added a comment -

          No worry. Mingliang. I will keep tracking.

          Show
          djp Junping Du added a comment - No worry. Mingliang. I will keep tracking.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/)
          HDFS-11558. BPServiceActor thread name is too long. Contributed by (liuml07: rev 3a91376707d451777b8269f81bcd48315edd9fc7)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockPoolManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/ ) HDFS-11558 . BPServiceActor thread name is too long. Contributed by (liuml07: rev 3a91376707d451777b8269f81bcd48315edd9fc7) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockPoolManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

            People

            • Assignee:
              xiaobingo Xiaobing Zhou
              Reporter:
              szetszwo Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development