HDFS-11461 introduces slow disk detection. We can expose these findings through JMX for visibility.
This message was automatically generated.
In patch v02, I have resolved the checkstyle errors and included a method to add slow disks for testing purposes.
The v2 patch looks good. One minor suggestion, DataNode#addSlowDiskForTesting should be package private.
Thank you Arpit Agarwal for reviewing the patch.
DataNodeDiskMetrics#addSlowDiskForTesting is in org.apache.hadoop.hdfs.server.datanode.metrics pacakge . It is called in TestDataNodeMXBean which is in org.apache.hadoop.hdfs.server.datanode. pacakge. So we need it to be public.
Thanks for the clarification. I've committed this fix.
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11423 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11423/)
HDFS-11517. Expose slow disks via DataNode JMX. Contributed by Hanisha (arp: rev 7f8e928400db954cfe37a3bd35762e1b310dcb8e)
Thank you Arpit Agarwal.