Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11406

Remove unused getStartInstance and getFinalizeInstance in FSEditLogOp

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:
      None

      Description

      Looking at FSEditLogOp, these two methods are unused and can be removed:

          static RollingUpgradeOp getStartInstance(OpInstanceCache cache) {
            return (RollingUpgradeOp) cache.get(OP_ROLLING_UPGRADE_START);
          }
      
          static RollingUpgradeOp getFinalizeInstance(OpInstanceCache cache) {
            return (RollingUpgradeOp) cache.get(OP_ROLLING_UPGRADE_FINALIZE);
          }
      

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        Alison Yu, interested in taking this one?

        Show
        andrew.wang Andrew Wang added a comment - Alison Yu , interested in taking this one?
        Hide
        alisonyu Alison Yu added a comment -

        Patch attached, please review. Thanks Andrew Wang!

        Show
        alisonyu Alison Yu added a comment - Patch attached, please review. Thanks Andrew Wang !
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 12m 45s trunk passed
        +1 compile 0m 48s trunk passed
        +1 checkstyle 0m 36s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 51s trunk passed
        +1 javadoc 0m 43s trunk passed
        +1 mvninstall 0m 58s the patch passed
        +1 compile 0m 53s the patch passed
        +1 javac 0m 53s the patch passed
        +1 checkstyle 0m 36s the patch passed
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 4s the patch passed
        +1 javadoc 0m 41s the patch passed
        -1 unit 68m 57s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        95m 4s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11406
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12853803/HDFS-11406.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6bf69b2df70b 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2158496
        Default Java 1.8.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18411/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18411/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18411/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 45s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 58s the patch passed +1 compile 0m 53s the patch passed +1 javac 0m 53s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 0m 41s the patch passed -1 unit 68m 57s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 95m 4s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11406 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12853803/HDFS-11406.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6bf69b2df70b 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2158496 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18411/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18411/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18411/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        +1 LGTM, thanks for the contribution Alison! Failed tests look unrelated, I'll commit this shortly.

        Show
        andrew.wang Andrew Wang added a comment - +1 LGTM, thanks for the contribution Alison! Failed tests look unrelated, I'll commit this shortly.
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed to trunk and branch-2. Thanks for the contribution Alison!

        Show
        andrew.wang Andrew Wang added a comment - Committed to trunk and branch-2. Thanks for the contribution Alison!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11284 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11284/)
        HDFS-11406. Remove unused getStartInstance and getFinalizeInstance in (wang: rev 8ef7ebbc7112e1868c9b12ff1df4a40fe7afa8af)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11284 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11284/ ) HDFS-11406 . Remove unused getStartInstance and getFinalizeInstance in (wang: rev 8ef7ebbc7112e1868c9b12ff1df4a40fe7afa8af) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java

          People

          • Assignee:
            alisonyu Alison Yu
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development