Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11405

Rename "erasurecode" CLI subcommand to "ec"

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: erasure-coding
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      The "hdfs erasurecode" CLI command has been renamed to "hdfs ec" for ease-of-use.

      Description

      Right now the erasure coding CLI subcommand is "erasurecode". I think it'd be nice to shorten this to just "ec".

      We've shortened things like "memory caching" to "cache" or "at rest encryption" to "crypto" for ease of use, this is in the same style.

      This would also require doc updates.

      1. HDFS-11405.01.patch
        4 kB
        Manoj Govindassamy

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        Upgrading priority to blocker since it's a very incompatible change, though the code change should be straightforward.

        Show
        andrew.wang Andrew Wang added a comment - Upgrading priority to blocker since it's a very incompatible change, though the code change should be straightforward.
        Hide
        manojg Manoj Govindassamy added a comment -

        Attached v01 patch to rename "erasurecode" in commands, test, documents to "ec". Verified this rename by running Test*Erasure*.
        Andrew Wang, can you please take a look ?

        Show
        manojg Manoj Govindassamy added a comment - Attached v01 patch to rename "erasurecode" in commands, test, documents to "ec". Verified this rename by running Test*Erasure*. Andrew Wang , can you please take a look ?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        0 shelldocs 0m 6s Shelldocs was not available.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 13m 18s trunk passed
        +1 compile 0m 53s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 49s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 50s the patch passed
        +1 compile 0m 46s the patch passed
        +1 javac 0m 46s the patch passed
        +1 checkstyle 0m 33s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 shellcheck 0m 12s The patch generated 0 new + 98 unchanged - 1 fixed = 98 total (was 99)
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 1m 52s the patch passed
        +1 javadoc 0m 38s the patch passed
        -1 unit 66m 8s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        92m 38s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11405
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12853671/HDFS-11405.01.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle xml
        uname Linux 937c079b7c32 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6ba61d2
        Default Java 1.8.0_121
        shellcheck v0.4.5
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18410/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18410/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18410/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. 0 shelldocs 0m 6s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 18s trunk passed +1 compile 0m 53s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 46s the patch passed +1 javac 0m 46s the patch passed +1 checkstyle 0m 33s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 11s the patch passed +1 shellcheck 0m 12s The patch generated 0 new + 98 unchanged - 1 fixed = 98 total (was 99) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 38s the patch passed -1 unit 66m 8s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 92m 38s Reason Tests Failed junit tests hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11405 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12853671/HDFS-11405.01.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle xml uname Linux 937c079b7c32 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6ba61d2 Default Java 1.8.0_121 shellcheck v0.4.5 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18410/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18410/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18410/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        The failed tests do not reproduce in my local tree. I reviewed the patch and looks good to me. Ran a few ec commands and all look fine.

        So +1 from me.

        Show
        jojochuang Wei-Chiu Chuang added a comment - The failed tests do not reproduce in my local tree. I reviewed the patch and looks good to me. Ran a few ec commands and all look fine. So +1 from me.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for the patch Manoj! +1 from me too, I grepped for "erasurecode" and didn't see any straggler usages.

        I'll commit this shortly.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for the patch Manoj! +1 from me too, I grepped for "erasurecode" and didn't see any straggler usages. I'll commit this shortly.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks Manoj for the patch and Wei-Chiu for reviewing! I've committed this to trunk.

        Show
        andrew.wang Andrew Wang added a comment - Thanks Manoj for the patch and Wei-Chiu for reviewing! I've committed this to trunk.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11284 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11284/)
        HDFS-11405. Rename "erasurecode" CLI subcommand to "ec". Contributed by (wang: rev fc9ad3ce3aa7d28974b0ac3b554089507c124783)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testErasureCodingConf.xml
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSErasureCoding.md
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/erasurecode/ECCli.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11284 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11284/ ) HDFS-11405 . Rename "erasurecode" CLI subcommand to "ec". Contributed by (wang: rev fc9ad3ce3aa7d28974b0ac3b554089507c124783) (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testErasureCodingConf.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSErasureCoding.md (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/erasurecode/ECCli.java

          People

          • Assignee:
            manojg Manoj Govindassamy
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development