Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11364

Add a test to verify Audit log entries for setfacl/getfacl commands over FS shell

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: hdfs, test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The general phenomena has been to Audit log all successful commands and the ones resulting in AccessControlException. For ACLs, we do have a unit test covering the AccessControlException/Failure cases. Would be better if we can have a unit test covering the successful ACL APIs and ACL commands over FS shell as well.

      Additionally, FS Shell getfacl command has a performance improvement (HADOOP-12776) where by the shell would skip the call to getAclStatus if the permission bits in getFileInfo() doesn't have ACL bit set. Good to have Audit log test covering this case.

      1. HDFS-11364.01.patch
        5 kB
        Manoj Govindassamy

        Issue Links

          Activity

          Hide
          manojg Manoj Govindassamy added a comment -

          Attached v01 patch to verify audit logging for getfacl, setfacl commands over fs shell with and without user ACLs set. Also verifies other successful ACL commands and the audit logging.

          Xiao Chen, can you please take a look at the patch ?

          Show
          manojg Manoj Govindassamy added a comment - Attached v01 patch to verify audit logging for getfacl, setfacl commands over fs shell with and without user ACLs set. Also verifies other successful ACL commands and the audit logging. Xiao Chen , can you please take a look at the patch ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 14m 41s trunk passed
          +1 compile 0m 54s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 50s trunk passed
          +1 javadoc 0m 47s trunk passed
          +1 mvninstall 0m 58s the patch passed
          +1 compile 0m 51s the patch passed
          +1 javac 0m 51s the patch passed
          +1 checkstyle 0m 28s the patch passed
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 57s the patch passed
          +1 javadoc 0m 42s the patch passed
          -1 unit 115m 7s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          143m 7s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11364
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849039/HDFS-11364.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1837c6b13e8e 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a2c5012
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18247/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18247/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18247/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 41s trunk passed +1 compile 0m 54s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 50s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 58s the patch passed +1 compile 0m 51s the patch passed +1 javac 0m 51s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 42s the patch passed -1 unit 115m 7s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 143m 7s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11364 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849039/HDFS-11364.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1837c6b13e8e 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a2c5012 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18247/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18247/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18247/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          manojg Manoj Govindassamy added a comment -

          Xiao Chen, test failures are not related to the patch.

          Show
          manojg Manoj Govindassamy added a comment - Xiao Chen , test failures are not related to the patch.
          Hide
          xiaochen Xiao Chen added a comment -

          Sorry missed the ping earlier. Good to have more tests to cover this. Thanks for the work Manoj.

          Will take a deeper review this week.

          Show
          xiaochen Xiao Chen added a comment - Sorry missed the ping earlier. Good to have more tests to cover this. Thanks for the work Manoj. Will take a deeper review this week.
          Hide
          xiaochen Xiao Chen added a comment -

          Added test looks good, +1. Linked HADOOP-12776 as a dependency.
          Will commit shortly.

          Show
          xiaochen Xiao Chen added a comment - Added test looks good, +1. Linked HADOOP-12776 as a dependency. Will commit shortly.
          Hide
          xiaochen Xiao Chen added a comment -

          Committed to trunk and branch-2, since the dependent HADOOP-12776 is in there too.

          Thanks for the contribution Manoj!

          Show
          xiaochen Xiao Chen added a comment - Committed to trunk and branch-2, since the dependent HADOOP-12776 is in there too. Thanks for the contribution Manoj!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11178 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11178/)
          HDFS-11364. Add a test to verify Audit log entries for setfacl/getfacl (xiao: rev 44606aa8508a6e98219b8330e625c8d397bfb067)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11178 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11178/ ) HDFS-11364 . Add a test to verify Audit log entries for setfacl/getfacl (xiao: rev 44606aa8508a6e98219b8330e625c8d397bfb067) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java

            People

            • Assignee:
              manojg Manoj Govindassamy
              Reporter:
              manojg Manoj Govindassamy
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development