Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11312

Fix incompatible tag number change for nonDfsUsed in DatanodeInfoProto

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      The patches for HDFS-9038 had a discrepancy between trunk and branch-2.7: in one message type, nonDfsUsed is given 2 different indices. This is a minor wire incompatibility that is easy to fix...

      1. HDFS-11312.001.patch
        0.8 kB
        Sean Mackrory

        Issue Links

          Activity

          Hide
          andrew.wang Andrew Wang added a comment -

          It looks like this discrepancy exists between 2.8 and 2.7, so marking this as a blocker for 2.8.0 as well.

          Arpit Agarwal / Brahma Reddy Battula could you take a look at Sean's patch since you have context from HDFS-9038?

          Show
          andrew.wang Andrew Wang added a comment - It looks like this discrepancy exists between 2.8 and 2.7, so marking this as a blocker for 2.8.0 as well. Arpit Agarwal / Brahma Reddy Battula could you take a look at Sean's patch since you have context from HDFS-9038 ?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Sean Mackrory thanks for reporting this and providing the patch..Patch LGTM..Pending for jenkins and Arpit Agarwal have a look on this..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Sean Mackrory thanks for reporting this and providing the patch..Patch LGTM..Pending for jenkins and Arpit Agarwal have a look on this..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 14m 43s trunk passed
          +1 compile 0m 32s trunk passed
          +1 mvnsite 0m 39s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 mvninstall 0m 35s the patch passed
          +1 compile 0m 34s the patch passed
          +1 cc 0m 34s the patch passed
          +1 javac 0m 34s the patch passed
          +1 mvnsite 0m 34s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 unit 0m 57s hadoop-hdfs-client in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          20m 36s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11312
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846701/HDFS-11312.001.patch
          Optional Tests asflicense compile cc mvnsite javac unit
          uname Linux 15272b345031 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4db119b
          Default Java 1.8.0_111
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18143/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18143/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 43s trunk passed +1 compile 0m 32s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 12s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 0m 34s the patch passed +1 cc 0m 34s the patch passed +1 javac 0m 34s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 0m 57s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 20m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11312 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846701/HDFS-11312.001.patch Optional Tests asflicense compile cc mvnsite javac unit uname Linux 15272b345031 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4db119b Default Java 1.8.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18143/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18143/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          +1, Looks good.
          I think it got missed because of tendency of adding new fields at last.
          Since index #9 was not used in trunk/2.8 as well, current change looks good for 2.8 and above. Let 2.7 be same.

          Show
          vinayrpet Vinayakumar B added a comment - +1, Looks good. I think it got missed because of tendency of adding new fields at last. Since index #9 was not used in trunk/2.8 as well, current change looks good for 2.8 and above. Let 2.7 be same.
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks for the reviews Brahma and Vinay, +1 LGTM too. Committed to trunk, branch-2, branch-2.8.

          Thanks Sean for the quick turnaround on this blocker issue!

          Show
          andrew.wang Andrew Wang added a comment - Thanks for the reviews Brahma and Vinay, +1 LGTM too. Committed to trunk, branch-2, branch-2.8. Thanks Sean for the quick turnaround on this blocker issue!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11109 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11109/)
          HDFS-11312. Fix incompatible tag number change for nonDfsUsed in (wang: rev d51f8ba80816c20cd97ba5aa839a84b0bb6a7291)

          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/hdfs.proto
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11109 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11109/ ) HDFS-11312 . Fix incompatible tag number change for nonDfsUsed in (wang: rev d51f8ba80816c20cd97ba5aa839a84b0bb6a7291) (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/hdfs.proto
          Hide
          djp Junping Du added a comment -

          Merge to branch-2.8.0.

          Show
          djp Junping Du added a comment - Merge to branch-2.8.0.

            People

            • Assignee:
              mackrorysd Sean Mackrory
              Reporter:
              mackrorysd Sean Mackrory
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development