[HDFS-11281] The metric of fileIoErrorRate not counted in DataNodeVolumeMetrics

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.0.0-alpha2
• Assignee: Yiqun Lin
• Reporter: Yiqun Lin
• Created: 29/Dec/16 03:23
• Updated: 29/Dec/16 12:18

Description

After HDFS-10959, it added disk IO statistics and metrics in DataNode. This metrics was defined in DataNodeVolumeMetrics. But the metric of fileIoErrorRate was not counted in DataNodeVolumeMetrics. The relevant codes:

  public void addFileIoError(final long latency) {
    totalFileIoErrors.incr();
    metadataOperationRate.add(latency);
  }

Here the metric metadataOperationRate should be fileIoErrorRate. Two reasons: 1.metadataOperationRate has been counted in addMetadastaOperationLatency. 2.fileIoErrorRate is never counted in the class DataNodeVolumeMetrics.

Issue Links

• relates to: HDFS-10959 Adding per disk IO statistics and metrics in DataNode.