Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11258

File mtime change could not save to editlog

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When both mtime and atime are changed, and atime is not beyond the precision limit, the mtime change is not saved to edit logs.

      1. hdfs-11258.1.patch
        0.9 kB
        Jimmy Xiang
      2. hdfs-11258.2.patch
        5 kB
        Jimmy Xiang
      3. hdfs-11258.3.patch
        5 kB
        Jimmy Xiang
      4. hdfs-11258.4.patch
        5 kB
        Jimmy Xiang
      5. hdfs-11258-addendum-branch2.patch
        1 kB
        Jimmy Xiang

        Issue Links

          Activity

          Hide
          wheat9 Haohui Mai added a comment -

          Thanks Jimmy Xiang for reporting the issue! Can you please add a unit test for it? Thanks.

          Show
          wheat9 Haohui Mai added a comment - Thanks Jimmy Xiang for reporting the issue! Can you please add a unit test for it? Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 29s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 14m 49s trunk passed
          +1 compile 1m 2s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 45s trunk passed
          +1 javadoc 0m 42s trunk passed
          +1 mvninstall 0m 49s the patch passed
          +1 compile 0m 45s the patch passed
          +1 javac 0m 45s the patch passed
          +1 checkstyle 0m 24s the patch passed
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 38s the patch passed
          -1 unit 93m 45s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          121m 27s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843670/hdfs-11258.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1007037699dd 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fcbe152
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17880/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17880/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17880/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 49s trunk passed +1 compile 1m 2s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 42s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 38s the patch passed -1 unit 93m 45s hadoop-hdfs in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 121m 27s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843670/hdfs-11258.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1007037699dd 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fcbe152 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17880/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17880/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17880/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jxiang Jimmy Xiang added a comment -

          Patch v2, added a unit test.

          Show
          jxiang Jimmy Xiang added a comment - Patch v2, added a unit test.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 12m 47s trunk passed
          +1 compile 0m 51s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 39s trunk passed
          +1 javadoc 0m 40s trunk passed
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 43s the patch passed
          +1 javac 0m 43s the patch passed
          -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 10 unchanged - 1 fixed = 16 total (was 11)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 45s the patch passed
          +1 javadoc 0m 36s the patch passed
          +1 unit 62m 15s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          86m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843773/hdfs-11258.2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b7d68c7f754f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fcbe152
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17884/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17884/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17884/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 47s trunk passed +1 compile 0m 51s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 10 unchanged - 1 fixed = 16 total (was 11) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 36s the patch passed +1 unit 62m 15s hadoop-hdfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 86m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843773/hdfs-11258.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b7d68c7f754f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fcbe152 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17884/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17884/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17884/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          The patch looks pretty good to me. Thanks Jimmy Xiang for working on this.

          One nit: can you please fix the checkstyle issues? +1 after addressing that.

          Show
          wheat9 Haohui Mai added a comment - The patch looks pretty good to me. Thanks Jimmy Xiang for working on this. One nit: can you please fix the checkstyle issues? +1 after addressing that.
          Hide
          wheat9 Haohui Mai added a comment -

          I'm going to bump the priority from minor to critical because it can generate excessive edit logs and slow down the NNs. We have observed that HBase keeps calling setTimes() due to this bug.

          Show
          wheat9 Haohui Mai added a comment - I'm going to bump the priority from minor to critical because it can generate excessive edit logs and slow down the NNs. We have observed that HBase keeps calling setTimes() due to this bug.
          Hide
          jxiang Jimmy Xiang added a comment -

          Thanks Haohui Mai for the review. Fixed the checkstyles.

          Show
          jxiang Jimmy Xiang added a comment - Thanks Haohui Mai for the review. Fixed the checkstyles.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 12m 42s trunk passed
          +1 compile 0m 45s trunk passed
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 40s trunk passed
          +1 javadoc 0m 40s trunk passed
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 43s the patch passed
          +1 javac 0m 43s the patch passed
          -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 10 unchanged - 1 fixed = 17 total (was 11)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 46s the patch passed
          +1 javadoc 0m 38s the patch passed
          +1 unit 63m 28s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          87m 33s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844121/hdfs-11258.3.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dfc3e2a5eac1 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 523411d
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17922/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17922/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17922/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 42s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 10 unchanged - 1 fixed = 17 total (was 11) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 38s the patch passed +1 unit 63m 28s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 87m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844121/hdfs-11258.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dfc3e2a5eac1 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 523411d Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17922/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17922/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17922/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 12m 27s trunk passed
          +1 compile 0m 45s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 40s trunk passed
          +1 javadoc 0m 40s trunk passed
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 41s the patch passed
          +1 javac 0m 41s the patch passed
          +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 47s the patch passed
          +1 javadoc 0m 36s the patch passed
          -1 unit 65m 22s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          89m 16s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11258
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844144/hdfs-11258.4.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux afd485da6b7f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f678080
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17923/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17923/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17923/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 27s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 36s the patch passed -1 unit 65m 22s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 89m 16s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11258 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844144/hdfs-11258.4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux afd485da6b7f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f678080 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17923/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17923/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17923/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1.
          Hide
          wheat9 Haohui Mai added a comment -

          The unit test is irrelevant. Will commit shortly.

          Show
          wheat9 Haohui Mai added a comment - The unit test is irrelevant. Will commit shortly.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11026 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11026/)
          HDFS-11258. File mtime change could not save to editlog. Contributed by (wheat9: rev f6e80acd681548b14fe3f0f3d2b3aaf800d10310)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
          • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSDirAttrOp.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11026 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11026/ ) HDFS-11258 . File mtime change could not save to editlog. Contributed by (wheat9: rev f6e80acd681548b14fe3f0f3d2b3aaf800d10310) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSDirAttrOp.java
          Hide
          wheat9 Haohui Mai added a comment -

          Committed to trunk, branch-3.0.0-alpha1, branch-2 and branch-2.8. Thanks Jimmy Xiang for the contribution.

          Show
          wheat9 Haohui Mai added a comment - Committed to trunk, branch-3.0.0-alpha1, branch-2 and branch-2.8. Thanks Jimmy Xiang for the contribution.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Hi Haohui Mai, branch-2 and branch-2.8 are broken after this fix. Would you fix this?

          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project hadoop-hdfs: Compilation failure: Compilation failure:
          [ERROR] /Users/ajisaka/git/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSDirAttrOp.java:[48,13] no suitable method found for getINodesInPath(java.lang.String,boolean)
          [ERROR] method org.apache.hadoop.hdfs.server.namenode.FSDirectory.getINodesInPath(java.lang.String,org.apache.hadoop.hdfs.server.namenode.FSDirectory.DirOp) is not applicable
          [ERROR] (argument mismatch; boolean cannot be converted to org.apache.hadoop.hdfs.server.namenode.FSDirectory.DirOp)
          [ERROR] method org.apache.hadoop.hdfs.server.namenode.FSDirectory.getINodesInPath(byte[][],org.apache.hadoop.hdfs.server.namenode.FSDirectory.DirOp) is not applicable
          [ERROR] (argument mismatch; java.lang.String cannot be converted to byte[][])
          [ERROR] /Users/ajisaka/git/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSDirAttrOp.java:[53,49] incompatible types: java.lang.String cannot be converted to org.apache.hadoop.hdfs.server.namenode.INodesInPath
          
          Show
          ajisakaa Akira Ajisaka added a comment - Hi Haohui Mai , branch-2 and branch-2.8 are broken after this fix. Would you fix this? [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project hadoop-hdfs: Compilation failure: Compilation failure: [ERROR] /Users/ajisaka/git/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSDirAttrOp.java:[48,13] no suitable method found for getINodesInPath(java.lang.String,boolean) [ERROR] method org.apache.hadoop.hdfs.server.namenode.FSDirectory.getINodesInPath(java.lang.String,org.apache.hadoop.hdfs.server.namenode.FSDirectory.DirOp) is not applicable [ERROR] (argument mismatch; boolean cannot be converted to org.apache.hadoop.hdfs.server.namenode.FSDirectory.DirOp) [ERROR] method org.apache.hadoop.hdfs.server.namenode.FSDirectory.getINodesInPath(byte[][],org.apache.hadoop.hdfs.server.namenode.FSDirectory.DirOp) is not applicable [ERROR] (argument mismatch; java.lang.String cannot be converted to byte[][]) [ERROR] /Users/ajisaka/git/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSDirAttrOp.java:[53,49] incompatible types: java.lang.String cannot be converted to org.apache.hadoop.hdfs.server.namenode.INodesInPath
          Hide
          jxiang Jimmy Xiang added a comment -

          Attached an addendum for branch-2 to fix compilation.

          Show
          jxiang Jimmy Xiang added a comment - Attached an addendum for branch-2 to fix compilation.
          Hide
          jxiang Jimmy Xiang added a comment -

          The addendum is good for both branch 2 and 2.8.

          Show
          jxiang Jimmy Xiang added a comment - The addendum is good for both branch 2 and 2.8.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1 for the addendum patch. Thanks Jimmy Xiang for the quick fix.

          Show
          ajisakaa Akira Ajisaka added a comment - +1 for the addendum patch. Thanks Jimmy Xiang for the quick fix.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed the addendum patch to branch-2 and branch-2.8. Thanks!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed the addendum patch to branch-2 and branch-2.8. Thanks!
          Hide
          ajisakaa Akira Ajisaka added a comment -
              assertFalse("SetTimes should not update access time"
                    + "because it's within the last precision interval",
          

          Trivial: A whitespace is missing between time and because. Filed HDFS-11272 for the additional fix.

          Show
          ajisakaa Akira Ajisaka added a comment - assertFalse( "SetTimes should not update access time" + "because it's within the last precision interval" , Trivial: A whitespace is missing between time and because. Filed HDFS-11272 for the additional fix.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Seems branch 2.7 also has this issue. Akira Ajisaka, Haohui Mai, can you please commit to banch 2.7 also ?

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Seems branch 2.7 also has this issue. Akira Ajisaka , Haohui Mai , can you please commit to banch 2.7 also ?
          Hide
          wheat9 Haohui Mai added a comment -

          Thanks for the reminder. I'll take care of it.

          Show
          wheat9 Haohui Mai added a comment - Thanks for the reminder. I'll take care of it.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Kanaka Kumar Avvaru for the reminder. The patches cannot be applied to branch-2.7, so I'll file a jira for backporting this and HDFS-11272 to branch-2.7 and create a patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Kanaka Kumar Avvaru for the reminder. The patches cannot be applied to branch-2.7, so I'll file a jira for backporting this and HDFS-11272 to branch-2.7 and create a patch.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Filed HDFS-11373 and created a patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Filed HDFS-11373 and created a patch.

            People

            • Assignee:
              jxiang Jimmy Xiang
              Reporter:
              jxiang Jimmy Xiang
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development