[HDFS-11253] FileInputStream leak on failure path in BlockSender

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha2
• Fix Version/s: 2.9.0, 3.0.0-alpha2
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: Arpit Agarwal
• Reporter: Arpit Agarwal
• Created: 15/Dec/16 21:05
• Updated: 19/Jan/17 06:49
• Resolved: 15/Dec/16 23:44

Description

The BlockSender constructor should close the blockIn and checksumIn streams here:

405:       blockIn = datanode.data.getBlockInputStream(block, offset); // seek to offset
406:       ris = new ReplicaInputStreams(
407:           blockIn, checksumIn, volumeRef, fileIoProvider);
408:     } catch (IOException ioe) {
409:       IOUtils.closeStream(this);
410:       throw ioe;
411:     }

Issue Links

• is broken by: HDFS-10930 Refactor: Wrap Datanode IO related operations