Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11253

FileInputStream leak on failure path in BlockSender

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-alpha2
    • 2.9.0, 3.0.0-alpha2
    • datanode
    • None
    • Reviewed

    Description

      The BlockSender constructor should close the blockIn and checksumIn streams here:

      405:       blockIn = datanode.data.getBlockInputStream(block, offset); // seek to offset
      406:       ris = new ReplicaInputStreams(
      407:           blockIn, checksumIn, volumeRef, fileIoProvider);
      408:     } catch (IOException ioe) {
      409:       IOUtils.closeStream(this);
      410:       throw ioe;
      411:     }
      

      Attachments

        1. HDFS-11253.01.patch
          0.8 kB
          Arpit Agarwal

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            arp Arpit Agarwal
            arp Arpit Agarwal
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment