Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11211

Add a time unit to the DataNode client trace format

    Details

    • Hadoop Flags:
      Reviewed

      Description

      DataNode.java
        public static final String DN_CLIENTTRACE_FORMAT =
              "src: %s" +      // src IP
              ", dest: %s" +   // dst IP
              ", bytes: %s" +  // byte count
              ", op: %s" +     // operation
              ", cliID: %s" +  // DFSClient id
              ", offset: %s" + // offset
              ", srvID: %s" +  // DatanodeRegistration
              ", blockid: %s" + // block id
              ", duration: %s";  // duration time
      

      The time unit of the duration is nanosecond, but it is not documented.

      1. HDFS-11211_00.patch
        0.9 kB
        Jagadesh Kiran N

        Activity

        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Thanks Mingliang Liu for commiting the same , thanks Akira Ajisaka for reporting the same & thanks Yiqun Lin for reviewing the same

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Thanks Mingliang Liu for commiting the same , thanks Akira Ajisaka for reporting the same & thanks Yiqun Lin for reviewing the same
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10950 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10950/)
        HDFS-11211. Add a time unit to the DataNode client trace format. (liuml07: rev 43cb1678cc000b1fbf8b813ee14ecef19b86a55c)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10950 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10950/ ) HDFS-11211 . Add a time unit to the DataNode client trace format. (liuml07: rev 43cb1678cc000b1fbf8b813ee14ecef19b86a55c) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        liuml07 Mingliang Liu added a comment -

        +1

        Committed to trunk and branch-2 branches. Thanks Akira Ajisaka for reporting this; thanks Jagadesh Kiran N for providing a patch; thanks Yiqun Lin for review.

        Show
        liuml07 Mingliang Liu added a comment - +1 Committed to trunk and branch-2 branches. Thanks Akira Ajisaka for reporting this; thanks Jagadesh Kiran N for providing a patch; thanks Yiqun Lin for review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 51s trunk passed
        +1 compile 0m 51s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 0m 38s trunk passed
        +1 mvninstall 0m 51s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 58s the patch passed
        +1 javadoc 0m 40s the patch passed
        +1 unit 64m 29s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        83m 47s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11211
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841933/HDFS-11211_00.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3a827f9f6ff9 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7b988e8
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17773/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17773/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 51s trunk passed +1 compile 0m 51s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 0m 38s trunk passed +1 mvninstall 0m 51s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 40s the patch passed +1 unit 64m 29s hadoop-hdfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 83m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11211 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841933/HDFS-11211_00.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3a827f9f6ff9 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7b988e8 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17773/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17773/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        +1, I confirmed the format of this again , it's nanosecond here. Thanks Jagadesh Kiran N for contributing the patch.

        Show
        linyiqun Yiqun Lin added a comment - +1, I confirmed the format of this again , it's nanosecond here. Thanks Jagadesh Kiran N for contributing the patch.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Attaching the patch Akira Ajisaka ,please review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Attaching the patch Akira Ajisaka ,please review
        Hide
        linyiqun Yiqun Lin added a comment -

        HI Akira Ajisaka, I think this is also the issues of the time format in HDFS, like HDFS-11140. Would you also have a look for that? Thanks in advance.

        Show
        linyiqun Yiqun Lin added a comment - HI Akira Ajisaka , I think this is also the issues of the time format in HDFS, like HDFS-11140 . Would you also have a look for that? Thanks in advance.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        "duration(ns): %s" seems fine.

        Show
        ajisakaa Akira Ajisaka added a comment - "duration(ns): %s" seems fine.

          People

          • Assignee:
            jagadesh.kiran Jagadesh Kiran N
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development