[HDFS-11207] Revert HDFS-5079. Cleaning up NNHAStatusHeartbeat.State DatanodeProtocolProtos.

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Done
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 3.0.0-alpha2
• Component/s: rolling upgrades
• Target Version/s: 3.0.0-alpha2

Release Note

HDFS-5079 was reverted since it introduced incompatible protocol changes that blocked rolling upgrade.

• Assignee: Eric Badger
• Reporter: Eric Badger
• Created: 05/Dec/16 22:07
• Updated: 08/Dec/16 23:07
• Resolved: 08/Dec/16 21:50

Description

HDFS-5079 changed the meaning of state in NNHAStatusHeartbeat when it added in the INITIALIZING state via HAServiceStateProto.

Before change:

enum State {
   ACTIVE = 0;
   STANDBY = 1;
}

After change:

enum HAServiceStateProto {
  INITIALIZING = 0;
  ACTIVE = 1;
  STANDBY = 2;
}

So the new INITIALIZING state will be interpreted as ACTIVE, new ACTIVE interpreted as STANDBY and new STANDBY interpreted as unknown. Any rolling upgrade to 3.0.0 will break because the datanodes that haven't been updated will misinterpret the NN state.

Issue Links

• is broken by: HDFS-5079 Cleaning up NNHAStatusHeartbeat.State DatanodeProtocolProtos.
• relates to: HDFS-11096 Support rolling upgrade between 2.x and 3.x