Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: erasure-coding
    • Labels:
      None

      Description

      So far, "hdfs erasurecode" command supports three policies, RS-DEFAULT-3-2-64k, RS-DEFAULT-6-3-64k and RS-LEGACY-6-3-64k. This task is going to add RS-DEFAULT-10-4-64k policy to this command.

      1. HDFS-11172-v1.patch
        10 kB
        Wei Zhou
      2. HDFS-11172-v2.patch
        10 kB
        Wei Zhou

        Activity

        Hide
        zhouwei Wei Zhou added a comment -

        Initial patch to add this erasure coding policy. Thanks!

        Show
        zhouwei Wei Zhou added a comment - Initial patch to add this erasure coding policy. Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 1m 48s Maven dependency ordering for branch
        +1 mvninstall 6m 57s trunk passed
        +1 compile 9m 35s trunk passed
        +1 checkstyle 1m 31s trunk passed
        +1 mvnsite 2m 39s trunk passed
        +1 mvneclipse 0m 54s trunk passed
        -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings.
        +1 javadoc 1m 55s trunk passed
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 51s the patch passed
        +1 compile 9m 6s the patch passed
        +1 javac 9m 6s the patch passed
        -0 checkstyle 1m 31s root: The patch generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7)
        +1 mvnsite 2m 36s the patch passed
        +1 mvneclipse 0m 54s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 3s the patch passed
        +1 javadoc 1m 57s the patch passed
        +1 unit 8m 23s hadoop-common in the patch passed.
        +1 unit 1m 0s hadoop-hdfs-client in the patch passed.
        -1 unit 62m 40s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 34s The patch does not generate ASF License warnings.
        127m 39s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11172
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841718/HDFS-11172-v1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux dca39e0c527e 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f885160
        Default Java 1.8.0_111
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17758/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17758/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17758/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17758/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17758/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 48s Maven dependency ordering for branch +1 mvninstall 6m 57s trunk passed +1 compile 9m 35s trunk passed +1 checkstyle 1m 31s trunk passed +1 mvnsite 2m 39s trunk passed +1 mvneclipse 0m 54s trunk passed -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 55s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 51s the patch passed +1 compile 9m 6s the patch passed +1 javac 9m 6s the patch passed -0 checkstyle 1m 31s root: The patch generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7) +1 mvnsite 2m 36s the patch passed +1 mvneclipse 0m 54s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 3s the patch passed +1 javadoc 1m 57s the patch passed +1 unit 8m 23s hadoop-common in the patch passed. +1 unit 1m 0s hadoop-hdfs-client in the patch passed. -1 unit 62m 40s hadoop-hdfs in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 127m 39s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11172 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841718/HDFS-11172-v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dca39e0c527e 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f885160 Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17758/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17758/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17758/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17758/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17758/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for working on this Wei Zhou, looks good overall. checkstyle caught an unnecessary import which we should fix. We also could use a space before the braces here:

            extends TestDFSStripedOutputStream{
            extends TestDFSStripedOutputStreamWithFailure{
        

        SammiChen, Rakesh R want to take a quick look too? I'm +1 pending.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for working on this Wei Zhou, looks good overall. checkstyle caught an unnecessary import which we should fix. We also could use a space before the braces here: extends TestDFSStripedOutputStream{ extends TestDFSStripedOutputStreamWithFailure{ SammiChen , Rakesh R want to take a quick look too? I'm +1 pending.
        Hide
        zhouwei Wei Zhou added a comment -

        Thanks Andrew Wang for reviewing! The patch is updated and other failures are unrelated. Thanks!

        Show
        zhouwei Wei Zhou added a comment - Thanks Andrew Wang for reviewing! The patch is updated and other failures are unrelated. Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 1m 23s Maven dependency ordering for branch
        +1 mvninstall 9m 38s trunk passed
        +1 compile 11m 57s trunk passed
        +1 checkstyle 1m 53s trunk passed
        +1 mvnsite 3m 26s trunk passed
        +1 mvneclipse 1m 1s trunk passed
        +1 findbugs 5m 51s trunk passed
        +1 javadoc 2m 11s trunk passed
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 2m 25s the patch passed
        +1 compile 11m 57s the patch passed
        +1 javac 11m 57s the patch passed
        +1 checkstyle 1m 45s the patch passed
        +1 mvnsite 3m 15s the patch passed
        +1 mvneclipse 1m 5s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 6m 44s the patch passed
        +1 javadoc 2m 10s the patch passed
        +1 unit 7m 45s hadoop-common in the patch passed.
        +1 unit 1m 1s hadoop-hdfs-client in the patch passed.
        -1 unit 63m 37s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 34s The patch does not generate ASF License warnings.
        141m 39s



        Reason Tests
        Failed junit tests hadoop.tracing.TestTracing



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11172
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841870/HDFS-11172-v2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 41ccfd2a8ac6 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a2b5d60
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17768/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17768/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17768/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 23s Maven dependency ordering for branch +1 mvninstall 9m 38s trunk passed +1 compile 11m 57s trunk passed +1 checkstyle 1m 53s trunk passed +1 mvnsite 3m 26s trunk passed +1 mvneclipse 1m 1s trunk passed +1 findbugs 5m 51s trunk passed +1 javadoc 2m 11s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 2m 25s the patch passed +1 compile 11m 57s the patch passed +1 javac 11m 57s the patch passed +1 checkstyle 1m 45s the patch passed +1 mvnsite 3m 15s the patch passed +1 mvneclipse 1m 5s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 6m 44s the patch passed +1 javadoc 2m 10s the patch passed +1 unit 7m 45s hadoop-common in the patch passed. +1 unit 1m 1s hadoop-hdfs-client in the patch passed. -1 unit 63m 37s hadoop-hdfs in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 141m 39s Reason Tests Failed junit tests hadoop.tracing.TestTracing Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11172 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841870/HDFS-11172-v2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 41ccfd2a8ac6 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a2b5d60 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17768/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17768/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17768/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        It's good to support an RS(10, 4) policy, as it's widely used in the industry. Thanks Wei Zhou for doing this.

        Show
        drankye Kai Zheng added a comment - It's good to support an RS(10, 4) policy, as it's widely used in the industry. Thanks Wei Zhou for doing this.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for the contribution Wei Zhou, I've committed this to trunk.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for the contribution Wei Zhou , I've committed this to trunk.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10953 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10953/)
        HDFS-11172. Support an erasure coding policy using RS 10 + 4. (wang: rev f53b481ffeec64831c1d9b54a555c7b570d116a3)

        • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRSDefault10x4StripedOutputStream.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
        • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRSDefault10x4StripedInputStream.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ErasureCodeConstants.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSErasureCoding.md
        • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRSDefault10x4StripedOutputStreamWithFailure.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10953 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10953/ ) HDFS-11172 . Support an erasure coding policy using RS 10 + 4. (wang: rev f53b481ffeec64831c1d9b54a555c7b570d116a3) (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRSDefault10x4StripedOutputStream.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRSDefault10x4StripedInputStream.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ErasureCodeConstants.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSErasureCoding.md (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRSDefault10x4StripedOutputStreamWithFailure.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java

          People

          • Assignee:
            zhouwei Wei Zhou
            Reporter:
            Sammi SammiChen
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development